Re: [PATCH] btrfs: qgroups: Move transaction managed inside btrfs_quota_enable

2018-07-04 Thread David Sterba
On Tue, Jul 03, 2018 at 11:54:11AM +0300, Nikolay Borisov wrote: > > > On 2.07.2018 18:40, David Sterba wrote: > > On Mon, Jul 02, 2018 at 02:00:34PM +0300, Nikolay Borisov wrote: > >> Commit 5d23515be669 ("btrfs: Move qgroup rescan on quota enable to > >> btrfs_quota_enable") not only resulted

Re: [PATCH] btrfs: qgroups: Move transaction managed inside btrfs_quota_enable

2018-07-03 Thread Nikolay Borisov
On 2.07.2018 18:40, David Sterba wrote: > On Mon, Jul 02, 2018 at 02:00:34PM +0300, Nikolay Borisov wrote: >> Commit 5d23515be669 ("btrfs: Move qgroup rescan on quota enable to >> btrfs_quota_enable") not only resulted in an easier to follow code but >> it also introduced a subtle bug. It chang

Re: [PATCH] btrfs: qgroups: Move transaction managed inside btrfs_quota_enable

2018-07-02 Thread Misono Tomohiro
On 2018/07/02 20:00, Nikolay Borisov wrote: > Commit 5d23515be669 ("btrfs: Move qgroup rescan on quota enable to > btrfs_quota_enable") not only resulted in an easier to follow code but > it also introduced a subtle bug. It changed the timing when the initial > transaction rescan was happening -

Re: [PATCH] btrfs: qgroups: Move transaction managed inside btrfs_quota_enable

2018-07-02 Thread David Sterba
On Mon, Jul 02, 2018 at 02:00:34PM +0300, Nikolay Borisov wrote: > Commit 5d23515be669 ("btrfs: Move qgroup rescan on quota enable to > btrfs_quota_enable") not only resulted in an easier to follow code but > it also introduced a subtle bug. It changed the timing when the initial > transaction resc

Re: [PATCH] btrfs: qgroups: Move transaction managed inside btrfs_quota_enable

2018-07-02 Thread Nikolay Borisov
On 2.07.2018 14:00, Nikolay Borisov wrote: > Commit 5d23515be669 ("btrfs: Move qgroup rescan on quota enable to > btrfs_quota_enable") not only resulted in an easier to follow code but > it also introduced a subtle bug. It changed the timing when the initial > transaction rescan was happening -

Re: [PATCH] btrfs: qgroups: Move transaction managed inside btrfs_quota_enable

2018-06-27 Thread Qu Wenruo
On 2018年06月26日 16:46, Misono Tomohiro wrote: > On 2018/06/26 16:09, Nikolay Borisov wrote: >> Commit 5d23515be669 ("btrfs: Move qgroup rescan on quota enable to >> btrfs_quota_enable") not only resulted in an easier to follow code but >> it also introduced a subtle bug. It changed the timing whe

Re: [PATCH] btrfs: qgroups: Move transaction managed inside btrfs_quota_enable

2018-06-26 Thread Nikolay Borisov
On 26.06.2018 11:46, Misono Tomohiro wrote: > On 2018/06/26 16:09, Nikolay Borisov wrote: >> Commit 5d23515be669 ("btrfs: Move qgroup rescan on quota enable to >> btrfs_quota_enable") not only resulted in an easier to follow code but >> it also introduced a subtle bug. It changed the timing when

Re: [PATCH] btrfs: qgroups: Move transaction managed inside btrfs_quota_enable

2018-06-26 Thread Misono Tomohiro
On 2018/06/26 16:09, Nikolay Borisov wrote: > Commit 5d23515be669 ("btrfs: Move qgroup rescan on quota enable to > btrfs_quota_enable") not only resulted in an easier to follow code but > it also introduced a subtle bug. It changed the timing when the initial > transaction rescan was happening - be