Re: [PATCH] btrfs: zoned: remove outdated WARN_ON in direct IO

2021-03-17 Thread Johannes Thumshirn
On 17/03/2021 15:29, David Sterba wrote: > On Wed, Mar 17, 2021 at 01:22:11PM +, Johannes Thumshirn wrote: >> On 17/03/2021 14:20, Johannes Thumshirn wrote: >>> On 17/03/2021 11:54, David Sterba wrote: On Wed, Mar 17, 2021 at 05:57:31PM +0900, Johannes Thumshirn wrote: > In btrfs_submi

Re: [PATCH] btrfs: zoned: remove outdated WARN_ON in direct IO

2021-03-17 Thread David Sterba
On Wed, Mar 17, 2021 at 01:22:11PM +, Johannes Thumshirn wrote: > On 17/03/2021 14:20, Johannes Thumshirn wrote: > > On 17/03/2021 11:54, David Sterba wrote: > >> On Wed, Mar 17, 2021 at 05:57:31PM +0900, Johannes Thumshirn wrote: > >>> In btrfs_submit_direct() there's a WAN_ON_ONCE() that will

Re: [PATCH] btrfs: zoned: remove outdated WARN_ON in direct IO

2021-03-17 Thread Johannes Thumshirn
On 17/03/2021 14:20, Johannes Thumshirn wrote: > On 17/03/2021 11:54, David Sterba wrote: >> On Wed, Mar 17, 2021 at 05:57:31PM +0900, Johannes Thumshirn wrote: >>> In btrfs_submit_direct() there's a WAN_ON_ONCE() that will trigger if >>> we're submitting a DIO write on a zoned filesystem but are n

Re: [PATCH] btrfs: zoned: remove outdated WARN_ON in direct IO

2021-03-17 Thread Johannes Thumshirn
On 17/03/2021 11:54, David Sterba wrote: > On Wed, Mar 17, 2021 at 05:57:31PM +0900, Johannes Thumshirn wrote: >> In btrfs_submit_direct() there's a WAN_ON_ONCE() that will trigger if >> we're submitting a DIO write on a zoned filesystem but are not using >> REQ_OP_ZONE_APPEND to submit the IO to t

Re: [PATCH] btrfs: zoned: remove outdated WARN_ON in direct IO

2021-03-17 Thread David Sterba
On Wed, Mar 17, 2021 at 05:57:31PM +0900, Johannes Thumshirn wrote: > In btrfs_submit_direct() there's a WAN_ON_ONCE() that will trigger if > we're submitting a DIO write on a zoned filesystem but are not using > REQ_OP_ZONE_APPEND to submit the IO to the block device. > > This is a left over from