Re: [PATCH] btrfs-progs: drop unique uuid test for btrfstune -M

2019-10-18 Thread Anand Jain
On 10/18/19 12:32 AM, David Sterba wrote: On Thu, Sep 12, 2019 at 08:45:50AM +0800, Anand Jain wrote: In case of vm guest images copied from the golden image there is no physical device or loop device or nbd device until its configured on the host when required, so check for duplicate fsid at th

Re: [PATCH] btrfs-progs: drop unique uuid test for btrfstune -M

2019-10-17 Thread David Sterba
On Thu, Sep 12, 2019 at 08:45:50AM +0800, Anand Jain wrote: > In case of vm guest images copied from the golden image there is no > physical device or loop device or nbd device until its configured on > the host when required, so check for duplicate fsid at the time of > btrfstune -M is not convinc

Re: [PATCH] btrfs-progs: drop unique uuid test for btrfstune -M

2019-10-01 Thread Anand Jain
Ping. Just found that- an image with metadata_uuid can't be a seed device - does not make any sense to me as to why. And test_uuid_unique() blocks undo of metadata_uuid on certain systems. Moreover the reason to use test_uuid_unique() in the first place is arbitrary. Thanks, Anand On 9/

Re: [PATCH] btrfs-progs: drop unique uuid test for btrfstune -M

2019-09-24 Thread Anand Jain
David, ping on this patch. On 9/12/19 8:45 AM, Anand Jain wrote: thanks for the comments, more inline below. - btrfstume -M isn't the place to check if the fsid is a     duplicate. Because, libblkid will be unaware of the complete list of     fs images with its fsid. I don't understand

Re: [PATCH] btrfs-progs: drop unique uuid test for btrfstune -M

2019-09-11 Thread Anand Jain
thanks for the comments, more inline below. - btrfstume -M isn't the place to check if the fsid is a duplicate. Because, libblkid will be unaware of the complete list of fs images with its fsid. I don't understand this part. Blkid tracks the device iformation, like the uuid, and the

Re: [PATCH] btrfs-progs: drop unique uuid test for btrfstune -M

2019-09-11 Thread David Sterba
On Tue, Sep 10, 2019 at 01:12:43PM +0800, Anand Jain wrote: > > Nikolay, > > >>> This is intended. Otherwise it's an open avenue for the user to shoot > >>> themselves in the foot. > >> > >>  I don't understand how? > > Again. Any idea how? Is there any test case? > > > > > UUID, by defi

Re: [PATCH] btrfs-progs: drop unique uuid test for btrfstune -M

2019-09-09 Thread Anand Jain
Nikolay, This is intended. Otherwise it's an open avenue for the user to shoot themselves in the foot.  I don't understand how? Again. Any idea how? Is there any test case? UUID, by definition, are Unique. What you want to is to toss the Unique part, meaning we'll really be left wit

Re: [PATCH] btrfs-progs: drop unique uuid test for btrfstune -M

2019-09-09 Thread Nikolay Borisov
On 6.09.19 г. 12:27 ч., Anand Jain wrote: > > > >> This is intended. Otherwise it's an open avenue for the user to shoot >> themselves in the foot. > >  I don't understand how? > >> If you know what you are doing and are >> absolutely sure the original fs is no longer present - then just fl

Re: [PATCH] btrfs-progs: drop unique uuid test for btrfstune -M

2019-09-06 Thread Anand Jain
This is intended. Otherwise it's an open avenue for the user to shoot themselves in the foot. I don't understand how? If you know what you are doing and are absolutely sure the original fs is no longer present - then just flush libblkid cache and you'll be able to set the FSID back to

Re: [PATCH] btrfs-progs: drop unique uuid test for btrfstune -M

2019-09-06 Thread Nikolay Borisov
On 6.09.19 г. 3:50 ч., Anand Jain wrote: > It's common to copy/snapshot an OS image to run another instance of the OS. > A duplicate fsid can't be mounted on the same system unless the fsid is > changed by using btrfstune -m. > > However in some circumstances the image needs to go back to the o