Re: [PATCH] xfstests: enable test 032 (mkfs overwrite) for btrfs

2013-03-16 Thread Linda Walsh
Eric Sandeen wrote: >> >> It did not put mkfs.btrfs in /sbin. This did however, validate all the >> error paths ;). > Heh ;) > Well, mixing & matching upstream installs from source w/ rpm-packaged > binaries is usually asking for trouble. > I don't think it's a bug, just bad administrative p

Re: [PATCH] xfstests: enable test 032 (mkfs overwrite) for btrfs

2013-03-15 Thread Eric Sandeen
On 3/15/13 12:07 PM, Rich Johnston wrote: > Eric, > > Thanks once more for the patch. Once I finally got the correct version of > mkfs.btrfs this looks good. > > Reviewed-by: Rich Johnston > > Interesting that the default make install of btrfs-progs did not install over > my btrfsprogs rpm.

Re: [PATCH] xfstests: enable test 032 (mkfs overwrite) for btrfs

2013-03-15 Thread Rich Johnston
This patch has been commited. Thanks --Rich commit 99eb53da9c08148132cdf3cd401b248e6a0d96c5 Author: Eric Sandeen Date: Wed Mar 13 16:01:00 2013 + xfstests: enable test 032 (mkfs overwrite) for btrfs Now that btrfs has an "-f" arg, we can test that it doesn't improperly overw

Re: [PATCH] xfstests: enable test 032 (mkfs overwrite) for btrfs

2013-03-15 Thread Rich Johnston
Eric, Thanks once more for the patch. Once I finally got the correct version of mkfs.btrfs this looks good. Reviewed-by: Rich Johnston Interesting that the default make install of btrfs-progs did not install over my btrfsprogs rpm. Was running SLES11 SP2 with btrfsprogs-0.19-5.31.1.x86_6