Re: [PATCH 0/3] Btrfs: fix free space tree bitmaps+tests on big-endian systems

2016-09-21 Thread Omar Sandoval
On Wed, Sep 21, 2016 at 04:50:12PM +0200, David Sterba wrote: > On Thu, Aug 18, 2016 at 01:33:27PM -0700, Omar Sandoval wrote: > > > Omar, looks like we need to make the patched kernel refuse to mount free > > > space trees without a new incompat bit set. That way there won't be any > > > surprise

Re: [PATCH 0/3] Btrfs: fix free space tree bitmaps+tests on big-endian systems

2016-09-21 Thread David Sterba
On Thu, Aug 18, 2016 at 01:33:27PM -0700, Omar Sandoval wrote: > > Omar, looks like we need to make the patched kernel refuse to mount free > > space trees without a new incompat bit set. That way there won't be any > > surprises for the people that have managed to get a free space tree saved. > >

Re: [PATCH 0/3] Btrfs: fix free space tree bitmaps+tests on big-endian systems

2016-08-27 Thread Anatoly Pugachev
On Sat, Aug 27, 2016 at 3:56 AM, Omar Sandoval wrote: > On Fri, Aug 26, 2016 at 02:06:29PM +0300, Anatoly Pugachev wrote: >> >> I can't load btrfs module with this patch applied to 4.8.0-rc3+ (git >> v4.8-rc3-39-g61c0457) >> on "modprobe btrfs" i'm getting the following in the logs and module >> d

Re: [PATCH 0/3] Btrfs: fix free space tree bitmaps+tests on big-endian systems

2016-08-26 Thread Omar Sandoval
On Fri, Aug 26, 2016 at 02:06:29PM +0300, Anatoly Pugachev wrote: > On Thu, Aug 18, 2016 at 11:33 PM, Omar Sandoval wrote: > > On Tue, Jul 19, 2016 at 03:25:16PM -0400, Chris Mason wrote: > >> On 07/19/2016 12:06 PM, Chandan Rajendra wrote: > >> > >> Omar, looks like we need to make the patched ke

Re: [PATCH 0/3] Btrfs: fix free space tree bitmaps+tests on big-endian systems

2016-08-26 Thread Anatoly Pugachev
On Thu, Aug 18, 2016 at 11:33 PM, Omar Sandoval wrote: > On Tue, Jul 19, 2016 at 03:25:16PM -0400, Chris Mason wrote: >> On 07/19/2016 12:06 PM, Chandan Rajendra wrote: >> >> Omar, looks like we need to make the patched kernel refuse to mount free >> space trees without a new incompat bit set. Th

Re: [PATCH 0/3] Btrfs: fix free space tree bitmaps+tests on big-endian systems

2016-08-19 Thread Omar Sandoval
On Tue, Jul 19, 2016 at 03:25:16PM -0400, Chris Mason wrote: > On 07/19/2016 12:06 PM, Chandan Rajendra wrote: > > On Monday, July 18, 2016 03:31:04 PM Omar Sandoval wrote: > > > Yeah, this should definitely not work. It's possible that things are > > > just silently failing and getting corrupted i

Re: [PATCH 0/3] Btrfs: fix free space tree bitmaps+tests on big-endian systems

2016-07-31 Thread Anatoly Pugachev
On Fri, Jul 15, 2016 at 2:31 AM, Omar Sandoval wrote: > From: Omar Sandoval > > So it turns out that the free space tree bitmap handling has always been > broken on big-endian systems. Totally my bad. > > Patch 1 fixes this. Technically, it's a disk format change for > big-endian systems, but it

Re: [PATCH 0/3] Btrfs: fix free space tree bitmaps+tests on big-endian systems

2016-07-19 Thread Chris Mason
On 07/19/2016 12:06 PM, Chandan Rajendra wrote: On Monday, July 18, 2016 03:31:04 PM Omar Sandoval wrote: Yeah, this should definitely not work. It's possible that things are just silently failing and getting corrupted if the module isn't built with CONFIG_BTRFS_ASSERT, but btrfsck v4.6.1 + my p

Re: [PATCH 0/3] Btrfs: fix free space tree bitmaps+tests on big-endian systems

2016-07-19 Thread Chandan Rajendra
On Monday, July 18, 2016 03:31:04 PM Omar Sandoval wrote: > On Mon, Jul 18, 2016 at 02:43:26PM -0400, Chris Mason wrote: > > > > > > On 07/17/2016 08:19 AM, Chandan Rajendra wrote: > > > On Friday, July 15, 2016 12:15:15 PM Omar Sandoval wrote: > > > > On Fri, Jul 15, 2016 at 12:34:10PM +0530, Ch

Re: [PATCH 0/3] Btrfs: fix free space tree bitmaps+tests on big-endian systems

2016-07-18 Thread Omar Sandoval
On Mon, Jul 18, 2016 at 02:43:26PM -0400, Chris Mason wrote: > > > On 07/17/2016 08:19 AM, Chandan Rajendra wrote: > > On Friday, July 15, 2016 12:15:15 PM Omar Sandoval wrote: > > > On Fri, Jul 15, 2016 at 12:34:10PM +0530, Chandan Rajendra wrote: > > > > On Thursday, July 14, 2016 07:47:04 PM C

Re: [PATCH 0/3] Btrfs: fix free space tree bitmaps+tests on big-endian systems

2016-07-18 Thread Chris Mason
On 07/17/2016 08:19 AM, Chandan Rajendra wrote: On Friday, July 15, 2016 12:15:15 PM Omar Sandoval wrote: On Fri, Jul 15, 2016 at 12:34:10PM +0530, Chandan Rajendra wrote: On Thursday, July 14, 2016 07:47:04 PM Chris Mason wrote: On 07/14/2016 07:31 PM, Omar Sandoval wrote: From: Omar Sando

Re: [PATCH 0/3] Btrfs: fix free space tree bitmaps+tests on big-endian systems

2016-07-17 Thread Chandan Rajendra
On Friday, July 15, 2016 12:15:15 PM Omar Sandoval wrote: > On Fri, Jul 15, 2016 at 12:34:10PM +0530, Chandan Rajendra wrote: > > On Thursday, July 14, 2016 07:47:04 PM Chris Mason wrote: > > > On 07/14/2016 07:31 PM, Omar Sandoval wrote: > > > > From: Omar Sandoval > > > > > > > > So it turns out

Re: [PATCH 0/3] Btrfs: fix free space tree bitmaps+tests on big-endian systems

2016-07-15 Thread Omar Sandoval
On Fri, Jul 15, 2016 at 12:34:10PM +0530, Chandan Rajendra wrote: > On Thursday, July 14, 2016 07:47:04 PM Chris Mason wrote: > > On 07/14/2016 07:31 PM, Omar Sandoval wrote: > > > From: Omar Sandoval > > > > > > So it turns out that the free space tree bitmap handling has always been > > > broken

Re: [PATCH 0/3] Btrfs: fix free space tree bitmaps+tests on big-endian systems

2016-07-15 Thread Chandan Rajendra
On Thursday, July 14, 2016 07:47:04 PM Chris Mason wrote: > On 07/14/2016 07:31 PM, Omar Sandoval wrote: > > From: Omar Sandoval > > > > So it turns out that the free space tree bitmap handling has always been > > broken on big-endian systems. Totally my bad. > > > > Patch 1 fixes this. Technicall

Re: [PATCH 0/3] Btrfs: fix free space tree bitmaps+tests on big-endian systems

2016-07-14 Thread Chris Mason
On 07/14/2016 07:31 PM, Omar Sandoval wrote: From: Omar Sandoval So it turns out that the free space tree bitmap handling has always been broken on big-endian systems. Totally my bad. Patch 1 fixes this. Technically, it's a disk format change for big-endian systems, but it never could have wor