Re: [PATCH 06/17] Btrfs: introduce grab/put functions for the root of the fs/file tree

2013-05-16 Thread Liu Bo
On Thu, May 16, 2013 at 01:34:11PM +0800, Miao Xie wrote: On Thu, 16 May 2013 13:15:57 +0800, Liu Bo wrote: On Thu, May 16, 2013 at 12:31:11PM +0800, Miao Xie wrote: On thu, 16 May 2013 11:36:46 +0800, Liu Bo wrote: On Wed, May 15, 2013 at 03:48:20PM +0800, Miao Xie wrote: The grab/put

Re: [PATCH 06/17] Btrfs: introduce grab/put functions for the root of the fs/file tree

2013-05-16 Thread Miao Xie
On thu, 16 May 2013 14:15:52 +0800, Liu Bo wrote: On Thu, May 16, 2013 at 01:34:11PM +0800, Miao Xie wrote: On Thu, 16 May 2013 13:15:57 +0800, Liu Bo wrote: On Thu, May 16, 2013 at 12:31:11PM +0800, Miao Xie wrote: On thu, 16 May 2013 11:36:46 +0800, Liu Bo wrote: On Wed, May 15, 2013 at

Re: [PATCH 06/17] Btrfs: introduce grab/put functions for the root of the fs/file tree

2013-05-16 Thread Chris Mason
Quoting Miao Xie (2013-05-16 03:22:37) I must say that the patch itself looks harmless, the reason is not good enough. I don't agree with you. It is perishing that The memory reclaim task is blocked for a long time. We should avoid this problem. synchronize_rcu and friends can take a

Re: [PATCH 06/17] Btrfs: introduce grab/put functions for the root of the fs/file tree

2013-05-16 Thread Liu Bo
On Thu, May 16, 2013 at 03:22:37PM +0800, Miao Xie wrote: On thu, 16 May 2013 14:15:52 +0800, Liu Bo wrote: On Thu, May 16, 2013 at 01:34:11PM +0800, Miao Xie wrote: On Thu, 16 May 2013 13:15:57 +0800, Liu Bo wrote: On Thu, May 16, 2013 at 12:31:11PM +0800, Miao Xie wrote: On thu, 16 May

Re: [PATCH 06/17] Btrfs: introduce grab/put functions for the root of the fs/file tree

2013-05-16 Thread Chris Mason
Quoting Liu Bo (2013-05-16 10:31:39) On Thu, May 16, 2013 at 07:54:17AM -0400, Chris Mason wrote: Quoting Miao Xie (2013-05-16 03:22:37) I must say that the patch itself looks harmless, the reason is not good enough. I don't agree with you. It is perishing that The memory

Re: [PATCH 06/17] Btrfs: introduce grab/put functions for the root of the fs/file tree

2013-05-16 Thread Liu Bo
On Thu, May 16, 2013 at 10:34:55AM -0400, Chris Mason wrote: Quoting Liu Bo (2013-05-16 10:31:39) On Thu, May 16, 2013 at 07:54:17AM -0400, Chris Mason wrote: Quoting Miao Xie (2013-05-16 03:22:37) I must say that the patch itself looks harmless, the reason is not good enough.

Re: [PATCH 06/17] Btrfs: introduce grab/put functions for the root of the fs/file tree

2013-05-16 Thread Miao Xie
On thu, 16 May 2013 22:57:07 +0800, Liu Bo wrote: On Thu, May 16, 2013 at 10:34:55AM -0400, Chris Mason wrote: Quoting Liu Bo (2013-05-16 10:31:39) On Thu, May 16, 2013 at 07:54:17AM -0400, Chris Mason wrote: Quoting Miao Xie (2013-05-16 03:22:37) I must say that the patch itself looks

Re: [PATCH 06/17] Btrfs: introduce grab/put functions for the root of the fs/file tree

2013-05-15 Thread Liu Bo
On Wed, May 15, 2013 at 03:48:20PM +0800, Miao Xie wrote: The grab/put funtions will be used in the next patch, which need grab the root object and ensure it is not freed. We use reference counter instead of the srcu lock is to aovid blocking the memory reclaim task, which invokes

Re: [PATCH 06/17] Btrfs: introduce grab/put functions for the root of the fs/file tree

2013-05-15 Thread Miao Xie
On thu, 16 May 2013 11:36:46 +0800, Liu Bo wrote: On Wed, May 15, 2013 at 03:48:20PM +0800, Miao Xie wrote: The grab/put funtions will be used in the next patch, which need grab the root object and ensure it is not freed. We use reference counter instead of the srcu lock is to aovid blocking

Re: [PATCH 06/17] Btrfs: introduce grab/put functions for the root of the fs/file tree

2013-05-15 Thread Liu Bo
On Thu, May 16, 2013 at 12:31:11PM +0800, Miao Xie wrote: On thu, 16 May 2013 11:36:46 +0800, Liu Bo wrote: On Wed, May 15, 2013 at 03:48:20PM +0800, Miao Xie wrote: The grab/put funtions will be used in the next patch, which need grab the root object and ensure it is not freed. We use

Re: [PATCH 06/17] Btrfs: introduce grab/put functions for the root of the fs/file tree

2013-05-15 Thread Miao Xie
On Thu, 16 May 2013 13:15:57 +0800, Liu Bo wrote: On Thu, May 16, 2013 at 12:31:11PM +0800, Miao Xie wrote: On thu, 16 May 2013 11:36:46 +0800, Liu Bo wrote: On Wed, May 15, 2013 at 03:48:20PM +0800, Miao Xie wrote: The grab/put funtions will be used in the next patch, which need grab the