Re: [PATCH 1/4] Btrfs-progs: fsck: only allow partial opening under repair mode

2014-06-02 Thread David Sterba
On Wed, May 28, 2014 at 07:20:38PM +0800, Wang Shilong wrote: > --- a/cmds-check.c > +++ b/cmds-check.c > @@ -6810,8 +6810,7 @@ int cmd_check(int argc, char **argv) > int option_index = 0; > int init_csum_tree = 0; > int qgroup_report = 0; > - enum btrfs_open_ctree_flags ctree

Re: [PATCH 1/4] Btrfs-progs: fsck: only allow partial opening under repair mode

2014-05-28 Thread Eric Sandeen
On 5/28/14, 9:10 AM, Shilong Wang wrote: > 2014-05-28 21:56 GMT+08:00 Eric Sandeen : >> The subject and the comment say what this change does, but >> that's obvious from reading the code. Nothing says *why* >> the change has been made. What does this fix, and how does >> it fix it? > > Yup, the

Re: [PATCH 1/4] Btrfs-progs: fsck: only allow partial opening under repair mode

2014-05-28 Thread Shilong Wang
2014-05-28 21:56 GMT+08:00 Eric Sandeen : > The subject and the comment say what this change does, but > that's obvious from reading the code. Nothing says *why* > the change has been made. What does this fix, and how does > it fix it? Yup, the reason that we allow partial opening is that someti

Re: [PATCH 1/4] Btrfs-progs: fsck: only allow partial opening under repair mode

2014-05-28 Thread Eric Sandeen
The subject and the comment say what this change does, but that's obvious from reading the code. Nothing says *why* the change has been made. What does this fix, and how does it fix it? Can you add/update the commit log so that some reader in the future (or for that matter, a reviewer in the pre