Re: [PATCH 14/17] btrfs-progs: fix mem leak in resolve_root

2013-02-27 Thread Shilong Wang
Hello, Eric, David 2013/2/27 David Sterba : > On Mon, Feb 25, 2013 at 10:36:41PM -0600, Eric Sandeen wrote: >> On 2/25/13 6:36 PM, Shilong Wang wrote: >> >> --- a/btrfs-list.c >> >> +++ b/btrfs-list.c >> >> @@ -568,8 +568,10 @@ static int resolve_root(struct root_lookup *rl, >> >> struct root_inf

Re: [PATCH 14/17] btrfs-progs: fix mem leak in resolve_root

2013-02-27 Thread David Sterba
On Mon, Feb 25, 2013 at 10:36:41PM -0600, Eric Sandeen wrote: > On 2/25/13 6:36 PM, Shilong Wang wrote: > >> --- a/btrfs-list.c > >> +++ b/btrfs-list.c > >> @@ -568,8 +568,10 @@ static int resolve_root(struct root_lookup *rl, > >> struct root_info *ri, > >> * ref_tree = 0 indicates

Re: [PATCH 14/17] btrfs-progs: fix mem leak in resolve_root

2013-02-25 Thread Eric Sandeen
On 2/25/13 6:36 PM, Shilong Wang wrote: > Hello, Eric > > 2013/2/26 Eric Sandeen : >> If we exit with error we must free the allocated memory >> to avoid a leak. >> >> Signed-off-by: Eric Sandeen >> --- >> btrfs-list.c |8 ++-- >> 1 files changed, 6 insertions(+), 2 deletions(-) >> >> di

Re: [PATCH 14/17] btrfs-progs: fix mem leak in resolve_root

2013-02-25 Thread Shilong Wang
Hello, Eric 2013/2/26 Eric Sandeen : > If we exit with error we must free the allocated memory > to avoid a leak. > > Signed-off-by: Eric Sandeen > --- > btrfs-list.c |8 ++-- > 1 files changed, 6 insertions(+), 2 deletions(-) > > diff --git a/btrfs-list.c b/btrfs-list.c > index 851c059.