Re: [PATCH 2/2] Btrfs: fix fiemap extent SHARED flag error with range clone.

2018-03-07 Thread Qu Wenruo
On 2018年03月07日 20:17, Nikolay Borisov wrote: > > > On 7.03.2018 14:14, Qu Wenruo wrote: >> >> > > > SHARED flag is determined after extent map merge, so here we can't rely on em here. >>> >>> Shouldn't extent maps correspond to 1:1 disk-state. I.e. they are just >>> the memor

Re: [PATCH 2/2] Btrfs: fix fiemap extent SHARED flag error with range clone.

2018-03-07 Thread Nikolay Borisov
On 7.03.2018 14:14, Qu Wenruo wrote: > > >>> >>> SHARED flag is determined after extent map merge, so here we can't rely >>> on em here. >> >> Shouldn't extent maps correspond to 1:1 disk-state. I.e. they are just >> the memory cache of the extent state. So if we merge them, shouldn't we >>

Re: [PATCH 2/2] Btrfs: fix fiemap extent SHARED flag error with range clone.

2018-03-07 Thread Qu Wenruo
On 2018年03月07日 19:27, Nikolay Borisov wrote: > > > On 7.03.2018 13:18, Qu Wenruo wrote: >> >> >> On 2018年03月07日 19:01, robbieko wrote: >>> Qu Wenruo 於 2018-03-07 18:42 寫到: On 2018年03月07日 18:33, Qu Wenruo wrote: > > > On 2018年03月07日 16:20, robbieko wrote: >> From: Robbie Ko

Re: [PATCH 2/2] Btrfs: fix fiemap extent SHARED flag error with range clone.

2018-03-07 Thread Nikolay Borisov
On 7.03.2018 13:18, Qu Wenruo wrote: > > > On 2018年03月07日 19:01, robbieko wrote: >> Qu Wenruo 於 2018-03-07 18:42 寫到: >>> On 2018年03月07日 18:33, Qu Wenruo wrote: On 2018年03月07日 16:20, robbieko wrote: > From: Robbie Ko > > [BUG] > Range clone can cause fiemap to re

Re: [PATCH 2/2] Btrfs: fix fiemap extent SHARED flag error with range clone.

2018-03-07 Thread Qu Wenruo
On 2018年03月07日 19:01, robbieko wrote: > Qu Wenruo 於 2018-03-07 18:42 寫到: >> On 2018年03月07日 18:33, Qu Wenruo wrote: >>> >>> >>> On 2018年03月07日 16:20, robbieko wrote: From: Robbie Ko [BUG] Range clone can cause fiemap to return error result. Like:  # mount /dev/vdb5 /

Re: [PATCH 2/2] Btrfs: fix fiemap extent SHARED flag error with range clone.

2018-03-07 Thread robbieko
Qu Wenruo 於 2018-03-07 18:42 寫到: On 2018年03月07日 18:33, Qu Wenruo wrote: On 2018年03月07日 16:20, robbieko wrote: From: Robbie Ko [BUG] Range clone can cause fiemap to return error result. Like: # mount /dev/vdb5 /mnt/btrfs # dd if=/dev/zero bs=16K count=2 oflag=dsync of=/mnt/btrfs/file # xf

Re: [PATCH 2/2] Btrfs: fix fiemap extent SHARED flag error with range clone.

2018-03-07 Thread Qu Wenruo
On 2018年03月07日 18:33, Qu Wenruo wrote: > > > On 2018年03月07日 16:20, robbieko wrote: >> From: Robbie Ko >> >> [BUG] >> Range clone can cause fiemap to return error result. >> Like: >> # mount /dev/vdb5 /mnt/btrfs >> # dd if=/dev/zero bs=16K count=2 oflag=dsync of=/mnt/btrfs/file >> # xfs_io -

Re: [PATCH 2/2] Btrfs: fix fiemap extent SHARED flag error with range clone.

2018-03-07 Thread Qu Wenruo
On 2018年03月07日 16:20, robbieko wrote: > From: Robbie Ko > > [BUG] > Range clone can cause fiemap to return error result. > Like: > # mount /dev/vdb5 /mnt/btrfs > # dd if=/dev/zero bs=16K count=2 oflag=dsync of=/mnt/btrfs/file > # xfs_io -c "fiemap -v" /mnt/btrfs/file > /mnt/btrfs/file: > E