Re: [PATCH 2/3] btrfs: move ref finding machinery out of build_backref_tree()

2019-09-26 Thread Josef Bacik
On Tue, Sep 24, 2019 at 04:49:20PM +0200, David Sterba wrote: > On Wed, Sep 11, 2019 at 12:09:29PM -0400, Josef Bacik wrote: > > On Fri, Sep 06, 2019 at 10:15:32AM -0700, Mark Fasheh wrote: > > > From: Mark Fasheh > > > > > > build_backref_tree() is walking extent refs in what is an otherwise sel

Re: [PATCH 2/3] btrfs: move ref finding machinery out of build_backref_tree()

2019-09-24 Thread David Sterba
On Wed, Sep 11, 2019 at 12:09:29PM -0400, Josef Bacik wrote: > On Fri, Sep 06, 2019 at 10:15:32AM -0700, Mark Fasheh wrote: > > From: Mark Fasheh > > > > build_backref_tree() is walking extent refs in what is an otherwise self > > contained chunk of code. We can shrink the total number of lines

Re: [PATCH 2/3] btrfs: move ref finding machinery out of build_backref_tree()

2019-09-11 Thread Josef Bacik
On Fri, Sep 06, 2019 at 10:15:32AM -0700, Mark Fasheh wrote: > From: Mark Fasheh > > build_backref_tree() is walking extent refs in what is an otherwise self > contained chunk of code. We can shrink the total number of lines in > build_backref_tree() *and* make it more readable by moving that wa