Re: [PATCH 2/6] Btrfs-progs: add btrfsck functionality to btrfs

2013-11-14 Thread Ian Kumlien
On Thu, Nov 14, 2013 at 01:49:21PM +0100, David Sterba wrote: > On Thu, Nov 14, 2013 at 11:25:55AM +0200, Ilya Dryomov wrote: > > On Wed, Nov 13, 2013 at 7:13 PM, David Sterba wrote: > > >> For this to have any effect, 'h' must be added to getopt_long(), see > > >> attached patch 1. > > >> > > >>

Re: [PATCH 2/6] Btrfs-progs: add btrfsck functionality to btrfs

2013-11-14 Thread David Sterba
On Thu, Nov 14, 2013 at 11:25:55AM +0200, Ilya Dryomov wrote: > On Wed, Nov 13, 2013 at 7:13 PM, David Sterba wrote: > >> For this to have any effect, 'h' must be added to getopt_long(), see > >> attached patch 1. > >> > >> However, this results in btrfsck -h and --help doing different things: > >

Re: [PATCH 2/6] Btrfs-progs: add btrfsck functionality to btrfs

2013-11-14 Thread Ilya Dryomov
On Wed, Nov 13, 2013 at 7:13 PM, David Sterba wrote: > Hi, > > On Sun, Jun 02, 2013 at 05:47:38PM +0200, Dieter Ries wrote: >> For this to have any effect, 'h' must be added to getopt_long(), see >> attached patch 1. >> >> However, this results in btrfsck -h and --help doing different things: >> >

Re: [PATCH 2/6] Btrfs-progs: add btrfsck functionality to btrfs

2013-11-13 Thread David Sterba
Hi, On Sun, Jun 02, 2013 at 05:47:38PM +0200, Dieter Ries wrote: > For this to have any effect, 'h' must be added to getopt_long(), see > attached patch 1. > > However, this results in btrfsck -h and --help doing different things: > > --help prints the usage message to stdout and exits with exit

Re: [PATCH 2/6] Btrfs-progs: add btrfsck functionality to btrfs

2013-06-02 Thread Dieter Ries
Hi everybody, Am 08.02.2013 01:36, schrieb Ian Kumlien: > diff --git a/cmds-check.c b/cmds-check.c > index 71e98de..8e4cce0 100644 > --- a/cmds-check.c > +++ b/cmds-check.c [...] > @@ -3574,7 +3579,8 @@ int main(int ac, char **av) > (unsigned long long)bytenr

Re: [PATCH 2/6] Btrfs-progs: add btrfsck functionality to btrfs

2013-02-12 Thread Goffredo Baroncelli
On 02/12/2013 11:52 PM, David Sterba wrote: > On Tue, Feb 12, 2013 at 07:01:33PM +0100, Goffredo Baroncelli wrote: >> On 02/12/2013 06:37 PM, Filipe Brandenburger wrote: >>> Hi, >>> >>> On Tue, Feb 12, 2013 at 8:39 AM, David Sterba wrote: +# For backward compatibility, 'btrfs' changes behavio

Re: [PATCH 2/6] Btrfs-progs: add btrfsck functionality to btrfs

2013-02-12 Thread David Sterba
On Tue, Feb 12, 2013 at 07:01:33PM +0100, Goffredo Baroncelli wrote: > On 02/12/2013 06:37 PM, Filipe Brandenburger wrote: > > Hi, > > > > On Tue, Feb 12, 2013 at 8:39 AM, David Sterba wrote: > >> +# For backward compatibility, 'btrfs' changes behaviour to fsck if it's > >> named 'btrfsck' > >>

Re: [PATCH 2/6] Btrfs-progs: add btrfsck functionality to btrfs

2013-02-12 Thread Goffredo Baroncelli
On 02/12/2013 06:37 PM, Filipe Brandenburger wrote: > Hi, > > On Tue, Feb 12, 2013 at 8:39 AM, David Sterba wrote: >> +# For backward compatibility, 'btrfs' changes behaviour to fsck if it's >> named 'btrfsck' >> +btrfsck: btrfs >> + @echo "[CP] $@" >> + $(Q)cp btrfs btrfsck

Re: [PATCH 2/6] Btrfs-progs: add btrfsck functionality to btrfs

2013-02-12 Thread Filipe Brandenburger
Hi, On Tue, Feb 12, 2013 at 8:39 AM, David Sterba wrote: > +# For backward compatibility, 'btrfs' changes behaviour to fsck if it's > named 'btrfsck' > +btrfsck: btrfs > + @echo "[CP] $@" > + $(Q)cp btrfs btrfsck > + I think the idea was that btrfsck becomes a link (either s

Re: [PATCH 2/6] Btrfs-progs: add btrfsck functionality to btrfs

2013-02-12 Thread David Sterba
On Fri, Feb 08, 2013 at 01:36:58AM +0100, Ian Kumlien wrote: > -btrfsck: $(objects) btrfsck.o > - @echo "[LD] $@" > - $(Q)$(CC) $(CFLAGS) -o btrfsck btrfsck.o $(objects) $(LDFLAGS) $(LIBS) > - Do we want to get rid of the btrfsck binary completely? Using the term 'btrsfck' is commo

Re: [PATCH 2/6] Btrfs-progs: add btrfsck functionality to btrfs

2013-02-08 Thread Ian Kumlien
On Sat, Feb 09, 2013 at 12:07:50AM +0100, David Sterba wrote: > On Fri, Feb 08, 2013 at 07:17:13PM +0100, Ian Kumlien wrote: > > On Fri, Feb 08, 2013 at 06:39:18PM +0100, Goffredo Baroncelli wrote: > > > H Iam, > > > > > > On 02/08/2013 01:36 AM, Ian Kumlien wrote: > > > > This patch includes the

Re: [PATCH 2/6] Btrfs-progs: add btrfsck functionality to btrfs

2013-02-08 Thread David Sterba
On Fri, Feb 08, 2013 at 07:17:13PM +0100, Ian Kumlien wrote: > On Fri, Feb 08, 2013 at 06:39:18PM +0100, Goffredo Baroncelli wrote: > > H Iam, > > > > On 02/08/2013 01:36 AM, Ian Kumlien wrote: > > > This patch includes the functionality of btrfs, it's > > > found as "btrfs check" however it makes

Re: [PATCH 2/6] Btrfs-progs: add btrfsck functionality to btrfs

2013-02-08 Thread Ian Kumlien
On Fri, Feb 08, 2013 at 06:39:18PM +0100, Goffredo Baroncelli wrote: > H Iam, > > On 02/08/2013 01:36 AM, Ian Kumlien wrote: > > This patch includes the functionality of btrfs, it's > > found as "btrfs check" however it makes the binary > > behave differently depending on what it's run as. > [...]

Re: [PATCH 2/6] Btrfs-progs: add btrfsck functionality to btrfs

2013-02-08 Thread Goffredo Baroncelli
H Iam, On 02/08/2013 01:36 AM, Ian Kumlien wrote: > This patch includes the functionality of btrfs, it's > found as "btrfs check" however it makes the binary > behave differently depending on what it's run as. [...] > > +static int cmd_dummy(int argc, char **argv) > +{ > + return 0; I thin