Re: [PATCH 2/7] btrfs: extend critical section when scanning a new device

2018-07-13 Thread David Sterba
On Wed, Jul 04, 2018 at 04:18:09PM +0800, Anand Jain wrote: > > > On 06/21/2018 01:51 AM, David Sterba wrote: > > The stale device list removal needs to be protected by device_list_mutex > > too as this could delete from the list and could race with another list > > modification and cause crash.

Re: [PATCH 2/7] btrfs: extend critical section when scanning a new device

2018-07-04 Thread Anand Jain
On 06/21/2018 01:51 AM, David Sterba wrote: The stale device list removal needs to be protected by device_list_mutex too as this could delete from the list and could race with another list modification and cause crash. The device needs to be fully initialized before it's added to the list so

Re: [PATCH 2/7] btrfs: extend critical section when scanning a new device

2018-06-26 Thread Anand Jain
On 06/21/2018 01:51 AM, David Sterba wrote: The stale device list removal needs to be protected by device_list_mutex too as this could delete from the list and could race with another list modification and cause crash. Its is very less likely or almost practically impossible (unless instru