Re: [PATCH 5/7] btrfs: check/lowmem: Check and repair free space cache inode mode

2019-03-29 Thread Nikolay Borisov
On 29.03.19 г. 13:02 ч., Qu Wenruo wrote: > [snip] >>> +/* >>> + * For free space inodes, we can't call check_inode_item() as free space >>> + * cache inode doesn't have INODE_REF. >>> + * We just check its inode mode. >>> + */ >>> +int check_repair_free_space_inode(struct btrfs_fs_info *fs_info

Re: [PATCH 5/7] btrfs: check/lowmem: Check and repair free space cache inode mode

2019-03-29 Thread Qu Wenruo
[snip] >> +/* >> + * For free space inodes, we can't call check_inode_item() as free space >> + * cache inode doesn't have INODE_REF. >> + * We just check its inode mode. >> + */ >> +int check_repair_free_space_inode(struct btrfs_fs_info *fs_info, >> + struct btrfs_path

Re: [PATCH 5/7] btrfs: check/lowmem: Check and repair free space cache inode mode

2019-03-29 Thread Nikolay Borisov
On 25.03.19 г. 10:22 ч., Qu Wenruo wrote: > Unlike inodes in fs roots, we don't really check the inode items in root > tree, in fact we just skip everything other than ROOT_ITEM and ROOT_REF. > > This makes invalid inode items sneak into root tree. > For example: > item 9 key (256 INODE

Re: [PATCH 5/7] btrfs: check/lowmem: Check and repair free space cache inode mode

2019-03-25 Thread Qu Wenruo
On 2019/3/25 下午10:36, Su Yue wrote: > > > On 2019/3/25 4:22 PM, Qu Wenruo wrote: >> Unlike inodes in fs roots, we don't really check the inode items in root >> tree, in fact we just skip everything other than ROOT_ITEM and ROOT_REF. >> >> This makes invalid inode items sneak into root tree. >>

Re: [PATCH 5/7] btrfs: check/lowmem: Check and repair free space cache inode mode

2019-03-25 Thread Su Yue
On 2019/3/25 4:22 PM, Qu Wenruo wrote: Unlike inodes in fs roots, we don't really check the inode items in root tree, in fact we just skip everything other than ROOT_ITEM and ROOT_REF. This makes invalid inode items sneak into root tree. For example: item 9 key (256 INODE_ITEM 0) ite