Re: [PATCH v2] Btrfs: fix error handling in btrfs_truncate()

2018-05-24 Thread David Sterba
On Tue, May 22, 2018 at 10:48:38AM -0700, Omar Sandoval wrote: > On Tue, May 22, 2018 at 10:41:11AM -0700, Omar Sandoval wrote: > > On Tue, May 22, 2018 at 10:37:14AM -0700, Omar Sandoval wrote: > > > On Tue, May 22, 2018 at 07:17:48PM +0200, David Sterba wrote: > > > > On Tue, May 22, 2018 at 09:4

Re: [PATCH v2] Btrfs: fix error handling in btrfs_truncate()

2018-05-22 Thread Omar Sandoval
On Tue, May 22, 2018 at 10:41:11AM -0700, Omar Sandoval wrote: > On Tue, May 22, 2018 at 10:37:14AM -0700, Omar Sandoval wrote: > > On Tue, May 22, 2018 at 07:17:48PM +0200, David Sterba wrote: > > > On Tue, May 22, 2018 at 09:47:58AM -0700, Omar Sandoval wrote: > > > > From: Omar Sandoval > > > >

Re: [PATCH v2] Btrfs: fix error handling in btrfs_truncate()

2018-05-22 Thread Omar Sandoval
On Tue, May 22, 2018 at 10:37:14AM -0700, Omar Sandoval wrote: > On Tue, May 22, 2018 at 07:17:48PM +0200, David Sterba wrote: > > On Tue, May 22, 2018 at 09:47:58AM -0700, Omar Sandoval wrote: > > > From: Omar Sandoval > > > > > > Jun Wu at Facebook reported that an internal service was seeing a

Re: [PATCH v2] Btrfs: fix error handling in btrfs_truncate()

2018-05-22 Thread Omar Sandoval
On Tue, May 22, 2018 at 07:17:48PM +0200, David Sterba wrote: > On Tue, May 22, 2018 at 09:47:58AM -0700, Omar Sandoval wrote: > > From: Omar Sandoval > > > > Jun Wu at Facebook reported that an internal service was seeing a return > > value of 1 from ftruncate() on Btrfs in some cases. > > Do y

Re: [PATCH v2] Btrfs: fix error handling in btrfs_truncate()

2018-05-22 Thread David Sterba
On Tue, May 22, 2018 at 09:47:58AM -0700, Omar Sandoval wrote: > From: Omar Sandoval > > Jun Wu at Facebook reported that an internal service was seeing a return > value of 1 from ftruncate() on Btrfs in some cases. Do you have a reproducer? To estimate how likely is to hit the problem in practi