Re: [PATCH v2] Btrfs: fix unexpected balance crash due to BUG_ON

2016-07-12 Thread David Sterba
On Mon, Jul 11, 2016 at 10:21:35AM -0700, Liu Bo wrote: > + } > > trans = btrfs_start_transaction(dev_root, 0); > - BUG_ON(IS_ERR(trans)); > + if (IS_ERR(trans)) { > + ret = PTR_ERR(trans); > + btrfs_info(fs

Re: [PATCH v2] Btrfs: fix unexpected balance crash due to BUG_ON

2016-07-12 Thread Filipe Manana
On Mon, Jul 11, 2016 at 6:21 PM, Liu Bo wrote: > Mounting a btrfs can resume previous balance operations asynchronously. > An user got a crash when one drive has some corrupt sectors. > > Since balance can cancel itself in case of any error, we can gracefully > return errors to upper layers and le

Re: [PATCH v2] Btrfs: fix unexpected balance crash due to BUG_ON

2016-07-11 Thread Chris Mason
On 07/11/2016 01:21 PM, Liu Bo wrote: Mounting a btrfs can resume previous balance operations asynchronously. An user got a crash when one drive has some corrupt sectors. Since balance can cancel itself in case of any error, we can gracefully return errors to upper layers and let balance do th