Re: [PATCH v2] Btrfs: skip set_page_dirty if eb is dirty

2018-09-14 Thread David Sterba
On Fri, Sep 14, 2018 at 01:44:42AM +0800, Liu Bo wrote: > As long as @eb is marked with EXTENT_BUFFER_DIRTY, all of its pages > are dirty, so no need to set pages dirty again. > > Ftrace showed that the loop took 10us on my dev box, so removing this > can save us at least 10us if eb is already dir

Re: [PATCH v2] Btrfs: skip set_page_dirty if eb is dirty

2018-09-13 Thread Nikolay Borisov
On 13.09.2018 20:44, Liu Bo wrote: > As long as @eb is marked with EXTENT_BUFFER_DIRTY, all of its pages > are dirty, so no need to set pages dirty again. > > Ftrace showed that the loop took 10us on my dev box, so removing this > can save us at least 10us if eb is already dirty. > > Signed-of