Re: [PATCH v3] btrfs-progs: add verbose option to btrfs device scan

2019-10-21 Thread Anand Jain
On 10/21/19 9:43 PM, David Sterba wrote: On Tue, Oct 15, 2019 at 11:29:34AM +0800, Anand Jain wrote: I was thinking there might be some common code between the sub-commands in btrfs-progs now or in future, and if the printf() due to verbose is required in one sub-command and the same

Re: [PATCH v3] btrfs-progs: add verbose option to btrfs device scan

2019-10-21 Thread David Sterba
On Tue, Oct 15, 2019 at 11:29:34AM +0800, Anand Jain wrote: > I was thinking there might be some common code between the > sub-commands in btrfs-progs now or in future, and if the printf() > due to verbose is required in one sub-command and the same printf() > due to verbose is not required

Re: [PATCH v3] btrfs-progs: add verbose option to btrfs device scan

2019-10-14 Thread Anand Jain
On 10/14/19 11:24 PM, David Sterba wrote: On Tue, Oct 08, 2019 at 10:53:37AM +0800, Anand Jain wrote: On 10/8/19 1:41 AM, David Sterba wrote: On Wed, Oct 02, 2019 at 12:11:52PM +0800, Anand Jain wrote: To help debug device scan issues, add verbose option to btrfs device scan. The common opti

Re: [PATCH v3] btrfs-progs: add verbose option to btrfs device scan

2019-10-14 Thread David Sterba
On Tue, Oct 08, 2019 at 10:53:37AM +0800, Anand Jain wrote: > On 10/8/19 1:41 AM, David Sterba wrote: > > On Wed, Oct 02, 2019 at 12:11:52PM +0800, Anand Jain wrote: > >> To help debug device scan issues, add verbose option to btrfs device scan. > > > > The common options like --verbose are going

Re: [PATCH v3] btrfs-progs: add verbose option to btrfs device scan

2019-10-07 Thread Anand Jain
On 10/8/19 1:41 AM, David Sterba wrote: On Wed, Oct 02, 2019 at 12:11:52PM +0800, Anand Jain wrote: To help debug device scan issues, add verbose option to btrfs device scan. The common options like --verbose are going to be added into the global command so I'd rather avoid adding them to new

Re: [PATCH v3] btrfs-progs: add verbose option to btrfs device scan

2019-10-07 Thread David Sterba
On Wed, Oct 02, 2019 at 12:11:52PM +0800, Anand Jain wrote: > To help debug device scan issues, add verbose option to btrfs device scan. The common options like --verbose are going to be added into the global command so I'd rather avoid adding them to new subcommands as this would become unnecessa