Re: [patch 3/4] mm: filemap: pass __GFP_WRITE from grab_cache_page_write_begin()

2011-09-27 Thread Minchan Kim
On Tue, Sep 20, 2011 at 03:45:14PM +0200, Johannes Weiner wrote: > Tell the page allocator that pages allocated through > grab_cache_page_write_begin() are expected to become dirty soon. > > Signed-off-by: Johannes Weiner Reviewed-by: Minchan Kim -- Kinds regards, Minchan Kim -- To unsubscribe

Re: [patch 3/4] mm: filemap: pass __GFP_WRITE from grab_cache_page_write_begin()

2011-09-21 Thread Mel Gorman
On Tue, Sep 20, 2011 at 03:45:14PM +0200, Johannes Weiner wrote: > Tell the page allocator that pages allocated through > grab_cache_page_write_begin() are expected to become dirty soon. > > Signed-off-by: Johannes Weiner Acked-by: Mel Gorman -- Mel Gorman SUSE Labs -- To unsubscribe from thi

Re: [patch 3/4] mm: filemap: pass __GFP_WRITE from grab_cache_page_write_begin()

2011-09-21 Thread Johannes Weiner
On Tue, Sep 20, 2011 at 02:40:34PM -0400, Christoph Hellwig wrote: > On Tue, Sep 20, 2011 at 02:38:03PM -0400, Rik van Riel wrote: > > On 09/20/2011 10:25 AM, Christoph Hellwig wrote: > > >In addition to regular write shouldn't __do_fault and do_wp_page also > > >calls this if they are called on fi

Re: [patch 3/4] mm: filemap: pass __GFP_WRITE from grab_cache_page_write_begin()

2011-09-20 Thread Rik van Riel
On 09/20/2011 09:45 AM, Johannes Weiner wrote: Tell the page allocator that pages allocated through grab_cache_page_write_begin() are expected to become dirty soon. Signed-off-by: Johannes Weiner Reviewed-by: Rik van Riel The missing codepaths pointed out by Christoph either create new anonym

Re: [patch 3/4] mm: filemap: pass __GFP_WRITE from grab_cache_page_write_begin()

2011-09-20 Thread Christoph Hellwig
On Tue, Sep 20, 2011 at 02:38:03PM -0400, Rik van Riel wrote: > On 09/20/2011 10:25 AM, Christoph Hellwig wrote: > >In addition to regular write shouldn't __do_fault and do_wp_page also > >calls this if they are called on file backed mappings? > > > > Probably not do_wp_page since it always create

Re: [patch 3/4] mm: filemap: pass __GFP_WRITE from grab_cache_page_write_begin()

2011-09-20 Thread Rik van Riel
On 09/20/2011 10:25 AM, Christoph Hellwig wrote: In addition to regular write shouldn't __do_fault and do_wp_page also calls this if they are called on file backed mappings? Probably not do_wp_page since it always creates an anonymous page, which are not very relevant to the dirty page cache a

Re: [patch 3/4] mm: filemap: pass __GFP_WRITE from grab_cache_page_write_begin()

2011-09-20 Thread Christoph Hellwig
In addition to regular write shouldn't __do_fault and do_wp_page also calls this if they are called on file backed mappings? -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.or