Re: State of nocow file attribute

2012-08-21 Thread David Sterba
On Fri, Aug 17, 2012 at 11:30:14PM +0800, Liu Bo wrote: IMO the following is better, just make use of the original check. If you agree with this, I'll send it as a patch :) I think it's cleaner to keep all flags that get inherited from the directory - new file at one place, ie

Re: State of nocow file attribute

2012-08-21 Thread Liu Bo
On 08/21/2012 10:33 PM, David Sterba wrote: On Fri, Aug 17, 2012 at 11:30:14PM +0800, Liu Bo wrote: IMO the following is better, just make use of the original check. If you agree with this, I'll send it as a patch :) I think it's cleaner to keep all flags that get inherited from the

Re: State of nocow file attribute

2012-08-16 Thread Liu Bo
On 08/15/2012 06:12 PM, Lluís Batlle i Rossell wrote: Hello, some time ago we discussed on #btrfs that the nocow attribute for files wasn't working (around 3.3 or 3.4 kernels). That was evident by files fragmenting even with the attribute set. Chris mentioned to find a fix quickly for

State of nocow file attribute

2012-08-15 Thread Lluís Batlle i Rossell
Hello, some time ago we discussed on #btrfs that the nocow attribute for files wasn't working (around 3.3 or 3.4 kernels). That was evident by files fragmenting even with the attribute set. Chris mentioned to find a fix quickly for that, and posted some lines of change into irc. But recently

Re: State of nocow file attribute

2012-08-15 Thread Lluís Batlle i Rossell
On Wed, Aug 15, 2012 at 08:05:11AM -0500, Kyle Gates wrote: Is there really a fix upstream for that? Do nocow attribute on files work for anyone already? IIRC the nocow attribute seems to work if the volume is mounted with nodatasum Shouldn't nocow mean also nodatasum *only for that