Re: btrfs: initial readahead code and prototypes

2012-05-17 Thread Arne Jansen
On 05/17/12 15:46, Dan Carpenter wrote: On Thu, May 17, 2012 at 03:31:50PM +0200, Arne Jansen wrote: The assumption here is that if err == 0, eb is always != NULL. There's even a tiny comment above the function stating this: 107 /* in case of err, eb might be NULL */ Ah,

Re: btrfs: initial readahead code and prototypes

2012-05-17 Thread Dan Carpenter
On Thu, May 17, 2012 at 03:31:50PM +0200, Arne Jansen wrote: > The assumption here is that if err == 0, eb is always != NULL. There's > even a tiny comment above the function stating this: > > 107 /* in case of err, eb might be NULL */ > Ah, right. I missed the comment. > Th

Re: btrfs: initial readahead code and prototypes

2012-05-17 Thread Arne Jansen
On 05/17/12 09:14, Dan Carpenter wrote: Hi, I'm working on some new Smatch code and it complains about this patch from last year. -Dan This is a semi-automatic email about new static checker warnings. The patch 7414a03fbf9e: "btrfs: initial readahead code and prototypes" fr

re: btrfs: initial readahead code and prototypes

2012-05-17 Thread Dan Carpenter
Hi, I'm working on some new Smatch code and it complains about this patch from last year. -Dan This is a semi-automatic email about new static checker warnings. The patch 7414a03fbf9e: "btrfs: initial readahead code and prototypes" from May 23, 2011, leads to the f

[PATCH v5 4/7] btrfs: initial readahead code and prototypes

2011-07-01 Thread Arne Jansen
This is the implementation for the generic read ahead framework. To trigger a readahead, btrfs_reada_add must be called. It will start a read ahead for the given range [start, end) on tree root. The returned handle can either be used to wait on the readahead to finish (btrfs_reada_wait), or to sen

Re: [PATCH v4 4/7] btrfs: initial readahead code and prototypes

2011-06-30 Thread Arne Jansen
On 30.06.2011 14:49, Josef Bacik wrote: > On 06/30/2011 03:37 AM, Arne Jansen wrote: >> On 29.06.2011 23:49, Josef Bacik wrote: >>> On 06/29/2011 04:10 PM, Arne Jansen wrote: > >> >>> +struct krefrefcnt; +wait_queue_head_twait; +}; + +struct reada_extct

Re: [PATCH v4 4/7] btrfs: initial readahead code and prototypes

2011-06-30 Thread Josef Bacik
On 06/30/2011 03:37 AM, Arne Jansen wrote: On 29.06.2011 23:49, Josef Bacik wrote: On 06/29/2011 04:10 PM, Arne Jansen wrote: + struct kref refcnt; + wait_queue_head_t wait; +}; + +struct reada_extctl { + struct list_headlist; + struct rea

Re: [PATCH v4 4/7] btrfs: initial readahead code and prototypes

2011-06-30 Thread Arne Jansen
On 29.06.2011 23:49, Josef Bacik wrote: > On 06/29/2011 04:10 PM, Arne Jansen wrote: >> This is the implementation for the generic read ahead framework. >> >> To trigger a readahead, btrfs_reada_add must be called. It will start >> a read ahead for the given range [start, end) on tree root. The ret

Re: [PATCH v4 4/7] btrfs: initial readahead code and prototypes

2011-06-29 Thread Josef Bacik
On 06/29/2011 04:10 PM, Arne Jansen wrote: > This is the implementation for the generic read ahead framework. > > To trigger a readahead, btrfs_reada_add must be called. It will start > a read ahead for the given range [start, end) on tree root. The returned > handle can either be used to wait on

[PATCH v4 4/7] btrfs: initial readahead code and prototypes

2011-06-29 Thread Arne Jansen
This is the implementation for the generic read ahead framework. To trigger a readahead, btrfs_reada_add must be called. It will start a read ahead for the given range [start, end) on tree root. The returned handle can either be used to wait on the readahead to finish (btrfs_reada_wait), or to sen

[PATCH v3 3/6] btrfs: initial readahead code and prototypes

2011-06-29 Thread Arne Jansen
This is the implementation for the generic read ahead framework. To trigger a readahead, btrfs_reada_add must be called. It will start a read ahead for the given range [start, end) on tree root. The returned handle can either be used to wait on the readahead to finish (btrfs_reada_wait), or to sen

[PATCH v2 4/6] btrfs: initial readahead code and prototypes

2011-06-10 Thread Arne Jansen
This is the implementation for the generic read ahead framework. To trigger a readahead, btrfs_reada_add must be called. It will start a read ahead for the given range [start, end) on tree root. The returned handle can either be used to wait on the readahead to finish (btrfs_reada_wait), or to sen

Re: [PATCH v1 3/5] btrfs: initial readahead code and prototypes

2011-05-26 Thread Arne Jansen
On 26.05.2011 12:47, Miao Xie wrote: > On thu, 26 May 2011 12:14:21 +0200, David Sterba wrote: >> Hi, >> >> On Mon, May 23, 2011 at 02:59:06PM +0200, Arne Jansen wrote: >>> +static struct reada_zone *reada_find_zone(struct btrfs_fs_info *fs_info, >>> + struct btr

Re: [PATCH v1 3/5] btrfs: initial readahead code and prototypes

2011-05-26 Thread Miao Xie
On thu, 26 May 2011 12:14:21 +0200, David Sterba wrote: > Hi, > > On Mon, May 23, 2011 at 02:59:06PM +0200, Arne Jansen wrote: >> +static struct reada_zone *reada_find_zone(struct btrfs_fs_info *fs_info, >> + struct btrfs_device *dev, u64 logical, >> +

Re: [PATCH v1 3/5] btrfs: initial readahead code and prototypes

2011-05-26 Thread David Sterba
Hi, On Mon, May 23, 2011 at 02:59:06PM +0200, Arne Jansen wrote: > +static struct reada_zone *reada_find_zone(struct btrfs_fs_info *fs_info, > + struct btrfs_device *dev, u64 logical, > + struct btrfs_multi_bio *multi) > +

[PATCH v1 3/5] btrfs: initial readahead code and prototypes

2011-05-23 Thread Arne Jansen
This is the implementation for the generic read ahead framework. To trigger a readahead, btrfs_reada_add must be called. It will start a read ahead for the given range [start, end) on tree root. The returned handle can either be used to wait on the readahead to finish (btrfs_reada_wait), or to sen