Re: btrfs crash when low on memory.

2013-03-04 Thread Martin Steigerwald
Am Mittwoch, 27. Februar 2013 schrieb Ahmet Inan: Yeah we have a lot of ptr = kmalloc(); BUG_ON(ptr); everywhere. I'll fix this one up but I really need to sit down and go through all of them and make sure we do the right thing in all these places. Thanks, But what would be

Re: btrfs crash when low on memory.

2013-02-27 Thread Martin Steigerwald
Am Mittwoch, 27. Februar 2013 schrieb Dave Jones: Something I've yet to repeat managed to leak a whole bunch of memory while I was travelling, and locked up my workstation. When I got home, this was the last thing printed out before it locked up (it did make it into the logs thankfully)

Re: btrfs crash when low on memory.

2013-02-27 Thread Josef Bacik
On Tue, Feb 26, 2013 at 10:22:47PM -0700, Dave Jones wrote: Something I've yet to repeat managed to leak a whole bunch of memory while I was travelling, and locked up my workstation. When I got home, this was the last thing printed out before it locked up (it did make it into the logs

Re: btrfs crash when low on memory.

2013-02-27 Thread Ahmet Inan
Yeah we have a lot of ptr = kmalloc(); BUG_ON(ptr); everywhere. I'll fix this one up but I really need to sit down and go through all of them and make sure we do the right thing in all these places. Thanks, But what would be the right thing to do when you got no memory? Spinlock until

Re: btrfs crash when low on memory.

2013-02-27 Thread Josef Bacik
On Wed, Feb 27, 2013 at 07:31:11AM -0700, Ahmet Inan wrote: Yeah we have a lot of ptr = kmalloc(); BUG_ON(ptr); everywhere. I'll fix this one up but I really need to sit down and go through all of them and make sure we do the right thing in all these places. Thanks, But

Re: btrfs crash when low on memory.

2013-02-27 Thread Ahmet Inan
On Wed, Feb 27, 2013 at 7:26 PM, Josef Bacik jba...@fusionio.com wrote: On Wed, Feb 27, 2013 at 07:31:11AM -0700, Ahmet Inan wrote: Yeah we have a lot of ptr = kmalloc(); BUG_ON(ptr); everywhere. I'll fix this one up but I really need to sit down and go through all of them and

Re: btrfs crash when low on memory.

2013-02-27 Thread Josef Bacik
On Wed, Feb 27, 2013 at 3:10 PM, Ahmet Inan ai...@mathematik.uni-freiburg.de wrote: On Wed, Feb 27, 2013 at 7:26 PM, Josef Bacik jba...@fusionio.com wrote: On Wed, Feb 27, 2013 at 07:31:11AM -0700, Ahmet Inan wrote: Yeah we have a lot of ptr = kmalloc(); BUG_ON(ptr); everywhere.

Re: btrfs crash when low on memory.

2013-02-27 Thread Ahmet Inan
If we're corrupting on abort that is a bug too that needs to be fixed too. I've banged on the abort stuff a lot recently when trying to make it not panic the box and it appears to work fine. Obviously that kind of stuff needs to be tested as well, but so far I haven't seen abort corrupt the

btrfs crash when low on memory.

2013-02-26 Thread Dave Jones
Something I've yet to repeat managed to leak a whole bunch of memory while I was travelling, and locked up my workstation. When I got home, this was the last thing printed out before it locked up (it did make it into the logs thankfully) after a bunch of instances of the oom-killers handywork.