Re: price to pay for nocow file bit?

2015-01-15 Thread Chris Mason
On Thu, Jan 8, 2015 at 11:53 AM, Lennart Poettering lenn...@poettering.net wrote: On Thu, 08.01.15 10:56, Zygo Blaxell (ce3g8...@umail.furryterror.org) wrote: On Wed, Jan 07, 2015 at 06:43:15PM +0100, Lennart Poettering wrote: Heya! Currently, systemd-journald's disk access patterns

Re: price to pay for nocow file bit?

2015-01-11 Thread Chris Murphy
On Thu, Jan 8, 2015 at 6:30 AM, Lennart Poettering lenn...@poettering.net wrote: On Wed, 07.01.15 15:10, Josef Bacik (jba...@fb.com) wrote: On 01/07/2015 12:43 PM, Lennart Poettering wrote: Heya! Currently, systemd-journald's disk access patterns (appending to the end of files, then

Re: price to pay for nocow file bit?

2015-01-10 Thread Martin Steigerwald
Am Freitag, 9. Januar 2015, 16:52:59 schrieb David Sterba: On Thu, Jan 08, 2015 at 02:30:36PM +0100, Lennart Poettering wrote: On Wed, 07.01.15 15:10, Josef Bacik (jba...@fb.com) wrote: On 01/07/2015 12:43 PM, Lennart Poettering wrote: Currently, systemd-journald's disk access patterns

Re: price to pay for nocow file bit?

2015-01-10 Thread Martin Steigerwald
Am Samstag, 10. Januar 2015, 13:00:23 schrieben Sie: I have seen this setting before, but I thought, well, logs would be good to keep. But for the SSD based laptop I will try volatile storage now. I will see whether I missed a longer history, but I reduced it before anyway to a 14 day maximum

Re: price to pay for nocow file bit?

2015-01-10 Thread Martin Steigerwald
Am Donnerstag, 8. Januar 2015, 06:30:59 schrieb Duncan: FWIW, I'm systemd on btrfs here, but I use syslog-ng for my non-volatile logs and have Storage=volatile in journald.conf, using journald only for current-session, where unit status including last-10-messages makes troubleshooting /so/

Re: price to pay for nocow file bit?

2015-01-09 Thread David Sterba
On Thu, Jan 08, 2015 at 01:36:21PM -0500, Zygo Blaxell wrote: Hmmm...it seems the handwaving about tail-packing that I was previously ignoring is important after all. A few quick tests with filefrag show that btrfs isn't doing full tail-packing, only small file allocation (i.e. files smaller

Re: price to pay for nocow file bit?

2015-01-09 Thread Zygo Blaxell
On Fri, Jan 09, 2015 at 04:41:03PM +0100, David Sterba wrote: On Thu, Jan 08, 2015 at 01:36:21PM -0500, Zygo Blaxell wrote: Hmmm...it seems the handwaving about tail-packing that I was previously ignoring is important after all. A few quick tests with filefrag show that btrfs isn't doing

Re: price to pay for nocow file bit?

2015-01-09 Thread David Sterba
On Thu, Jan 08, 2015 at 02:30:36PM +0100, Lennart Poettering wrote: On Wed, 07.01.15 15:10, Josef Bacik (jba...@fb.com) wrote: On 01/07/2015 12:43 PM, Lennart Poettering wrote: Currently, systemd-journald's disk access patterns (appending to the end of files, then updating a few pointers in

Re: price to pay for nocow file bit?

2015-01-08 Thread Chris Murphy
On Wed, Jan 7, 2015 at 1:10 PM, Josef Bacik jba...@fb.com wrote: On 01/07/2015 12:43 PM, Lennart Poettering wrote: Heya! Currently, systemd-journald's disk access patterns (appending to the end of files, then updating a few pointers in the front) result in awfully fragmented journal files

Re: price to pay for nocow file bit?

2015-01-08 Thread Koen Kooi
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Chris Murphy schreef op 08-01-15 om 09:24: On Wed, Jan 7, 2015 at 1:10 PM, Josef Bacik jba...@fb.com wrote: On 01/07/2015 12:43 PM, Lennart Poettering wrote: Heya! Currently, systemd-journald's disk access patterns (appending to the end of

Re: price to pay for nocow file bit?

2015-01-08 Thread Lennart Poettering
On Wed, 07.01.15 15:10, Josef Bacik (jba...@fb.com) wrote: On 01/07/2015 12:43 PM, Lennart Poettering wrote: Heya! Currently, systemd-journald's disk access patterns (appending to the end of files, then updating a few pointers in the front) result in awfully fragmented journal files on

Re: price to pay for nocow file bit?

2015-01-08 Thread Konstantinos Skarlatos
On 8/1/2015 3:30 μμ, Lennart Poettering wrote: On Wed, 07.01.15 15:10, Josef Bacik (jba...@fb.com) wrote: On 01/07/2015 12:43 PM, Lennart Poettering wrote: Heya! Currently, systemd-journald's disk access patterns (appending to the end of files, then updating a few pointers in the front)

Re: price to pay for nocow file bit?

2015-01-08 Thread Zygo Blaxell
On Thu, Jan 08, 2015 at 05:53:21PM +0100, Lennart Poettering wrote: On Thu, 08.01.15 10:56, Zygo Blaxell (ce3g8...@umail.furryterror.org) wrote: On Wed, Jan 07, 2015 at 06:43:15PM +0100, Lennart Poettering wrote: Heya! Currently, systemd-journald's disk access patterns (appending to

Re: price to pay for nocow file bit?

2015-01-08 Thread Lennart Poettering
On Thu, 08.01.15 10:56, Zygo Blaxell (ce3g8...@umail.furryterror.org) wrote: On Wed, Jan 07, 2015 at 06:43:15PM +0100, Lennart Poettering wrote: Heya! Currently, systemd-journald's disk access patterns (appending to the end of files, then updating a few pointers in the front) result in

Re: price to pay for nocow file bit?

2015-01-08 Thread Zygo Blaxell
On Wed, Jan 07, 2015 at 06:43:15PM +0100, Lennart Poettering wrote: Heya! Currently, systemd-journald's disk access patterns (appending to the end of files, then updating a few pointers in the front) result in awfully fragmented journal files on btrfs, which has a pretty negative effect on

Re: price to pay for nocow file bit?

2015-01-08 Thread Goffredo Baroncelli
On 2015-01-08 19:24, Konstantinos Skarlatos wrote: Anyway, given the pros and cons I have now changed journald to set the nocow bit on newly created journal files. When files are rotated (and we hence know we will never ever write again to them) the bit is tried to be unset again, and a defrag

Re: price to pay for nocow file bit?

2015-01-08 Thread Roger Binns
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/08/2015 08:53 AM, Lennart Poettering wrote: this will help little if we change things in the beginning of the file, Have you considered changing the format so that those pointers are stored at the end of the file, letting data always be

Re: price to pay for nocow file bit?

2015-01-07 Thread Duncan
Josef Bacik posted on Wed, 07 Jan 2015 15:10:06 -0500 as excerpted: Does this have any effect on functionality? As I understood snapshots still work fine for files marked like that, and so do reflinks. Any drawback functionality-wise? Apparently file compression support is lost if the bit is

Re: price to pay for nocow file bit?

2015-01-07 Thread Goffredo Baroncelli
I am trying to understand the pros and cons of turning this bit on, before I can make this change. So far I see one big pro, but I wonder if there's any major con I should think about? Nope there's no real con other than you don't get csums, but that doesn't really matter for you.

Re: price to pay for nocow file bit?

2015-01-07 Thread Josef Bacik
On 01/07/2015 12:43 PM, Lennart Poettering wrote: Heya! Currently, systemd-journald's disk access patterns (appending to the end of files, then updating a few pointers in the front) result in awfully fragmented journal files on btrfs, which has a pretty negative effect on performance when

Re: price to pay for nocow file bit?

2015-01-07 Thread Josef Bacik
On 01/07/2015 04:05 PM, Goffredo Baroncelli wrote: I am trying to understand the pros and cons of turning this bit on, before I can make this change. So far I see one big pro, but I wonder if there's any major con I should think about? Nope there's no real con other than you don't get

price to pay for nocow file bit?

2015-01-07 Thread Lennart Poettering
Heya! Currently, systemd-journald's disk access patterns (appending to the end of files, then updating a few pointers in the front) result in awfully fragmented journal files on btrfs, which has a pretty negative effect on performance when accessing them. Now, to improve things a bit, I