Re: question about transaction-abort-related commits

2013-07-02 Thread Alex Lyakas
On Sun, Jun 30, 2013 at 2:36 PM, Josef Bacik wrote: > On Sun, Jun 30, 2013 at 11:29:14AM +0300, Alex Lyakas wrote: >> Hi Josef, >> >> On Wed, Jun 26, 2013 at 5:16 PM, Alex Lyakas >> wrote: >> > Hi Josef, >> > Can you please help me with another question. >> > >> > I am looking at your patch: >> >

Re: question about transaction-abort-related commits

2013-06-30 Thread Josef Bacik
On Sun, Jun 30, 2013 at 11:29:14AM +0300, Alex Lyakas wrote: > Hi Josef, > > On Wed, Jun 26, 2013 at 5:16 PM, Alex Lyakas > wrote: > > Hi Josef, > > Can you please help me with another question. > > > > I am looking at your patch: > > Btrfs: fix chunk allocation error handling > > https://git.ker

Re: question about transaction-abort-related commits

2013-06-30 Thread Alex Lyakas
Hi Josef, On Wed, Jun 26, 2013 at 5:16 PM, Alex Lyakas wrote: > Hi Josef, > Can you please help me with another question. > > I am looking at your patch: > Btrfs: fix chunk allocation error handling > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=0448748849ef7c593be40

Re: question about transaction-abort-related commits

2013-06-26 Thread Alex Lyakas
Hi Josef, Can you please help me with another question. I am looking at your patch: Btrfs: fix chunk allocation error handling https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=0448748849ef7c593be40e2c1404f7974bd3aac6 Here you changed the order of btrfs_make_block_group()

Re: question about transaction-abort-related commits

2013-06-24 Thread Alex Lyakas
Thanks for commenting Josef. I hope your head will get better:) Actually, while re-looking at the code, I see that there are couple of "goto cleanup;", before we ensure that all the writers have detached from the committing transaction. So Liu's code is still needed, looks like. Thanks, Alex. On

Re: question about transaction-abort-related commits

2013-06-24 Thread Josef Bacik
On Sun, Jun 23, 2013 at 09:52:14PM +0300, Alex Lyakas wrote: > Hello Josef, Liu, > I am reviewing commits in the mainline tree: > > e4a2bcaca9643e7430207810653222fc5187f2be Btrfs: if we aren't > committing just end the transaction if we error out > (call end_transaction() instead of goto cleanup_t

question about transaction-abort-related commits

2013-06-23 Thread Alex Lyakas
Hello Josef, Liu, I am reviewing commits in the mainline tree: e4a2bcaca9643e7430207810653222fc5187f2be Btrfs: if we aren't committing just end the transaction if we error out (call end_transaction() instead of goto cleanup_transaction) - Josef f094ac32aba3a51c00e970a2ea029339af2ca048 Btrfs: fix