On Wed, Sep 4, 2019 at 4:19 AM Johannes Thumshirn wrote:
>
> The test-case 'misc-tests/025-zstd-compression' is failing on a kernel or
> btrfs binary built without zstd compression support.
>
> Check if zstd compression is supported by either the kernel or the btrfs
>
The test-case 'misc-tests/025-zstd-compression' is failing on a kernel or
btrfs binary built without zstd compression support.
Check if zstd compression is supported by either the kernel or the btrfs
binary and if not skip the test-case.
Signed-off-by: Johannes Thumshirn
---
Cha
On 03/09/2019 18:09, David Sterba wrote:
>> +if ! [ -f "/sys/fs/btrfs/features/compress_zstd" ]; then
>> + _not_run "kernel does not support zstd compression feature"
>
> Sorry, I misled you with this check. The test needs to detect zstd
> support
On Tue, Sep 03, 2019 at 02:27:21PM +0200, Johannes Thumshirn wrote:
> The test-case 'misc-tests/025-zstd-compression' is failing on a kernel
> without zstd compression support.
>
> Check if zstd compression is supported by the kernel and if not skip the
> test-case.
>
The test-case 'misc-tests/025-zstd-compression' is failing on a kernel
without zstd compression support.
Check if zstd compression is supported by the kernel and if not skip the
test-case.
Signed-off-by: Johannes Thumshirn
---
tests/misc-tests/025-zstd-compression/test.sh | 5 +++
We let to pass zstd compression parameter even if its not fully written.
For example:
btrfs prop set /btrfs compression zst
btrfs prop get /btrfs compression
compression=zst
zlib and lzo are fine.
Fix it by using the expected number of char in strncmp().
Signed-off-by: Anand Jain
On Tue, Apr 02, 2019 at 06:07:38PM +0800, Anand Jain wrote:
> We let to pass zstd compression parameter even if its not fully written.
> For example:
> btrfs prop set /btrfs compression zst
> btrfs prop get /btrfs compression
> compression=zst
>
> zlib and lzo are
We let to pass zstd compression parameter even if its not fully written.
For example:
btrfs prop set /btrfs compression zst
btrfs prop get /btrfs compression
compression=zst
zlib and lzo are fine.
Fix it by using the expected number of char in strncmp().
Signed-off-by: Anand Jain
We let to pass zstd compression parameter even if its not fully written.
For example:
btrfs prop set /btrfs compression zst
btrfs prop get /btrfs compression
compression=zst
zlib and lzo are fine.
Fix it by using the expected number of char in strncmp().
Signed-off-by: Anand Jain
On 13.03.19 г. 7:36 ч., Anand Jain wrote:
> We let to pass zstd compression parameter even if its not fully written.
> For example:
> btrfs prop set /btrfs compression zst
> btrfs prop get /btrfs compression
> compression=zst
>
> zlib and lzo are fine.
>
We let to pass zstd compression parameter even if its not fully written.
For example:
btrfs prop set /btrfs compression zst
btrfs prop get /btrfs compression
compression=zst
zlib and lzo are fine.
Fix it by using the expected number of char in strncmp().
Signed-off-by: Anand Jain
zstd use the passed through level instead of default
> > > btrfs: make zstd memory requirements monotonic
> > > btrfs: add zstd compression level support
> >
> > The patchset has been added to msic-next, scheduled for 5.1. I've left
> > out the changes to war
put workspaces
> > btrfs: plumb level through the compression interface
> > btrfs: change set_level() to bound the level passed in
> > btrfs: zstd use the passed through level instead of default
> > btrfs: make zstd memory requirements monotonic
> > btrfs:
) to bound the level passed in
> btrfs: zstd use the passed through level instead of default
> btrfs: make zstd memory requirements monotonic
> btrfs: add zstd compression level support
The patchset has been added to msic-next, scheduled for 5.1. I've left
out the changes to warn o
On Wed, Feb 06, 2019 at 04:15:52PM +0100, David Sterba wrote:
> On Tue, Feb 05, 2019 at 03:48:48PM -0500, Dennis Zhou wrote:
> > > Ok great! I'm going to add a v2 for 0012 to add taking the spin_lock
> > > just to be safe in cleanup. I should have that ready in a few minutes.
> > >
> >
> > Before
>From 16b7c3fe05984a95436da1e9e01c80de1fdbba25 Mon Sep 17 00:00:00 2001
From: Dennis Zhou
Date: Sat, 19 Jan 2019 18:51:39 -0800
Zstd compression requires different amounts of memory for each level of
compression. The prior patches implemented indirection to allow for each
compression type
On Tue, Feb 05, 2019 at 03:48:48PM -0500, Dennis Zhou wrote:
> > Ok great! I'm going to add a v2 for 0012 to add taking the spin_lock
> > just to be safe in cleanup. I should have that ready in a few minutes.
> >
>
> Before I run v3, are there any other concerns (pending the changes I
> made to a
On Tue, Feb 05, 2019 at 01:30:27PM -0500, Dennis Zhou wrote:
> On Tue, Feb 05, 2019 at 07:27:49PM +0100, David Sterba wrote:
> > On Tue, Feb 05, 2019 at 06:07:49PM +0100, David Sterba wrote:
> > > On Tue, Feb 05, 2019 at 05:51:13PM +0100, David Sterba wrote:
> > > > On Tue, Feb 05, 2019 at 11:30:12
>From 0d8684d1d7b18dfa9d5bc9c74033c6c3b6fecd92 Mon Sep 17 00:00:00 2001
From: Dennis Zhou
Date: Sat, 19 Jan 2019 18:51:39 -0800
Zstd compression requires different amounts of memory for each level of
compression. The prior patches implemented indirection to allow for each
compression type
On Tue, Feb 05, 2019 at 07:27:49PM +0100, David Sterba wrote:
> On Tue, Feb 05, 2019 at 06:07:49PM +0100, David Sterba wrote:
> > On Tue, Feb 05, 2019 at 05:51:13PM +0100, David Sterba wrote:
> > > On Tue, Feb 05, 2019 at 11:30:12AM -0500, Dennis Zhou wrote:
> > > > > > > Something is wrong, the pa
On Tue, Feb 05, 2019 at 06:07:49PM +0100, David Sterba wrote:
> On Tue, Feb 05, 2019 at 05:51:13PM +0100, David Sterba wrote:
> > On Tue, Feb 05, 2019 at 11:30:12AM -0500, Dennis Zhou wrote:
> > > > > > Something is wrong, the patchset on top of 5.0-rc5 hangs in test
> > > > > > btrfs/007, without
On Tue, Feb 05, 2019 at 05:51:13PM +0100, David Sterba wrote:
> On Tue, Feb 05, 2019 at 11:30:12AM -0500, Dennis Zhou wrote:
> > > > > Something is wrong, the patchset on top of 5.0-rc5 hangs in test
> > > > > btrfs/007, without a stacktrace. V1 was fine and I double checked that
> > > > > rc5 itse
On Tue, Feb 05, 2019 at 11:30:12AM -0500, Dennis Zhou wrote:
> > > > Something is wrong, the patchset on top of 5.0-rc5 hangs in test
> > > > btrfs/007, without a stacktrace. V1 was fine and I double checked that
> > > > rc5 itself is fine.
> > >
> > > Hmmm, well that's awkward. I ran xfstests and
On Tue, Feb 05, 2019 at 05:27:34PM +0100, David Sterba wrote:
> On Tue, Feb 05, 2019 at 11:03:02AM -0500, Dennis Zhou wrote:
> > On Tue, Feb 05, 2019 at 03:57:53PM +0100, David Sterba wrote:
> > > On Mon, Feb 04, 2019 at 03:19:56PM -0500, Dennis Zhou wrote:
> > > > Hi everyone,
> > > >
> > > > V2
On Tue, Feb 05, 2019 at 11:03:02AM -0500, Dennis Zhou wrote:
> On Tue, Feb 05, 2019 at 03:57:53PM +0100, David Sterba wrote:
> > On Mon, Feb 04, 2019 at 03:19:56PM -0500, Dennis Zhou wrote:
> > > Hi everyone,
> > >
> > > V2 had only a handful of changes outside of minor feedback.
> > > 0001:
> > >
On Tue, Feb 05, 2019 at 03:57:53PM +0100, David Sterba wrote:
> On Mon, Feb 04, 2019 at 03:19:56PM -0500, Dennis Zhou wrote:
> > Hi everyone,
> >
> > V2 had only a handful of changes outside of minor feedback.
> > 0001:
> > - use functions over macros
> > 0003:
> > - BTRFS_NR_WORKSPACE_MANAGERS is
On Mon, Feb 04, 2019 at 03:19:56PM -0500, Dennis Zhou wrote:
> Hi everyone,
>
> V2 had only a handful of changes outside of minor feedback.
> 0001:
> - use functions over macros
> 0003:
> - BTRFS_NR_WORKSPACE_MANAGERS is added instead of overriding
> BTRFS_COMPRESS_TYPES
> 0011 (new):
> - addres
of [1] which aims to add zstd compression level
support. V3 moves away from the using set_level() to resize workspaces
in favor of just allocating a workspace of the appropriate level and
using a timer to reclaim unused workspaces.
Zstd compression requires different amounts of memory for each le
Zstd compression requires different amounts of memory for each level of
compression. The prior patches implemented indirection to allow for each
compression type to manage their workspaces independently. This patch
uses this indirection to implement compression level support for zstd.
To manage
On Mon, Jan 28, 2019 at 04:24:37PM -0500, Dennis Zhou wrote:
> static struct list_head *zstd_get_workspace(unsigned int level)
> {
> - struct list_head *ws = btrfs_get_workspace(&wsm, level);
> - struct workspace *workspace = list_entry(ws, struct workspace, list);
> + struct list_hea
On Mon, Jan 28, 2019 at 04:24:37PM -0500, Dennis Zhou wrote:
> As mentioned above, a requirement that differs zstd from zlib is that
> higher levels of compression require more memory. To manage this, each
> compression level has its own queue of workspaces. A global LRU is used
> to help with recl
On Thu, Jan 31, 2019 at 03:04:36PM +0100, David Sterba wrote:
> On Wed, Jan 30, 2019 at 12:40:59PM -0500, Dennis Zhou wrote:
> > Hi David,
> >
> > On Tue, Jan 29, 2019 at 06:18:30PM +0100, David Sterba wrote:
> > > On Mon, Jan 28, 2019 at 04:24:26PM -0500, Dennis Zhou wrote:
> > > > As mentioned a
On Wed, Jan 30, 2019 at 12:40:59PM -0500, Dennis Zhou wrote:
> Hi David,
>
> On Tue, Jan 29, 2019 at 06:18:30PM +0100, David Sterba wrote:
> > On Mon, Jan 28, 2019 at 04:24:26PM -0500, Dennis Zhou wrote:
> > > As mentioned above, a requirement that differs zstd from zlib is that
> > > higher level
Hi David,
On Tue, Jan 29, 2019 at 06:18:30PM +0100, David Sterba wrote:
> On Mon, Jan 28, 2019 at 04:24:26PM -0500, Dennis Zhou wrote:
> > As mentioned above, a requirement that differs zstd from zlib is that
> > higher levels of compression require more memory. To manage this, each
> > compressio
On Tue, Jan 29, 2019 at 09:25:54AM +0200, Nikolay Borisov wrote:
>
>
> On 28.01.19 г. 23:24 ч., Dennis Zhou wrote:
> > Zstd compression requires different amounts of memory for each level of
> > compression. The prior patches implemented indirection to allow for each
&g
> On Jan 29, 2019, at 9:18 AM, David Sterba wrote:
>
> On Mon, Jan 28, 2019 at 04:24:26PM -0500, Dennis Zhou wrote:
>> As mentioned above, a requirement that differs zstd from zlib is that
>> higher levels of compression require more memory. To manage this, each
>> compression level has its ow
On Mon, Jan 28, 2019 at 04:24:26PM -0500, Dennis Zhou wrote:
> As mentioned above, a requirement that differs zstd from zlib is that
> higher levels of compression require more memory. To manage this, each
> compression level has its own queue of workspaces. A global LRU is used
> to help with recl
On 28.01.19 г. 23:24 ч., Dennis Zhou wrote:
> Zstd compression requires different amounts of memory for each level of
> compression. The prior patches implemented indirection to allow for each
> compression type to manage their workspaces independently. This patch
> uses this in
Hi everyone,
This is a respin of [1] which aims to add zstd compression level
support. V3 moves away from the using set_level() to resize workspaces
in favor of just allocating a workspace of the appropriate level and
using a timer to reclaim unused workspaces.
Zstd compression requires
Zstd compression requires different amounts of memory for each level of
compression. The prior patches implemented indirection to allow for each
compression type to manage their workspaces independently. This patch
uses this indirection to implement compression level support for zstd.
As
On Tue, Nov 13, 2018 at 01:33:32AM +0100, David Sterba wrote:
> On Wed, Oct 31, 2018 at 11:11:08AM -0700, Nick Terrell wrote:
> > From: Jennifer Liu
> >
> > Adds zstd compression level support to btrfs. Zstd requires
> > different amounts of memory for each level,
0, Nick Terrell wrote:
> > >> From: Jennifer Liu
> > >>
> > >> Adds zstd compression level support to btrfs. Zstd requires
> > >> different amounts of memory for each level, so the design had
> > >> to be modified to allow set_level() to allocate memory. W
> On Nov 13, 2018, at 5:29 AM, Timofey Titovets wrote:
>
> вт, 13 нояб. 2018 г. в 04:52, Nick Terrell :
>>
>>
>>
>>> On Nov 12, 2018, at 4:33 PM, David Sterba wrote:
>>>
>>> On Wed, Oct 31, 2018 at 11:11:08AM -0700, Nick Terrel
вт, 13 нояб. 2018 г. в 04:52, Nick Terrell :
>
>
>
> > On Nov 12, 2018, at 4:33 PM, David Sterba wrote:
> >
> > On Wed, Oct 31, 2018 at 11:11:08AM -0700, Nick Terrell wrote:
> >> From: Jennifer Liu
> >>
> >> Adds zstd compression level sup
> On Nov 12, 2018, at 4:33 PM, David Sterba wrote:
>
> On Wed, Oct 31, 2018 at 11:11:08AM -0700, Nick Terrell wrote:
>> From: Jennifer Liu
>>
>> Adds zstd compression level support to btrfs. Zstd requires
>> different amounts of memory for each level, so th
On Wed, Oct 31, 2018 at 11:11:08AM -0700, Nick Terrell wrote:
> From: Jennifer Liu
>
> Adds zstd compression level support to btrfs. Zstd requires
> different amounts of memory for each level, so the design had
> to be modified to allow set_level() to allocate memory. We
&g
On Wed, Oct 31, 2018 at 11:11:08AM -0700, Nick Terrell wrote:
> From: Jennifer Liu
>
> Adds zstd compression level support to btrfs. Zstd requires
> different amounts of memory for each level, so the design had
> to be modified to allow set_level() to allocate memory. We
&g
> On Nov 1, 2018, at 5:57 AM, Timofey Titovets wrote:
>
> ср, 31 окт. 2018 г. в 21:12, Nick Terrell :
>>
>> From: Jennifer Liu
>>
>> Adds zstd compression level support to btrfs. Zstd requires
>> different amounts of memory for each level, so th
ср, 31 окт. 2018 г. в 21:12, Nick Terrell :
>
> From: Jennifer Liu
>
> Adds zstd compression level support to btrfs. Zstd requires
> different amounts of memory for each level, so the design had
> to be modified to allow set_level() to allocate memory. We
> preallocate
From: Jennifer Liu
Adds zstd compression level support to btrfs. Zstd requires
different amounts of memory for each level, so the design had
to be modified to allow set_level() to allocate memory. We
preallocate one workspace of the maximum size to guarantee
forward progress. This feature is
On Tue, Oct 30, 2018 at 12:06:21PM -0700, Nick Terrell wrote:
> From: Jennifer Liu
>
> Adds zstd compression level support to btrfs. Zstd requires
> different amounts of memory for each level, so the design had
> to be modified to allow set_level() to allocate memory. We
&g
From: Jennifer Liu
Adds zstd compression level support to btrfs. Zstd requires
different amounts of memory for each level, so the design had
to be modified to allow set_level() to allocate memory. We
preallocate one workspace of the maximum size to guarantee
forward progress. This feature is
On Tue, May 15, 2018 at 04:51:26PM +0900, Misono Tomohiro wrote:
> Incompat flag of lzo/zstd compression should be set at:
> 1. mount time (-o compress/compress-force)
> 2. when defrag is done
> 3. when property is set
>
> Currently 3. is missing and this commit adds this
On 05/15/2018 04:35 PM, Duncan wrote:
> Su Yue posted on Tue, 15 May 2018 16:05:01 +0800 as excerpted:
>
>
>>
>> On 05/15/2018 03:51 PM, Misono Tomohiro wrote:
>>> Incompat flag of lzo/zstd compression should be set at:
>>> 1. mount time (-o compress
Su Yue posted on Tue, 15 May 2018 16:05:01 +0800 as excerpted:
>
> On 05/15/2018 03:51 PM, Misono Tomohiro wrote:
>> Incompat flag of lzo/zstd compression should be set at:
>> 1. mount time (-o compress/compress-force)
>> 2. when defrag is done 3. when property is se
On 05/15/2018 04:05 PM, Su Yue wrote:
>
>
> On 05/15/2018 03:51 PM, Misono Tomohiro wrote:
>> Incompat flag of lzo/zstd compression should be set at:
>> 1. mount time (-o compress/compress-force)
>> 2. when defrag is done
>> 3. when property is set
>&
On 05/15/2018 03:51 PM, Misono Tomohiro wrote:
Incompat flag of lzo/zstd compression should be set at:
1. mount time (-o compress/compress-force)
2. when defrag is done
3. when property is set
Currently 3. is missing and this commit adds this.
Signed-off-by: Tomohiro Misono
Reviewed
On 05/15/2018 03:51 PM, Misono Tomohiro wrote:
> Incompat flag of lzo/zstd compression should be set at:
> 1. mount time (-o compress/compress-force)
> 2. when defrag is done
> 3. when property is set
>
> Currently 3. is missing and this commit adds this.
>
If
Incompat flag of lzo/zstd compression should be set at:
1. mount time (-o compress/compress-force)
2. when defrag is done
3. when property is set
Currently 3. is missing and this commit adds this.
Signed-off-by: Tomohiro Misono
---
fs/btrfs/props.c | 12
1 file changed, 8
2017-11-16 19:32 GMT+03:00 Austin S. Hemmelgarn :
> On 2017-11-16 08:43, Duncan wrote:
>>
>> Austin S. Hemmelgarn posted on Thu, 16 Nov 2017 07:30:47 -0500 as
>> excerpted:
>>
>>> On 2017-11-15 16:31, Duncan wrote:
Austin S. Hemmelgarn posted on Wed, 15 Nov 2017 07:57:06 -0500 as
exc
On 2017-11-16 08:43, Duncan wrote:
Austin S. Hemmelgarn posted on Thu, 16 Nov 2017 07:30:47 -0500 as
excerpted:
On 2017-11-15 16:31, Duncan wrote:
Austin S. Hemmelgarn posted on Wed, 15 Nov 2017 07:57:06 -0500 as
excerpted:
The 'compress' and 'compress-force' mount options only impact newly
Austin S. Hemmelgarn posted on Thu, 16 Nov 2017 07:30:47 -0500 as
excerpted:
> On 2017-11-15 16:31, Duncan wrote:
>> Austin S. Hemmelgarn posted on Wed, 15 Nov 2017 07:57:06 -0500 as
>> excerpted:
>>
>>> The 'compress' and 'compress-force' mount options only impact newly
>>> written data. The co
On 11/16/17, Austin S. Hemmelgarn wrote:
> I'm pretty sure defrag is equivalent to 'compress-force', not
> 'compress', but I may be wrong.
Are there any devs to confirm this?
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majord...@vger.kerne
On 2017-11-15 16:31, Duncan wrote:
Austin S. Hemmelgarn posted on Wed, 15 Nov 2017 07:57:06 -0500 as
excerpted:
The 'compress' and 'compress-force' mount options only impact newly
written data. The compression used is stored with the metadata for the
extents themselves, so any existing data on
Austin S. Hemmelgarn posted on Wed, 15 Nov 2017 07:57:06 -0500 as
excerpted:
> The 'compress' and 'compress-force' mount options only impact newly
> written data. The compression used is stored with the metadata for the
> extents themselves, so any existing data on the volume will be read just
>
On 2017-11-15 05:35, Imran Geriskovan wrote:
On 11/15/17, Lukas Pirl wrote:
you might be interested in the thread "Read before you deploy
btrfs + zstd"¹.
Thanks. I've read it. Bootloader is not an issue since /boot is on
another uncompressed fs.
Let me make my question more generic:
Can the
On 11/15/17, Lukas Pirl wrote:
> you might be interested in the thread "Read before you deploy
> btrfs + zstd"¹.
Thanks. I've read it. Bootloader is not an issue since /boot is on
another uncompressed fs.
Let me make my question more generic:
Can there be any issues for switching mount time
com
Hi Imran,
On 11/15/2017 09:51 AM, Imran Geriskovan wrote as excerpted:
> Any further advices?
you might be interested in the thread "Read before you deploy btrfs +
zstd"¹.
Cheers,
Lukas
¹ https://www.mail-archive.com/linux-btrfs@vger.kernel.org/msg69871.html
--
To unsubscribe from this list: s
Kernel 4.14 now includes btrfs zstd compression support.
My question:
I currently have a fs mounted and used with "compress=lzo"
option. What happens if I change it to "compress=zstd"?
My guess is that existing files will be read and uncompressed via lzo.
And new files will
69 matches
Mail list logo
