[PATCH] btrfs: fix possible deadlock by clearing __GFP_FS flag

2011-03-27 Thread Miao Xie
Using the GFP_HIGHUSER_MOVABLE flag to allocate the metadata's page may cause deadlock. Task1 Kswap0 task open() ... btrfs_search_slot() ... btrfs_cow_block() ... alloc_page() wait for reclaiming

Re: [PATCH V5 2/2] btrfs: implement delayed inode items operation

2011-03-27 Thread Itaru Kitayama
Hi Miao, On Sun, 27 Mar 2011 15:00:00 +0800 Miao Xie wrote: > I got it. It is because the allocation flag of the metadata's page cache, > which is stored in > the btree inode's i_mapping, was set to be GFP_HIGHUSER_MOVABLE. So if we > allocate pages for > btree's page cache, this lockdep warni

Re: [PATCH V5 2/2] btrfs: implement delayed inode items operation

2011-03-27 Thread Miao Xie
On sun, 27 Mar 2011 20:09:10 +0900, Itaru Kitayama wrote: > Hi Miao, > > On Sun, 27 Mar 2011 15:00:00 +0800 > Miao Xie wrote: > >> I got it. It is because the allocation flag of the metadata's page cache, >> which is stored in >> the btree inode's i_mapping, was set to be GFP_HIGHUSER_MOVABLE.

Re: [PATCH V5 2/2] btrfs: implement delayed inode items operation

2011-03-27 Thread Chris Mason
Excerpts from Miao Xie's message of 2011-03-27 07:44:06 -0400: > On sun, 27 Mar 2011 20:09:10 +0900, Itaru Kitayama wrote: > > Hi Miao, > > > > On Sun, 27 Mar 2011 15:00:00 +0800 > > Miao Xie wrote: > > > >> I got it. It is because the allocation flag of the metadata's page cache, > >> which is

[PATCH V2] btrfs: fix possible deadlock by clearing __GFP_FS flag

2011-03-27 Thread Miao Xie
Changelog V1 -> V2: - modify the explanation of the deadlock. - clear __GFP_FS flag in the free space's page cache. Using the GFP_HIGHUSER_MOVABLE flag to allocate the metadata's page may cause deadlock. Task1 open() ... btrfs_search_slot() ... btrfs_cow_block() ...

Re: [PATCH V2] btrfs: fix possible deadlock by clearing __GFP_FS flag

2011-03-27 Thread Chris Mason
Excerpts from Miao Xie's message of 2011-03-27 08:27:30 -0400: > Changelog V1 -> V2: > - modify the explanation of the deadlock. > - clear __GFP_FS flag in the free space's page cache. > > diff --git a/fs/btrfs/free-space-cache.c b/fs/btrfs/free-space-cache.c > index a039065..57df380 100644 > ---

Phishing (was: Account Verification)

2011-03-27 Thread Helmut Hullen
Hallo, Webmail, Du meintest am 27.03.11: > You have almost exceeded your webmail storage quota. To avoid account > deletion, please > click on the link below > http://vwebtips.host-ed.net/Session_id_2011.htm That's a phishing invitation. Who can delete this spammer from the mailing list? Viel

Re: Phishing (was: Account Verification)

2011-03-27 Thread Calvin Walton
On Sun, 2011-03-27 at 18:22 +0200, Helmut Hullen wrote: > Du meintest am 27.03.11: > > > You have almost exceeded your webmail storage quota. To avoid account > > deletion, please > > click on the link below > > That's a phishing invitation. > > Who can delete this spammer from the mailing list?

Re: [PATCH V4 0/4] Btrfs: batched discard support for btrfs

2011-03-27 Thread Chris Mason
Excerpts from Li Dongyang's message of 2011-03-24 06:24:24 -0400: > Dear list, > This is V4 of batched discard support, now we will get full mapping of > the free space on each device for RAID0/1/10/DUP instead of just a single > stripe length, and tested with xfsstests 251, Thanks. I've pushed th

I cannot mount two (=all) btrfs volumes after crash while TOI suspending

2011-03-27 Thread jasiu
I used btrfs on / and /var. After first suspending on 2.6.38.1 yesterday (screen was black, no disk activity, but it respond to Magic SysRq [sync,remount-ro,reboot]) system cannot boot. A copied system from 3-month-old backup to new disk using ext4 only fs, so I could have btrfs in a module and

Re: [PATCH] Btrfs: add initial tracepoint support for btrfs

2011-03-27 Thread Chris Mason
Excerpts from Chris Mason's message of 2011-03-26 08:12:04 -0400: > Excerpts from liubo's message of 2011-03-24 07:18:59 -0400: > > > > Tracepoints can provide insight into why btrfs hits bugs and be greatly > > helpful for debugging, e.g > > This is really neat, I've queued it up. Whoops, it ha

Re: [PATCH V4 0/4] Btrfs: batched discard support for btrfs

2011-03-27 Thread Chris Mason
Excerpts from Chris Mason's message of 2011-03-27 14:10:46 -0400: > Excerpts from Li Dongyang's message of 2011-03-24 06:24:24 -0400: > > Dear list, > > This is V4 of batched discard support, now we will get full mapping of > > the free space on each device for RAID0/1/10/DUP instead of just a sing

Re: [PATCH V4 0/4] Btrfs: batched discard support for btrfs

2011-03-27 Thread Chris Mason
Excerpts from Chris Mason's message of 2011-03-27 21:30:20 -0400: > Excerpts from Chris Mason's message of 2011-03-27 14:10:46 -0400: > > Excerpts from Li Dongyang's message of 2011-03-24 06:24:24 -0400: > > > Dear list, > > > This is V4 of batched discard support, now we will get full mapping of >

[RFC][PATCH] Btrfs: Fix uninitialized root flags for subvolumes

2011-03-27 Thread Li Zefan
root_item->flags and root_item->byte_limit are not initialized when a subvolume is created. This bug is not revealed until we added readonly snapshot support - now you mount a btrfs filesystem and you may find the subvolumes in it are readonly. To work around this problem, we steal a bit from root

Re: 2.6.38 defragment compression oops...

2011-03-27 Thread Li Zefan
Daniel J Blueman wrote: > I found that I'm able to provoke undefined behaviour with 2.6.38 with > extent defragmenting + recompression, eg: > > mkfs.btrfs /dev/sdb > mount /dev/sdb /mnt > cp -xa / /mnt > find /mnt -print0 | xargs -0 btrfs filesystem defragment -vc > > After a short time, I was se