Possible btrfs deadlock coused by commit 660d3f6c

2012-01-16 Thread Stanislaw Gruszka
Hi Josef, commit 660d3f6cde552323578b85fc5a09a6742f1fe804 Author: Josef Bacik Date: Fri Dec 9 11:18:51 2011 -0500 Btrfs: fix how we do delalloc reservations and how we free reservations on error introduced possible deadlock. According to comment before btrfs_page_mkwrite(), that function

[PATCH] Btrfs: do not defrag a file partially

2012-01-16 Thread Liu Bo
xfstests 218 complains that btrfs defrags a file partially: After: 1 Write backwards sync, but contiguous - should defrag to 1 extent Before: 10 -After: 1 +After: 2 To fix this, we need to set max_to_defrag count properly. Signed-off-by: Liu Bo --- fs/btrfs/ioctl.c |2 +- 1 files changed

[PATCH] Xfstest: make 218 support btrfs

2012-01-16 Thread Liu Bo
Btrfs progs has a defragment tool, so we can test 218 on btrfs now. Signed-off-by: Liu Bo --- 218 |2 +- common.defrag |3 +++ 2 files changed, 4 insertions(+), 1 deletions(-) diff --git a/218 b/218 index 53d0b61..77782c6 100755 --- a/218 +++ b/218 @@ -44,7 +44,7 @@ _cleanup()

Re: Updated btrfs/crypto snappy interface ready for merging

2012-01-16 Thread Chris Mason
On Thu, Jan 12, 2012 at 04:28:47PM -0800, Andi Kleen wrote: > Here's a slightly updated version of the BTRFS snappy interface. > snappy is a faster compression algorithm that provides similar > compression as LZO, but generally better performance. Thanks Andi, I've queued this up to a btrfs snappy

Re: Possible btrfs deadlock coused by commit 660d3f6c

2012-01-16 Thread Josef Bacik
On Mon, Jan 16, 2012 at 09:53:23AM +0100, Stanislaw Gruszka wrote: > Hi Josef, > > commit 660d3f6cde552323578b85fc5a09a6742f1fe804 > Author: Josef Bacik > Date: Fri Dec 9 11:18:51 2011 -0500 > > Btrfs: fix how we do delalloc reservations and how we free reservations > on error > > introd

Re: Warning: bad fsid on block 20971520

2012-01-16 Thread David Sterba
On Wed, Jan 11, 2012 at 11:34:34PM +0100, David Sterba wrote: > I will try to catch it with blktrace running. Measurement disrupted the experiment. The second I start blktrace, these messages [450482.299863] device fsid 7f7bfb60-b8f3-457e-857a-9a1a187f750f devid 1 transid 7 /dev/sda9 [450482.309

Re: Warning: bad fsid on block 20971520

2012-01-16 Thread David Sterba
On Mon, Jan 16, 2012 at 03:34:28PM +0100, David Sterba wrote: > Per your advice, I'll try to test with other filesystems, with older > kernels, and in btrfs case add fsync into mkfs. I left looping the 3.0.13 based sles kernel and did not trigger the warning for several hours. In the meantime I g

Re: Possible btrfs deadlock coused by commit 660d3f6c

2012-01-16 Thread Al Viro
On Mon, Jan 16, 2012 at 09:26:00AM -0500, Josef Bacik wrote: > On Mon, Jan 16, 2012 at 09:53:23AM +0100, Stanislaw Gruszka wrote: > > Hi Josef, > > > > commit 660d3f6cde552323578b85fc5a09a6742f1fe804 > > Author: Josef Bacik > > Date: Fri Dec 9 11:18:51 2011 -0500 > > > > Btrfs: fix how we

integration branch rebased

2012-01-16 Thread Chris Mason
Hi everyone, Ilya reworked the new balancing ioctls a little, so I've rebased the integration branch to include his new code. Sorry for the trouble. -chris -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majord

Re: Possible btrfs deadlock coused by commit 660d3f6c

2012-01-16 Thread Josef Bacik
On Mon, Jan 16, 2012 at 08:45:29PM +, Al Viro wrote: > On Mon, Jan 16, 2012 at 09:26:00AM -0500, Josef Bacik wrote: > > On Mon, Jan 16, 2012 at 09:53:23AM +0100, Stanislaw Gruszka wrote: > > > Hi Josef, > > > > > > commit 660d3f6cde552323578b85fc5a09a6742f1fe804 > > > Author: Josef Bacik > >

Re: Possible btrfs deadlock coused by commit 660d3f6c

2012-01-16 Thread Chris Samuel
On 17/01/12 09:01, Josef Bacik wrote: > Good point, either way it's been fixed. Thanks, Is it worth pushing that fix into the stable 3.2.x releases ? cheers, Chris -- Chris Samuel : http://www.csamuel.org/ : Melbourne, VIC -- To unsubscribe from this list: send the line "unsubscribe linux

Re: NULL Pointer Dereference While Scrubbing

2012-01-16 Thread Mitch Harder
On Tue, Jan 3, 2012 at 11:35 AM, Mitch Harder wrote: > I've recently run into a kernel "NULL pointer dereference" while > scrubbing a partition that had picked up error. > I'm no longer getting the NULL pointer panic on this partition. I'm running into a new BUG_ON() now resulting from a EFBIG e

Re: [PATCH] Btrfs: do not defrag a file partially

2012-01-16 Thread Li Zefan
Liu Bo wrote: > xfstests 218 complains that btrfs defrags a file partially: > After: 1 > Write backwards sync, but contiguous - should defrag to 1 extent > Before: 10 > -After: 1 > +After: 2 > > To fix this, we need to set max_to_defrag count properly. > > Signed-off-by: Liu Bo Reviewed-by:

[PATCH] Btrfs: fix incompat flags setting

2012-01-16 Thread Li Zefan
The new snappy code reveals this old bug in btrfs, which happened to work for LZO. # mkfs.btrfs /dev/loop2 # mount /dev/loop2 # umount /mnt # btrfsck /dev/loop2 couldn't open because of unsupported option features (10). The corresponding incompat flag was s