Re: Null pointer dereference bug in btrfs_find_all_root

2013-10-29 Thread Pedro Fonseca
On 10/29/2013 07:17 AM, Liu Bo wrote: On Tue, Oct 29, 2013 at 04:38:39AM +0100, Pedro Fonseca wrote: On 10/29/13 3:05 AM, Liu Bo wrote: Hi, On Mon, Oct 28, 2013 at 05:02:11PM +0100, Pedro Fonseca wrote: Hi, I've encountered a few NULL pointer dereference bugs while running a custom test case

[PATCH] Btrfs: incompatible format change to remove hole extents V2

2013-10-29 Thread Josef Bacik
Btrfs has always had these filler extent data items for holes in inodes. This has made somethings very easy, like logging hole punches and sending hole punches. However for large holey files these extent data items are pure overhead. So add an incompatible feature to no longer add hole extents t

Re: [PATCH] Btrfs: take ordered root lock when removing ordered operations inode

2013-10-29 Thread David Sterba
On Mon, Oct 28, 2013 at 09:15:14AM -0400, Josef Bacik wrote: > A user reported a list corruption warning from btrfs_remove_ordered_extent, it > is because we aren't taking the ordered_root_lock when we remove the inode > from > the ordered operations list. Thanks, > > Signed-off-by: Josef Bacik

Moving over to use BTRFS - first time, needs encryption

2013-10-29 Thread btrfs . nrb
Hi, I would be pleased to get some help after I have looked and not figured out how this should work: Summary === btrfs device add Returns - Inappropriate ioctl for device Details = // I have an existing btrfs file system // built from one ~650G partition in middle of 1TB GPT disk, //

[PATCH 2/3 v2] btrfs-progs: mechanism to fetch fsinfo from btrfs-control

2013-10-29 Thread Anand Jain
need fsinfo from btrfs-control that is when mount path is not known. current method of going through each mount points isn't efficient, and multiple subvol of a fsid could be mounted means extra logic to handle that. Further this will help to revamp check_mounted() (planned) check_mounted is heavi

[PATCH] btrfs-progs: lblkid wouldn't find non mapper path input

2013-10-29 Thread Anand Jain
A new test case when disk is unmounted and if the non mapper disk path is given as the argument to the btrfs filesystem show we still need this to work but lblkid will pull only mapper disks, it won't match. So this will normalize the input to find btrfs by fsid and pass it to the search. Signed-

Re: [PATCH] btrfs-progs: lblkid wouldn't find non mapper path input

2013-10-29 Thread Josef Bacik
On Wed, Oct 30, 2013 at 12:34:50AM +0800, Anand Jain wrote: > A new test case when disk is unmounted and if the non mapper > disk path is given as the argument to the btrfs filesystem show > we still need this to work but lblkid will pull only mapper disks, > it won't match. So this will normalize

Re: memory leak in <=3.11.6

2013-10-29 Thread Duncan
Jérôme Poulin posted on Mon, 28 Oct 2013 23:24:10 -0400 as excerpted: > On Mon, Oct 28, 2013 at 6:34 PM, Kai Krakow > wrote: >> >> If I close all my desktop programs, my system stays at +12 GB RAM usage >> while after a fresh boot it has 12+ GB free (of 16 GB). Cache stays low >> at 2 GB while af

Re: Moving over to use BTRFS - first time, needs encryption (btrfs: message 1 of 20)

2013-10-29 Thread Nigel Bray
Update: I found this: .. by upgrading kernel ...according to the BTRFS wiki, changing raid levels after the filesystem has been created isn't supported for 3.2 series and older kernels. Need to move from stable stock., > Ubuntu 12.04LTS and Debian 7.2. http://serverfault.com/questions/496503/co

Re: Moving over to use BTRFS - first time, needs encryption

2013-10-29 Thread Duncan
btrfs.nrb posted on Tue, 29 Oct 2013 15:19:19 + as excerpted: > Hi, I would be pleased to get some help after I have looked and not > figured out how this should work: > > Summary === > btrfs device add > Returns - Inappropriate ioctl for device > # btrfs --version > Btrfs Btrfs v0.19

Re: [PATCH] Btrfs: incompatible format change to remove hole extents V2

2013-10-29 Thread Jeff Mahoney
On 10/29/13, 9:56 AM, Josef Bacik wrote: > Btrfs has always had these filler extent data items for holes in inodes. This > has made somethings very easy, like logging hole punches and sending hole > punches. However for large holey files these extent data items are pure > overhead. So add an inc

Re: [patch 00/13] sysfs publishing patchset

2013-10-29 Thread Goffredo Baroncelli
Hi Jeff, On 2013-10-21 23:19, Jeff Mahoney wrote: > This patchset implements the stubbed-out sysfs interface for btrfs. Or > at least begins to do so. > > We publish: > - Features supported by the file system implementation > - Features enabled on the file system, including features unknown to >

Re: [PATCH] Btrfs: incompatible format change to remove hole extents V2

2013-10-29 Thread Josef Bacik
On Tue, Oct 29, 2013 at 02:15:20PM -0400, Jeff Mahoney wrote: > On 10/29/13, 9:56 AM, Josef Bacik wrote: > > Btrfs has always had these filler extent data items for holes in inodes. > > This > > has made somethings very easy, like logging hole punches and sending hole > > punches. However for la

Re: [patch 10/13] btrfs: publish allocation data in sysfs

2013-10-29 Thread Jeff Mahoney
On 10/21/13, 5:19 PM, Jeff Mahoney wrote: > While trying to debug ENOSPC issues, it's helpful to understand what the > kernel's view of the available space is. We export this information > via ioctl, but sysfs files are more easily used. > > Signed-off-by: Jeff Mahoney > --- > fs/btrfs/ctree.h

[PATCH] Btrfs: incompatible format change to remove hole extents V3

2013-10-29 Thread Josef Bacik
Btrfs has always had these filler extent data items for holes in inodes. This has made somethings very easy, like logging hole punches and sending hole punches. However for large holey files these extent data items are pure overhead. So add an incompatible feature to no longer add hole extents t

Re: [PATCH] Btrfs: stop using vfs_read in send

2013-10-29 Thread Zach Brown
Sorry for the latency. I was away last week. On Fri, Oct 25, 2013 at 11:37:53AM -0400, Josef Bacik wrote: > Apparently we don't actually close the files until we return to userspace, so > stop using vfs_read in send. This is actually better for us since we can > avoid > all the extra logic of h

[patch 3/3] xfstests: btrfs/023,024,025: test feature ioctl and sysfs interfaces

2013-10-29 Thread Jeff Mahoney
This tests the exporting of feature information from the kernel via sysfs and ioctl. The first test works whether the sysfs permissions are correct, if the information exported via sysfs matches what the ioctls are reporting, and if they both match the on-disk superblock's version of the feature se

[patch 1/3] xfstests: btrfs/021: test global metadata reservation reporting

2013-10-29 Thread Jeff Mahoney
Btrfs can now report the size of the global metadata reservation via icotl and sysfs. This test confirms that we get sane results on an empty file system. ENOTTY and missing /sys/fs/btrfs//allocation are not considered failures. Signed-off-by: Jeff Mahoney --- common/rc|6 +

[patch 2/3] xfstests: btrfs/022: test sysfs exports of allocation and device membership info

2013-10-29 Thread Jeff Mahoney
This tests the sysfs publishing for btrfs allocation and device membership info under a number of different layouts, similar to the btrfs replace test. We test the allocation files only for existence and that they contain numerical values. We test the device membership by mapping the devices used t

[patch 0/3] xfstests: for btrfs publishing/export patchset (v4)

2013-10-29 Thread Jeff Mahoney
These are the tests that Josef requested accompany the submission of the btrfs publishing/export patchset[1]. 021: Test new global metadata reservation ioctl 022: Test new sysfs exporting of allocation and device membership 023: Test new sysfs exporting of feature bits 024: Test setting/clearing f

[no subject]

2013-10-29 Thread Goffredo Baroncelli
help -- gpg @keyserver.linux.it: Goffredo Baroncelli (kreijackATinwind.it> Key fingerprint BBF5 1610 0B64 DAC6 5F7D 17B2 0EDA 9B37 8B82 E0B5 -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [patch 00/13] sysfs publishing patchset

2013-10-29 Thread Jeff Mahoney
On 10/29/13, 2:25 PM, Goffredo Baroncelli wrote: > Hi Jeff, > > On 2013-10-21 23:19, Jeff Mahoney wrote: >> This patchset implements the stubbed-out sysfs interface for btrfs. Or >> at least begins to do so. >> >> We publish: >> - Features supported by the file system implementation >> - Features

Re: [PATCH] btrfs: add framework to read fs info from btrfs-control

2013-10-29 Thread Zach Brown
> This adds ioctl BTRFS_IOC_GET_FSIDS which reads the fs > info through the btrfs-control Why not use sysfs? > + sz_fslist_arg = sizeof(*fslist_arg); > + fslist_arg = memdup_user(arg, sz_fslist_arg); Doesn't check allocation failure. > + > + sz_fslist = sizeof(*fslist) * fslist_arg

Re: [patch 00/13] sysfs publishing patchset

2013-10-29 Thread Goffredo Baroncelli
Hi Jeff On 2013-10-29 21:26, Jeff Mahoney wrote: >> This for two reasons: >> > 1) so it would be possible to show also the disks informations under a >> > dev/ directory. It would be possible to handle the case that some disks >> > are registered in btrfs but the related filesystems aren't mounted

Re: memory leak in <=3.11.6

2013-10-29 Thread Jérôme Poulin
On Tue, Oct 29, 2013 at 12:42 PM, Duncan <1i5t5.dun...@cox.net> wrote: > > So I'd call the qgroups feature broken at this time I agree. I made a page about Quotas on the wiki so to document my findings as documentation is really sparse. If you consult the section Known issues, you will find those:

Re: memory leak in <=3.11.6

2013-10-29 Thread Kai Krakow
Jérôme Poulin schrieb: >> If I close all my desktop programs, my system stays at +12 GB RAM usage >> while after a fresh boot it has 12+ GB free (of 16 GB). Cache stays low >> at 2 GB while after a few minutes uptime cache is about 5 GB. > > I probably have the same problem over here, after abou

Re: memory leak in <=3.11.6

2013-10-29 Thread Kai Krakow
Tomasz Chmielewski schrieb: >> I probably have the same problem over here, after about 2 weeks of >> random read/write it seems my memory and swap get almost full and even >> after killing all process and getting in single user mode, memory >> won't free up. Would you happen to have quota enable

Re: memory leak in <=3.11.6

2013-10-29 Thread Wang Shilong
On 10/30/2013 06:46 AM, Jérôme Poulin wrote: On Tue, Oct 29, 2013 at 12:42 PM, Duncan <1i5t5.dun...@cox.net> wrote: So I'd call the qgroups feature broken at this time I agree. I made a page about Quotas on the wiki so to document my findings as documentation is really sparse. If you consult th

[PATCH] Btrfs: fix a crash when running balance and defrag concurrently

2013-10-29 Thread Liu Bo
Running balance and defrag concurrently can end up with a crash: kernel BUG at fs/btrfs/relocation.c:4528! RIP: 0010:[] [] btrfs_reloc_cow_block+ 0x1eb/0x230 [btrfs] Call Trace: [] ? update_ref_for_cow+0x241/0x380 [btrfs] [] ? copy_extent_buffer+0xad/0x110 [btrfs] [] __btrfs_cow_block+0x3a