Re: [PATCH v2] Btrfs: fix btrfs boot when compiled as built-in

2014-02-01 Thread Ahmet Inan
There is still a problem when btrfs is built-in: err = btrfs_hash_init(); Will not succeed if run on an slow cpu (intel u7300) or in qemu if btrfs is built-in: # qemu-kvm -enable-kvm -usbdevice tablet -m 2048 -smp 2 -sdl -kernel /usr/src/linux/arch/x86/boot/bzImage But it works, when btrfs is a

Re: [PATCH v2] Btrfs: fix btrfs boot when compiled as built-in

2014-02-01 Thread Ahmet Inan
okay, putting late_initcall instead of module_init fixes it for me, but this is something you guys should decide how to handle: //module_init(init_btrfs_fs) late_initcall(init_btrfs_fs); Ahmet -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to ma

Re: [PATCH v2] Btrfs: fix btrfs boot when compiled as built-in

2014-02-01 Thread Filipe David Manana
On Sat, Feb 1, 2014 at 10:29 AM, Ahmet Inan wrote: > okay, putting late_initcall instead of module_init fixes it for me, > but this is something you guys should decide how to handle: > > //module_init(init_btrfs_fs) > late_initcall(init_btrfs_fs); Thanks for reporting and testing Ahmet. I tried

Re: [PATCH v2] Btrfs: fix btrfs boot when compiled as built-in

2014-02-01 Thread Filipe David Manana
On Sat, Feb 1, 2014 at 5:25 PM, Ahmet Inan wrote: >> I tried late_initcall too, both when built as a module and as >> built-in. Seems to work too on my hardware. > On my i3 (avx) and i7 (avx2) systems it works well too. > Havent tested other, faster pre avx systems, besides that intel u7300 > syst

Re: [PATCH v2] Btrfs: fix btrfs boot when compiled as built-in

2014-02-01 Thread Ahmet Inan
>> err = btrfs_hash_init(); > Did you find out what err's value was? Its -2 Ahmet -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] Btrfs: use late_initcall instead of module_init

2014-02-01 Thread Filipe David Borba Manana
It seems that when init_btrfs_fs() is called, crc32c/crc32c-intel might not always be already initialized, which results in the call to crypto_alloc_shash() returning -ENOENT, as experienced by Ahmet who reported this. Therefore make sure init_btrfs_fs() is called after crc32c is initialized (whi

Re: [PATCH v2] Btrfs: fix btrfs boot when compiled as built-in

2014-02-01 Thread Filipe David Manana
On Sat, Feb 1, 2014 at 7:42 PM, Ahmet Inan wrote: >>> err = btrfs_hash_init(); >> Did you find out what err's value was? > Its -2 Thanks, that was very helpful Ahmet. > > Ahmet -- Filipe David Manana, "Reasonable men adapt themselves to the world. Unreasonable men adapt the world to themse

Re: [GIT PULL] Btrfs

2014-02-01 Thread David Rientjes
On Thu, 30 Jan 2014, Chris Mason wrote: > > Hi Linus > > Please pull my for-linus branch: > > git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus > > There are two conflicts right now, one with the ACL code (pick your > version) and one with Kent's changes in the bloc

Re: [GIT PULL] Btrfs

2014-02-01 Thread Filipe David Manana
On Sun, Feb 2, 2014 at 12:15 AM, David Rientjes wrote: > On Thu, 30 Jan 2014, Chris Mason wrote: > >> >> Hi Linus >> >> Please pull my for-linus branch: >> >> git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git for-linus >> >> There are two conflicts right now, one with the ACL cod

Re: [GIT PULL] Btrfs

2014-02-01 Thread David Rientjes
On Sun, 2 Feb 2014, Filipe David Manana wrote: > >> Btrfs: fix btrfs boot when compiled as built-in (+73/-9) > > > > This one, 14a958e678cd ("Btrfs: fix btrfs boot when compiled as > > built-in"), breaks the build if CONFIG_LIBCRC32C=m: > > > > fs/built-in.o: In function `btrfs_check_super_csu