[PATCH] btrfs: replace simple_strtoul() with kstrtoul()

2014-05-12 Thread Zhang Zhen
use the newer and more pleasant kstrtoul() to replace simple_strtoul(), because simple_strtoul() is marked for obsoletion. Signed-off-by: Zhang Zhen zhenzhang.zh...@huawei.com --- fs/btrfs/ioctl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/btrfs/ioctl.c

Re: [PATCH] btrfs: replace simple_strtoul() with kstrtoul()

2014-05-12 Thread David Taylor
On Mon, 12 May 2014, Zhang Zhen wrote: use the newer and more pleasant kstrtoul() to replace simple_strtoul(), because simple_strtoul() is marked for obsoletion. [...] - devid = simple_strtoull(devstr, end, 10); + devid = kstrtoul(devstr, end, 10); kstrtoul

Inquiry about your products,

2014-05-12 Thread Kwesi Global Limited
Dear Sir/Madam, My name is Mr. Agyemang Kwesi. I am the Proprietor of Kwesi Global Limited. My office address is at NTHC Residential Area, Comm. 14, Tema, Ghana. I am doing import/export business since 1998 with my wife. We also represent some foreign companies in Ghana. We found posts about

send/receive and bedup

2014-05-12 Thread Scott Middleton
Hi Everyone History: I just recently discovered BtrFS. Well really only just started reading a lot about it. Starting with blogs by Jim Salters and Marc Merlin. So, thanks for those blogs guys. This also introduced me to ZoL (ZFS). It seemed a bit more stable but one of the features I really

Re: [PATCH] btrfs-progs: doc: link btrfsck to btrfs-check

2014-05-12 Thread David Sterba
On Thu, May 08, 2014 at 09:40:03AM +0800, Qu Wenruo wrote: Original Message Subject: Re: [PATCH] btrfs-progs: doc: link btrfsck to btrfs-check From: David Sterba dste...@suse.cz To: Qu Wenruo quwen...@cn.fujitsu.com Date: 2014年04月18日 22:48 On Thu, Apr 17, 2014 at 08:47:28AM

Re: superfluous else if ()

2014-05-12 Thread David Sterba
On Fri, May 09, 2014 at 07:12:54PM +0200, Toralf Förster wrote: But what came into my mind, wouldn't the following avoid such question in future ? : Yes and though it's a tiny change, I don't mind a patch for that. } else { /* ret 0 */ The comment is IMHO

Re: [PATCH 1/3] btrfs: return errno instead of -1 from compression

2014-05-12 Thread David Sterba
On Fri, May 09, 2014 at 01:40:15PM -0700, Zach Brown wrote: @@ -335,7 +335,7 @@ cont: break; if (page_in_index + 1 = total_pages_in) { - ret = -1; + ret =

Re: Fwd: [suggestion] Add verbose notification about inode-cache rebuild to kernel log

2014-05-12 Thread David Sterba
On Fri, May 09, 2014 at 08:12:54PM +0200, Goffredo Baroncelli wrote: Adding the printk is probably a good thing, but I'd rather reconsider using inode_cache at all. IMO it's supposed to fix problems with inode numbers that we don't have. IIRC, the problem is for the 32 bit system, were

Re: [PATCH 3/3] btrfs: fix inline compressed read err corruption

2014-05-12 Thread Liu Bo
On Thu, May 08, 2014 at 07:16:19PM -0400, Zach Brown wrote: uncompress_inline() is silently dropping an error from btrfs_decompress() after testing it and zeroing the page that was supposed to hold decompressed data. This can silently turn compressed inline data in to zeros if decompression

Re: Sending incremental backup causes deadlock (3.14.3)

2014-05-12 Thread Josef Bacik
On 05/10/2014 04:04 AM, Chris Samuel wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Josef, On Fri, 9 May 2014 01:22:27 PM Josef Bacik wrote: Known problem, fixed in 3.15-rc1. Thanks, Is the fix suitable for -stable too? Unfortunately no, it's too big. I had thought about

Re: -musage=0 means always reporting relocation

2014-05-12 Thread David Sterba
On Sun, May 11, 2014 at 04:11:56PM +0200, Brendan Hide wrote: On 2014/05/11 11:52 AM, Russell Coker wrote: On Sun, 11 May 2014, Russell Coker russ...@coker.com.au wrote: Below is the output of running a balance a few times on a 120G SSD. Sorry forgot to mention that's kernel 3.14.1 Debian

Re: known UUID and metadata consistency

2014-05-12 Thread David Sterba
On Sun, May 11, 2014 at 10:10:41AM +0100, Hugo Mills wrote: a) The chunk tree is whole and consistent b) We need to (or have been asked to) rebuild the chunk tree from scratch So I think, yes, you can make fake metadata blocks, but you have to rely on either (a) your fake data being

Re: [PATCH 3/3] btrfs: fix inline compressed read err corruption

2014-05-12 Thread David Sterba
On Mon, May 12, 2014 at 11:00:23PM +0800, Liu Bo wrote: On Thu, May 08, 2014 at 07:16:19PM -0400, Zach Brown wrote: uncompress_inline() is silently dropping an error from btrfs_decompress() after testing it and zeroing the page that was supposed to hold decompressed data. This can silently

Re: Fwd: [suggestion] Add verbose notification about inode-cache rebuild to kernel log

2014-05-12 Thread Goffredo Baroncelli
Hi David, On 05/12/2014 04:39 PM, David Sterba wrote: Because most modern hardware is 64 bit (with the exception of ARM ?), could be make sense to allow btrfs to work without inode_cache only on 64bit, loosing the possibility to be used on 32 bit system. Instead when the inode_cache is

Re: 3.15-rc5 btrfs send/receive corruption errors? Does scrub warn of silent corruption?

2014-05-12 Thread Marc MERLIN
On Sat, May 10, 2014 at 04:57:18PM -0700, Marc MERLIN wrote: On Sat, May 10, 2014 at 03:42:49PM -0700, Marc MERLIN wrote: I tried with 3.14.3 and it went further, however it died with legolas:/mnt/btrfs_pool2# btrfs send home_ro.20140507_10:00:01 | btrfs receive /mnt/btrfs_pool1/ At

Re: [PATCH] btrfs: replace simple_strtoul() with kstrtoul()

2014-05-12 Thread Zhang Zhen
On 2014/5/12 19:28, David Taylor wrote: On Mon, 12 May 2014, Zhang Zhen wrote: use the newer and more pleasant kstrtoul() to replace simple_strtoul(), because simple_strtoul() is marked for obsoletion. [...] -devid = simple_strtoull(devstr, end, 10); +devid =

[PATCH] btrfs: replace simple_strtoul() with kstrtoul()

2014-05-12 Thread Zhang Zhen
use the newer and more pleasant kstrtoul() to replace simple_strtoul(), because simple_strtoul() is marked for obsoletion. Signed-off-by: Zhang Zhen zhenzhang.zh...@huawei.com --- fs/btrfs/ioctl.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/fs/btrfs/ioctl.c

Re: Fwd: [suggestion] Add verbose notification about inode-cache rebuild to kernel log

2014-05-12 Thread Duncan
Goffredo Baroncelli posted on Mon, 12 May 2014 20:18:04 +0200 as excerpted: Finally I have a question: it is possible to disable inode_cache ? what means the flag noinode_cache ? It means disable the inode cache at all, or only avoid to store on disk the inode cache ? Unlike space_cache,