SSD mode on hybrid disk (SSHD)

2015-06-10 Thread Federico Pedemonte
Hi all, I've replaced my notebook HDD with an SSHD hybrid disk (Seagate ST1000LM). contrary to my experience with other similar machines, the disk performance are really poor. I suspect that it depends on btrfs detecting it as an SSD disk (according to this dmesg message): BTRFS: detected SSD de

Re: rw-mount-problem after raid1-failure

2015-06-10 Thread Anand Jain
On 06/10/2015 02:58 PM, Martin wrote: Hello Anand, the mount -o degraded <-- this should work is my problem. The fist times it works but suddently, after a reboot, it fails with message "BTRFS: too many missing devices, writeable mount is not allowed" in kernel log. the failed(ing) dis

Re: SSD mode on hybrid disk (SSHD)

2015-06-10 Thread Qu Wenruo
Hi all, I've replaced my notebook HDD with an SSHD hybrid disk (Seagate ST1000LM). contrary to my experience with other similar machines, the disk performance are really poor. I suspect that it depends on btrfs detecting it as an SSD disk (according to this dmesg message): BTRFS: detected SSD d

Re: block: add a bi_error field to struct bio

2015-06-10 Thread Christoph Hellwig
On Thu, Jun 04, 2015 at 11:31:07AM -0400, Mike Snitzer wrote: > This patch _really_ concerns me because just in DM alone I found you > took liberties that you shouldn't have and created a regression. First > issue is a real bug (your proposed dm-io.c:dmio_complete change missed > that dm-io uses e

Re: [RFC PATCH 2/2] Btrfs: improve fsync for nocow file

2015-06-10 Thread Filipe David Manana
On Wed, Jun 10, 2015 at 3:09 AM, Liu Bo wrote: > On Tue, Jun 09, 2015 at 01:56:41PM +0100, Filipe David Manana wrote: >> On Tue, Jun 9, 2015 at 1:04 PM, Liu Bo wrote: >> > If we're overwriting an allocated file without changing timestamp >> > and inode version, and the file is with NODATACOW, we

Re: [dm-devel] [PATCH] block: add a bi_error field to struct bio

2015-06-10 Thread Christoph Hellwig
On Wed, Jun 10, 2015 at 12:50:54PM +1000, Neil Brown wrote: > This introduces a use-after-free. put_buf(r1_bio) can result in bio_put on > 'bio'. > It is safe to move the put_buf call after the md_done_sync(), but it is > probably best to leave the 'update' variable as it. i.e. Just change: > >

Re: SSD mode on hybrid disk (SSHD)

2015-06-10 Thread Federico Pedemonte
On Wed, Jun 10, 2015 at 9:47 AM, Qu Wenruo wrote: > Hi, > > You can try nossd mount option (mount DEV MNT -o nossd), which will disable > ssd related optimization. thanks Qu! I've tried it, but the disk still seems slow as hell. > But according to my experience, even enable ssd mode on HDD, per

Re: [PATCH 5/5] Btrfs: incremental send, fix rmdir not send utimes

2015-06-10 Thread Robbie Ko
Hi Filipi, 2015-06-09 18:36 GMT+08:00 Filipe David Manana : > On Tue, Jun 9, 2015 at 11:04 AM, Robbie Ko wrote: >> Hi Filipe, >> >> 2015-06-08 22:00 GMT+08:00 Filipe David Manana : >>> On Mon, Jun 8, 2015 at 4:44 AM, Robbie Ko wrote: Hi Filipe, >>> >>> Hi Robbie, >>> I've fixed "d

Re: deleting a btrfs subvolume shut up a server

2015-06-10 Thread Liu Bo
On Thu, May 14, 2015 at 02:16:58PM +0200, Toralf Förster wrote: > I created at a 3 TB btrfs formatted disk a btrfs subvolume, unpacked a > minimal Gentoo Linux in it, created in addition few files within it under > ./tmp and bind mount from the host few files onto those files. If I now > delete

Re: [PATCH] Btrfs: fix hang during inode eviction due to concurrent readahead

2015-06-10 Thread Liu Bo
On Tue, May 26, 2015 at 12:55:42AM +0100, fdman...@kernel.org wrote: > From: Filipe Manana > > Zygo Blaxell and other users have reported occasional hangs while an > inode is being evicted, leading to traces like the following: > > [ 5281.972322] INFO: task rm:20488 blocked for more than 120 sec

Re: [PATCH] Btrfs: fix hang during inode eviction due to concurrent readahead

2015-06-10 Thread Filipe Manana
On Wed, Jun 10, 2015 at 11:41 AM, Liu Bo wrote: > On Tue, May 26, 2015 at 12:55:42AM +0100, fdman...@kernel.org wrote: >> From: Filipe Manana >> >> Zygo Blaxell and other users have reported occasional hangs while an >> inode is being evicted, leading to traces like the following: >> >> [ 5281.97

Re: [PATCH] Btrfs: fix hang during inode eviction due to concurrent readahead

2015-06-10 Thread Liu Bo
On Wed, Jun 10, 2015 at 11:44:17AM +0100, Filipe Manana wrote: > On Wed, Jun 10, 2015 at 11:41 AM, Liu Bo wrote: > > On Tue, May 26, 2015 at 12:55:42AM +0100, fdman...@kernel.org wrote: > >> From: Filipe Manana > >> > >> Zygo Blaxell and other users have reported occasional hangs while an > >> in

Re: [PATCH] Btrfs: fix hang during inode eviction due to concurrent readahead

2015-06-10 Thread Filipe Manana
On Wed, Jun 10, 2015 at 12:05 PM, Liu Bo wrote: > On Wed, Jun 10, 2015 at 11:44:17AM +0100, Filipe Manana wrote: >> On Wed, Jun 10, 2015 at 11:41 AM, Liu Bo wrote: >> > On Tue, May 26, 2015 at 12:55:42AM +0100, fdman...@kernel.org wrote: >> >> From: Filipe Manana >> >> >> >> Zygo Blaxell and oth

[PATCH] Btrfs: fix race between balance and unused block group deletion

2015-06-10 Thread fdmanana
From: Filipe Manana We have a race between deleting an unused block group and balancing the same block group that leads to an assertion failure/BUG(), producing the following assertion failure/BUG_ON(): [181631.208236] BTRFS: assertion failed: 0, file: fs/btrfs/volumes.c, line: 2622 [181631.2205

Re: [PATCH] Btrfs: fix hang during inode eviction due to concurrent readahead

2015-06-10 Thread Liu Bo
On Wed, Jun 10, 2015 at 12:12:11PM +0100, Filipe Manana wrote: > On Wed, Jun 10, 2015 at 12:05 PM, Liu Bo wrote: > > On Wed, Jun 10, 2015 at 11:44:17AM +0100, Filipe Manana wrote: > >> On Wed, Jun 10, 2015 at 11:41 AM, Liu Bo wrote: > >> > On Tue, May 26, 2015 at 12:55:42AM +0100, fdman...@kernel

[PATCH] btrfs: Update out-of-date "skip parity stripe" comment

2015-06-10 Thread Zhaolei
From: Zhao Lei Because btrfs support scrub raid56 parity stripe now. Signed-off-by: Zhao Lei --- fs/btrfs/scrub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/btrfs/scrub.c b/fs/btrfs/scrub.c index a13f91a..5ee5630 100644 --- a/fs/btrfs/scrub.c +++ b/fs/btrfs/scrub.c

Re: [PATCH] Btrfs: fix hang during inode eviction due to concurrent readahead

2015-06-10 Thread Filipe Manana
On Wed, Jun 10, 2015 at 12:27 PM, Liu Bo wrote: > On Wed, Jun 10, 2015 at 12:12:11PM +0100, Filipe Manana wrote: >> On Wed, Jun 10, 2015 at 12:05 PM, Liu Bo wrote: >> > On Wed, Jun 10, 2015 at 11:44:17AM +0100, Filipe Manana wrote: >> >> On Wed, Jun 10, 2015 at 11:41 AM, Liu Bo wrote: >> >> > On

[PATCH] Btrfs: fix a comment in inode.c:evict_inode_truncate_pages()

2015-06-10 Thread fdmanana
From: Filipe Manana The comment was not correct about the part where it says the endio callback of the bio might have not yet been called - update it to mention that by that time the endio callback execution might still be in progress only. Signed-off-by: Filipe Manana --- fs/btrfs/inode.c | 5

Re: rw-mount-problem after raid1-failure

2015-06-10 Thread Martin
Hello Anand, the failed disk was removed. My procedure was the following: - I found some write errors in the kernel log, so - I shutdown the system - I removed the failed disk - I powered on the system - I mounted the remaining disk degraded,rw (works OK) - the system works an and was reboo

Re: [RFC PATCH 2/2] Btrfs: improve fsync for nocow file

2015-06-10 Thread Filipe David Manana
On Wed, Jun 10, 2015 at 9:26 AM, Filipe David Manana wrote: > On Wed, Jun 10, 2015 at 3:09 AM, Liu Bo wrote: >> On Tue, Jun 09, 2015 at 01:56:41PM +0100, Filipe David Manana wrote: >>> On Tue, Jun 9, 2015 at 1:04 PM, Liu Bo wrote: >>> > If we're overwriting an allocated file without changing ti

Re: [RFC PATCH 2/2] Btrfs: improve fsync for nocow file

2015-06-10 Thread Liu Bo
On Wed, Jun 10, 2015 at 01:45:29PM +0100, Filipe David Manana wrote: > On Wed, Jun 10, 2015 at 9:26 AM, Filipe David Manana > wrote: > > On Wed, Jun 10, 2015 at 3:09 AM, Liu Bo wrote: > >> On Tue, Jun 09, 2015 at 01:56:41PM +0100, Filipe David Manana wrote: > >>> On Tue, Jun 9, 2015 at 1:04 PM,

Re: [PATCH] Btrfs: fix hang during inode eviction due to concurrent readahead

2015-06-10 Thread Liu Bo
On Wed, Jun 10, 2015 at 12:51:15PM +0100, Filipe Manana wrote: > On Wed, Jun 10, 2015 at 12:27 PM, Liu Bo wrote: > > On Wed, Jun 10, 2015 at 12:12:11PM +0100, Filipe Manana wrote: > >> On Wed, Jun 10, 2015 at 12:05 PM, Liu Bo wrote: > >> > On Wed, Jun 10, 2015 at 11:44:17AM +0100, Filipe Manana w

Re: [PATCH] Btrfs: fix a comment in inode.c:evict_inode_truncate_pages()

2015-06-10 Thread Liu Bo
On Wed, Jun 10, 2015 at 01:02:12PM +0100, fdman...@kernel.org wrote: > From: Filipe Manana > > The comment was not correct about the part where it says the endio > callback of the bio might have not yet been called - update it > to mention that by that time the endio callback execution might > st

Re: block: add a bi_error field to struct bio

2015-06-10 Thread Mike Snitzer
On Wed, Jun 10 2015 at 4:11am -0400, Christoph Hellwig wrote: > On Thu, Jun 04, 2015 at 11:31:07AM -0400, Mike Snitzer wrote: > > This patch _really_ concerns me because just in DM alone I found you > > took liberties that you shouldn't have and created a regression. First > > issue is a real b

Re: block: add a bi_error field to struct bio

2015-06-10 Thread Mike Snitzer
On Wed, Jun 10 2015 at 11:26am -0400, Mike Snitzer wrote: > On Wed, Jun 10 2015 at 4:11am -0400, > Christoph Hellwig wrote: > > > On Thu, Jun 04, 2015 at 11:31:07AM -0400, Mike Snitzer wrote: > > > This patch _really_ concerns me because just in DM alone I found you > > > took liberties that y

Re: block: add a bi_error field to struct bio

2015-06-10 Thread Christoph Hellwig
On Wed, Jun 10, 2015 at 12:01:12PM -0400, Mike Snitzer wrote: > > I'll queue a patch to rename 'error' to 'error_bits' where appropriate. > > See: > https://git.kernel.org/cgit/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=for-next&id=f368f463e4cef696ad6b102dbaf5c10dfca7cc63 Can we wait

Re: block: add a bi_error field to struct bio

2015-06-10 Thread Mike Snitzer
On Wed, Jun 10 2015 at 12:04pm -0400, Christoph Hellwig wrote: > On Wed, Jun 10, 2015 at 12:01:12PM -0400, Mike Snitzer wrote: > > > I'll queue a patch to rename 'error' to 'error_bits' where appropriate. > > > > See: > > https://git.kernel.org/cgit/linux/kernel/git/device-mapper/linux-dm.git/c

Re: block: add a bi_error field to struct bio

2015-06-10 Thread anup modak
So Is it safe to use raid 6 with btrfs for home storage now? I will have backup on ZFS. On Wed, Jun 10, 2015 at 11:50 AM, Mike Snitzer wrote: > On Wed, Jun 10 2015 at 12:04pm -0400, > Christoph Hellwig wrote: > >> On Wed, Jun 10, 2015 at 12:01:12PM -0400, Mike Snitzer wrote: >> > > I'll queue a

[PATCH] btrfs-progs: make receive work inside of subvolumes

2015-06-10 Thread Josef Bacik
Kind of a big feature of btrfs is being able to have a default subvol. However the receive code generates the paths to the subvols from the root of the fs, even in the case of a default subvol. So instead figure out if we're inside of a subvol, either because we have a different default or we've

Re: [GIT PULL] Qgroup rework with other Fujitsu fix.

2015-06-10 Thread Chris Mason
On 06/07/2015 11:06 PM, Qu Wenruo wrote: > Hi Chris, > > Please pull the 19 patchset from my branch for_chris_4.2. > We have tested it in a week. > > Although it is originally based on 4.1-rc5, not the integration branch. > Quick tests shows no new bugs, although we will rerun the full test, > I'

[RESEND][PATCH] btrfs: Align EOF length to block in extent_same

2015-06-10 Thread Mark Fasheh
Hi, Can this patch please be considered for upstream inclusion? I reviewed it myself and have tested it on a few files with an updated duperemove branch: https://github.com/markfasheh/duperemove/tree/alignment_fix as described below, this allows us to dedupe the tail extents of files whose size

Re: [PATCH 3/3] btrfs: add missing discards when unpinning extents with -o discard

2015-06-10 Thread Jeff Mahoney
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 6/9/15 8:05 PM, Jeff Mahoney wrote: > On 6/9/15 4:48 PM, Jeff Mahoney wrote: >> On 6/8/15 10:12 AM, Filipe David Manana wrote: >>> Running the following in a loop until it returns failure ($? >>> != 0) triggers an apparent corruption issue most of t

Re: "@" prefix in subvolume paths

2015-06-10 Thread Hugo Mills
On Tue, Jun 09, 2015 at 07:55:05PM +0200, pu...@xs4all.nl wrote: > Hi, > > I've noticed this "@" sign in the subvolume's path with SLES12. I'm > wondering what is its purpose. openSUSE 13.2 doesn't seem to be using > it. They created a subvolume called "@" and then put all the other subvolumes

Re: "@" prefix in subvolume paths

2015-06-10 Thread gny
I see... quite underwhelming explanation :-) I thought there is some special trick here. Thanks, Gábor On Wed, 10 Jun 2015 23:10:14 + Hugo Mills wrote: > On Tue, Jun 09, 2015 at 07:55:05PM +0200, pu...@xs4all.nl wrote: > > Hi, > > > > I've noticed this "@" sign in the subvolume's path w

Re: rw-mount-problem after raid1-failure

2015-06-10 Thread Anand Jain
> On 10 Jun 2015, at 5:35 pm, Martin wrote: > > Hello Anand, > > the failed disk was removed. My procedure was the following: > > - I found some write errors in the kernel log, so > - I shutdown the system > - I removed the failed disk > - I powered on the system > - I mounted the remaining d

Does raid56 work on latest kernel?

2015-06-10 Thread Guilherme Gonçalves
Hello!, use arch linux with the latest kernel, i am trying to do raid 5 on 3 devices, but i get this on btfs fi usage: "WARNING: RAID56 detected, not implemented" what is not implemented? full output: WARNING: RAID56 detected, not implemented WARNING: RAID56 detected, not implemented WARNING:

Re: "@" prefix in subvolume paths

2015-06-10 Thread Jeff Mahoney
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 6/10/15 7:10 PM, Hugo Mills wrote: > On Tue, Jun 09, 2015 at 07:55:05PM +0200, pu...@xs4all.nl wrote: >> Hi, >> >> I've noticed this "@" sign in the subvolume's path with SLES12. >> I'm wondering what is its purpose. openSUSE 13.2 doesn't seem to >

RE: [PATCH 0/4] Btrfs: RAID 5/6 missing device replace

2015-06-10 Thread Zhao Lei
Hi, Omar Sandoval I tested this patchset with my script, but see general protection fault again. NODE: kvm with virtio disk ROOTFS: RHEL6 with btrfs-progs v4.0 KERNEL: v4.1-rc6 with 4 patchs in this patchset Maybe my test have small different with yours, but it seems is similar bug, could you che

Re: Does raid56 work on latest kernel?

2015-06-10 Thread Duncan
Guilherme Gonçalves posted on Wed, 10 Jun 2015 21:05:38 -0300 as excerpted: > Hello!, use arch linux with the latest kernel, i am trying to do raid 5 > on 3 devices, but i get this on btfs fi usage: > > "WARNING: RAID56 detected, not implemented" > > what is not implemented? That warning is pu

Re: [btrfs:integration-4.2 29/57] fs/btrfs/disk-io.c:2325:17-30: ERROR: reference preceded by free on line 2324

2015-06-10 Thread Julia Lawall
This does not look correct. Please check. julia On Thu, 11 Jun 2015, kbuild test robot wrote: > TO: Liu Bo > CC: "Chris Mason Chris Mason" > CC: David Sterba > CC: linux-btrfs@vger.kernel.org > > tree: git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git > integration-4.2

Re: [PATCH 0/4] Btrfs: RAID 5/6 missing device replace

2015-06-10 Thread Omar Sandoval
On Thu, Jun 11, 2015 at 11:52:30AM +0800, Zhao Lei wrote: > Hi, Omar Sandoval > > I tested this patchset with my script, but see general protection fault > again. > NODE: kvm with virtio disk > ROOTFS: RHEL6 with btrfs-progs v4.0 > KERNEL: v4.1-rc6 with 4 patchs in this patchset > > Maybe my test

Re: [btrfs:integration-4.2 29/57] fs/btrfs/disk-io.c:2325:17-30: ERROR: reference preceded by free on line 2324

2015-06-10 Thread Liu Bo
On Thu, Jun 11, 2015 at 08:07:09AM +0200, Julia Lawall wrote: > This does not look correct. Please check. Oops, thanks for pointing it out. Sorry for my miss, here is the fix. (Chris, if you prefer me to fold this into the original patch, I'll do it.) Thanks, -liubo >From de72ac1c6612441bd5e

Re: [btrfs:integration-4.2 29/57] fs/btrfs/disk-io.c:2325:17-30: ERROR: reference preceded by free on line 2324

2015-06-10 Thread Liu Bo
On Thu, Jun 11, 2015 at 02:23:20PM +0800, Liu Bo wrote: > On Thu, Jun 11, 2015 at 08:07:09AM +0200, Julia Lawall wrote: > > This does not look correct. Please check. > > Oops, thanks for pointing it out. > > Sorry for my miss, here is the fix. > > (Chris, if you prefer me to fold this into the