[PATCH] Btrfs: fix read corruption of compressed and shared extents

2015-09-14 Thread fdmanana
From: Filipe Manana If a file has a range pointing to a compressed extent, followed by another range that points to the same compressed extent and a read operation attempts to read both ranges (either completely or part of them), the pages that correspond to the second range are incorrectly fille

[PATCH] fstests: regression test for btrfs read corruption of compressed extents

2015-09-14 Thread fdmanana
From: Filipe Manana Regression test for file read corruption when using compressed extents that are shared by multiple consecutive ranges of the same file. The btrfs issue is fixed by the linux kernel patch titled: "Btrfs: fix read corruption of compressed and shared extents" Without the corres

Re: [PATCH] Btrfs: fix read corruption of compressed and shared extents

2015-09-14 Thread Qu Wenruo
Hi Filepe, wrote on 2015/09/14 09:29 +0100: From: Filipe Manana If a file has a range pointing to a compressed extent, followed by another range that points to the same compressed extent and a read operation attempts to read both ranges (either completely or part of them), the pages that corr

Re: [PATCH] Btrfs: fix read corruption of compressed and shared extents

2015-09-14 Thread Filipe Manana
On Mon, Sep 14, 2015 at 10:08 AM, Qu Wenruo wrote: > Hi Filepe, > > > wrote on 2015/09/14 09:29 +0100: >> >> From: Filipe Manana >> >> If a file has a range pointing to a compressed extent, followed by >> another range that points to the same compressed extent and a read >> operation attempts to

Re: [PATCH] Btrfs: fix read corruption of compressed and shared extents

2015-09-14 Thread Qu Wenruo
Filipe Manana wrote on 2015/09/14 10:22 +0100: On Mon, Sep 14, 2015 at 10:08 AM, Qu Wenruo wrote: Hi Filepe, wrote on 2015/09/14 09:29 +0100: From: Filipe Manana If a file has a range pointing to a compressed extent, followed by another range that points to the same compressed extent

Re: unable to mount multi disk volume with recovery mode

2015-09-14 Thread Anand Jain
Hi Qu, Unfortunately, single mode means no duplication. And degrade mount only works for RAID level with duplication(DUP,RAID1/5/6/10). further to the below commit. commit 95669976bd7d30ae265db938ecb46a6b7f8cb893 Btrfs: don't consider the missing device when allocating new chunks in c

kernel BUG at linux-4.2.0/fs/btrfs/extent-tree.c:1833 on rebalance

2015-09-14 Thread Stéphane Lesimple
Hello btrfs-aholics, I've been experiencing repetitive "kernel BUG" occurences in the past few days trying to balance a raid5 filesystem after adding a new drive. It occurs on both 4.2.0 and 4.1.7, using 4.2 userspace tools. The raid5 setup was 2x4T drives (created 3 days ago to upgrade smooth

Re: [PATCH 00/39] drop null test before destroy functions

2015-09-14 Thread SF Markus Elfring
> Recent commits to kernel/git/torvalds/linux.git have made the following > functions able to tolerate NULL arguments: > > kmem_cache_destroy (commit 3942d29918522) > mempool_destroy (commit 4e3ca3e033d1) > dma_pool_destroy (commit 44d7175da6ea) How do you think about to extend an other SmPL scrip

Re: [PATCH] Btrfs: fix read corruption of compressed and shared extents

2015-09-14 Thread Chris Mason
On Mon, Sep 14, 2015 at 05:34:02PM +0800, Qu Wenruo wrote: > >>And in your case: > >>(With a little modification, decompressed length is 32K now) > >> File layout > >> [0 - 8K] [8K - 24K] > >> | | > >> |

Re: [PATCH v3 0/9] Btrfs: free space B-tree

2015-09-14 Thread Holger Hoffstätte
On 09/14/15 08:04, Omar Sandoval wrote: > I went back and fixed the issues that came up since v2. Changes below. I > removed Josef's Reviewed-by on patch 9 because it was completely > rewritten to change the mount options like Dave suggested. These are > still based on 4.2 I decided to take one fo

Re: [PATCH v3 0/9] Btrfs: free space B-tree

2015-09-14 Thread Austin S Hemmelgarn
On 2015-09-14 02:04, Omar Sandoval wrote: Hi, everyone, I went back and fixed the issues that came up since v2. Changes below. I removed Josef's Reviewed-by on patch 9 because it was completely rewritten to change the mount options like Dave suggested. These are still based on 4.2 Thanks! Chan

Horrible dbench performance

2015-09-14 Thread Liu Bo
Hi, Both [1] and [2] had run dbench on btrfs with fast storage, and showed bad numbers, I got an impression that after refractoring btree lock to smart rwlock, we have mitigated this issue.. Not got a fast-enough ssd handy, does anyone confirm the result showed in those link? [1]:https://lkml.o

Re: Horrible dbench performance

2015-09-14 Thread Josef Bacik
On 09/14/2015 11:28 AM, Liu Bo wrote: Hi, Both [1] and [2] had run dbench on btrfs with fast storage, and showed bad numbers, I got an impression that after refractoring btree lock to smart rwlock, we have mitigated this issue.. Not got a fast-enough ssd handy, does anyone confirm the result sh

Re: [PATCH v1 0/8] VFS: In-kernel copy system call

2015-09-14 Thread Andy Lutomirski
On Sep 13, 2015 4:25 PM, "Dave Chinner" wrote: > > On Tue, Sep 08, 2015 at 04:08:43PM -0700, Andy Lutomirski wrote: > > Can we have a clean way to figure out whether two file ranges are the > > same in a way that allows false negatives? I.e. return 1 if the > > ranges are reflinks of each other a

Re: [PATCH v2 10/9] copy_file_range.2: New page documenting copy_file_range()

2015-09-14 Thread Darrick J. Wong
On Sun, Sep 13, 2015 at 09:50:18AM +0200, Michael Kerrisk (man-pages) wrote: > Hi Anna, > > On 09/11/2015 10:30 PM, Anna Schumaker wrote: > > copy_file_range() is a new system call for copying ranges of data > > completely in the kernel. This gives filesystems an opportunity to > > implement some

Re: [PATCH v2 10/9] copy_file_range.2: New page documenting copy_file_range()

2015-09-14 Thread Austin S Hemmelgarn
On 2015-09-13 03:50, Michael Kerrisk (man-pages) wrote: Hi Anna, On 09/11/2015 10:30 PM, Anna Schumaker wrote: copy_file_range() is a new system call for copying ranges of data completely in the kernel. This gives filesystems an opportunity to implement some kind of "copy acceleration", such a

Re: Horrible dbench performance

2015-09-14 Thread Chris Mason
On Mon, Sep 14, 2015 at 11:28:21PM +0800, Liu Bo wrote: > Hi, > > Both [1] and [2] had run dbench on btrfs with fast storage, and > showed bad numbers, I got an impression that after refractoring btree lock to > smart rwlock, we have mitigated this issue.. > > Not got a fast-enough ssd handy, do

Re: [PATCH v3 1/3] btrfs-progs: use calloc instead of malloc+memset for tree roots

2015-09-14 Thread David Sterba
On Sun, Sep 13, 2015 at 11:08:22PM -0700, Omar Sandoval wrote: > From: Omar Sandoval > > Signed-off-by: Omar Sandoval I don't know why I missed this patch last time, but now applied to devel for real. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a mes

Re: [PATCH 06/39] Btrfs: drop null test before destroy functions

2015-09-14 Thread David Sterba
On Sun, Sep 13, 2015 at 02:14:59PM +0200, Julia Lawall wrote: > Remove unneeded NULL test. > > The semantic patch that makes this change is as follows: > (http://coccinelle.lip6.fr/) > > // > @@ expression x; @@ > -if (x != NULL) > \(kmem_cache_destroy\|mempool_destroy\|dma_pool_destroy\)(x);

Re: unable to mount multi disk volume with recovery mode

2015-09-14 Thread Duncan
Anand Jain posted on Mon, 14 Sep 2015 17:44:25 +0800 as excerpted: > Hi Qu, > >> Unfortunately, single mode means no duplication. >> And degrade mount only works for RAID level with >> duplication(DUP,RAID1/5/6/10). > > further to the below commit. > > commit 95669976bd7d30ae265db938ecb46a6b7

Re: Horrible dbench performance

2015-09-14 Thread Liu Bo
On Mon, Sep 14, 2015 at 03:31:27PM -0400, Chris Mason wrote: > On Mon, Sep 14, 2015 at 11:28:21PM +0800, Liu Bo wrote: > > Hi, > > > > Both [1] and [2] had run dbench on btrfs with fast storage, and > > showed bad numbers, I got an impression that after refractoring btree lock > > to > > smart r

Re: unable to mount multi disk volume with recovery mode

2015-09-14 Thread Qu Wenruo
Hi Aand, Anand Jain wrote on 2015/09/14 17:44 +0800: Hi Qu, Unfortunately, single mode means no duplication. And degrade mount only works for RAID level with duplication(DUP,RAID1/5/6/10). further to the below commit. commit 95669976bd7d30ae265db938ecb46a6b7f8cb893 Btrfs: don't con

Re: [PATCH v3 0/9] Btrfs: free space B-tree

2015-09-14 Thread Omar Sandoval
On Mon, Sep 14, 2015 at 04:51:48PM +0200, Holger Hoffstätte wrote: > On 09/14/15 08:04, Omar Sandoval wrote: > > I went back and fixed the issues that came up since v2. Changes below. I > > removed Josef's Reviewed-by on patch 9 because it was completely > > rewritten to change the mount options li

Re: [PATCH v3 0/9] Btrfs: free space B-tree

2015-09-14 Thread Omar Sandoval
On Mon, Sep 14, 2015 at 11:18:36AM -0400, Austin S Hemmelgarn wrote: > On 2015-09-14 02:04, Omar Sandoval wrote: > >Hi, everyone, > > > >I went back and fixed the issues that came up since v2. Changes below. I > >removed Josef's Reviewed-by on patch 9 because it was completely > >rewritten to chang

Re: [PATCH v2 8/9] vfs: copy_file_range() can do a pagecache copy with splice

2015-09-14 Thread Darrick J. Wong
On Fri, Sep 11, 2015 at 04:30:21PM -0400, Anna Schumaker wrote: > The NFS server will need some kind offallback for filesystems that don't > have any kind of copy acceleration, and it should be generally useful to > have an in-kernel copy to avoid lots of switches between kernel and user > space. >