Re: [PATCH 1/2] btrfs/131: test for umount of read-only fs when quota rescan is paused

On Tue, Aug 16, 2016 at 02:30:21PM -0400, Jeff Mahoney wrote: > Ensure that we can unmount a read-only file system when quota rescan > is paused from a previous read-write mount. > > If the kernel has a separate bug where we are returning early while > waiting for the rescan worker, we can use tha

Re: [PATCH 2/2] btrfs/132: test for crash if btrfs quota disable is killed while waiting on rescan

On Tue, Aug 16, 2016 at 02:30:22PM -0400, Jeff Mahoney wrote: > There was a bug in btrfs where the wait for completion of the qgroup > rescan worker could be interrupted, resulting in a crash in the rescan > worker when the quota root goes away. > > It is possible to interrupt the wait during file

Re: [PATCH 1/2] btrfs/131: test for umount of read-only fs when quota rescan is paused

At 08/17/2016 04:45 PM, Eryu Guan wrote: On Tue, Aug 16, 2016 at 02:30:21PM -0400, Jeff Mahoney wrote: Ensure that we can unmount a read-only file system when quota rescan is paused from a previous read-write mount. If the kernel has a separate bug where we are returning early while waiting f

df is not using the right algorithm to report usable space

OK, we all know that df lies with btrfs. But even in the cases where it _could_ tell the truth, it's still getting it wrong. I've finally managed to pin down a concrete example: Label: 'amelia' uuid: 1da97c6f-5467-4591-ad79-5d283db800d4 Total devices 6 FS bytes used 7668.78GiB

Re: [PATCH 1/3] btrfs-progs: Introduce new send-dump object

On Wed, Aug 17, 2016 at 08:42:48AM +0800, Qu Wenruo wrote: > > > At 08/16/2016 10:31 PM, David Sterba wrote: > > On Mon, Aug 01, 2016 at 02:29:42PM +0800, Qu Wenruo wrote: > >> Introduce send-dump.[ch] which implements a new btrfs_send_ops to > >> exam and output all operations inside a send stre

Re: [PATCH] btrfs: Fix leaking bytes_may_use after hitting EDQUOTA

On Wed, Aug 17, 2016 at 10:46:30AM +0800, Qu Wenruo wrote: > Hi David, > > I think this patch is forgot for v4.8 merge windows. > > Xfstest btrfs/022 is complaining about the problem if the patch is not > applied. Yeah this should go to 4.8, the patch looks good to me, but I'd appreciate a revi

Re: [PATCH] btrfs: waiting on qgroup rescan should not always be interruptible

On Mon, Aug 08, 2016 at 10:08:06PM -0400, je...@suse.com wrote: > From: Jeff Mahoney > > We wait on qgroup rescan completion in three places: file system > shutdown, the quota disable ioctl, and the rescan wait ioctl. If the > user sends a signal while we're waiting, we continue happily along.

[PULL] Btrfs fixes for 4.8, part 2

Hi, this is a short series, mostly small fixes that did not make it to the first round. Please pull, thanks. The following changes since commit 10838816547a28696ca10e038b3b32f2efec5a42: Merge branch 'integration-4.8' of git://gi

Re: [PATCH 00/13] btrfs-progs: check: check fs roots in low_memory mode

On Thu, Jul 28, 2016 at 03:08:12PM +0800, Lu Fengqi wrote: > This patchset implements check fs trees in low memory mode, and fix the > return value bug of the function cmd_check(). > > Lu Fengqi (13): > btrfs-progs: move btrfs_extref_hash() to hash.h > btrfs-progs: check: introduce function to

[PATCH] btrfs: don't create or leak aliased root while cleaning up orphans

commit 909c3a22da3 (Btrfs: fix loading of orphan roots leading to BUG_ON) avoids the BUG_ON but can add an aliased root to the dead_roots list or leak the root. Since we've already been loading roots into the radix tree, we should use it before looking the root up on disk. Cc: # 4.5 Signed-off-b