Re: Commit edf064e7c (btrfs: nowait aio support) breaks shells

2017-07-04 Thread Markus Trippelsdorf
On 2017.07.04 at 06:23 +0200, Markus Trippelsdorf wrote: > commit edf064e7c6fec3646b06c944a8e35d1a3de5c2c3 (HEAD, refs/bisect/bad) > Author: Goldwyn Rodrigues > Date: Tue Jun 20 07:05:49 2017 -0500 > > btrfs: nowait aio support > > apparently breaks several shell related features on my sys

Re: [RFC PATCH v4 2/2] Btrfs: add heuristic method for make decision compress or not compress

2017-07-04 Thread Timofey Titovets
2017-07-03 20:30 GMT+03:00 David Sterba : > On Sat, Jul 01, 2017 at 07:56:02PM +0300, Timofey Titovets wrote: >> Add a heuristic computation before compression, >> for avoiding load resource heavy compression workspace, >> if data are probably can't be compressed >> >> Signed-off-by: Timofey Titove

[PATCH] btrfs: resume qgroup rescan on rw remount

2017-07-04 Thread Aleksa Sarai
Several distributions mount the "proper root" as ro during initrd and then remount it as rw before pivot_root(2). Thus, if a rescan had been aborted by a previous shutdown, the rescan would never be resumed. This issue would manifest itself as several btrfs ioctl(2)s causing the entire machine to

Re: Btrfs check reports errors, filesystem seems fine

2017-07-04 Thread Lu Fengqi
On Mon, Jul 03, 2017 at 08:34:52AM +0800, Qu Wenruo wrote: > > >At 07/01/2017 07:59 PM, Filippe LeMarchand wrote: >> Hello everyone. >> >> I have an btrfs root partition on Intel 530 ssd, which mounts without errors >> and seem to work fine, >> but `btrfs check` gives me foloowing output (and --r

Re: Btrfs check reports errors, filesystem seems fine

2017-07-04 Thread Filippe LeMarchand
Sure, here it is: https://drive.google.com/drive/folders/0B1ax9Am81gx9YjJBVVA0LXRHeGc In a letter dated Tuesday, July 4, 2017 16:16:36 MSK user Lu Fengqi wrote: > On Mon, Jul 03, 2017 at 08:34:52AM +0800, Qu Wenruo wrote: > > > > > >At 07/01/2017 07:59 PM, Filippe LeMarchand wrote: > >> Hello ever

[GIT PULL] Btrfs for 4.13

2017-07-04 Thread David Sterba
Hi, please pull the following btrfs changes. As agreed, the pull request comes from me because Chris is on vacation. The changelog is below. There are conflicts with the recently merged block layer branch, the resolutions are a bit tedious but still straightforward. Stephen sent a mail about tha

Re: [RFC PATCH v4 2/2] Btrfs: add heuristic method for make decision compress or not compress

2017-07-04 Thread David Sterba
On Tue, Jul 04, 2017 at 02:11:10PM +0300, Timofey Titovets wrote: > >> @@ -0,0 +1,336 @@ > >> +enum compression_advice btrfs_compress_heuristic(struct inode *inode, > > > > This returns enum but the caller treats it as a bool, this should be > > synced up. > > > > I think for now, enum and values

Re: Commit edf064e7c (btrfs: nowait aio support) breaks shells

2017-07-04 Thread Goldwyn Rodrigues
On 07/04/2017 02:45 AM, Markus Trippelsdorf wrote: > On 2017.07.04 at 06:23 +0200, Markus Trippelsdorf wrote: >> commit edf064e7c6fec3646b06c944a8e35d1a3de5c2c3 (HEAD, refs/bisect/bad) >> Author: Goldwyn Rodrigues >> Date: Tue Jun 20 07:05:49 2017 -0500 >> >> btrfs: nowait aio support >> >

Re: Commit edf064e7c (btrfs: nowait aio support) breaks shells

2017-07-04 Thread Markus Trippelsdorf
On 2017.07.04 at 10:31 -0500, Goldwyn Rodrigues wrote: > > > On 07/04/2017 02:45 AM, Markus Trippelsdorf wrote: > > On 2017.07.04 at 06:23 +0200, Markus Trippelsdorf wrote: > >> commit edf064e7c6fec3646b06c944a8e35d1a3de5c2c3 (HEAD, refs/bisect/bad) > >> Author: Goldwyn Rodrigues > >> Date: Tu

Re: [PATCH] btrfs: check options during subsequent mount

2017-07-04 Thread David Sterba
On Wed, May 24, 2017 at 05:13:24PM +0800, Anand Jain wrote: > Can I ping you on this patch ? Wonder if there is any concern. Well, there's my feeling that touching mount code always leads to some surprise. The specific options apply to the whole filesystem, this is a known limitation. Your patch

Re: [PATCH 08/13] btrfs: convert prelimary reference tracking to use rbtrees

2017-07-04 Thread David Sterba
On Tue, Jun 27, 2017 at 05:10:58PM -0400, Jeff Mahoney wrote: > On 6/27/17 12:49 PM, David Sterba wrote: > > On Tue, Jun 20, 2017 at 10:06:48AM -0600, Edmund Nadolski wrote: > >> It's been known for a while that the use of multiple lists > >> that are periodically merged was an algorithmic problem

[PATCH] Btrfs: add skeleton code for compression heuristic

2017-07-04 Thread Timofey Titovets
For now that code just return true Later more complex heuristic code will be added Signed-off-by: Timofey Titovets --- fs/btrfs/compression.c | 22 ++ fs/btrfs/compression.h | 2 ++ fs/btrfs/inode.c | 25 - 3 files changed, 40 insertions(+), 9 d

Re: Commit edf064e7c (btrfs: nowait aio support) breaks shells

2017-07-04 Thread Jens Axboe
On 07/04/2017 09:31 AM, Goldwyn Rodrigues wrote: > > > On 07/04/2017 02:45 AM, Markus Trippelsdorf wrote: >> On 2017.07.04 at 06:23 +0200, Markus Trippelsdorf wrote: >>> commit edf064e7c6fec3646b06c944a8e35d1a3de5c2c3 (HEAD, refs/bisect/bad) >>> Author: Goldwyn Rodrigues >>> Date: Tue Jun 20 0

[PATCH] btrfs: Correct assignment of pos

2017-07-04 Thread Goldwyn Rodrigues
From: Goldwyn Rodrigues Assigning pos for usage early messes up in append mode, where the pos is re-assigned in generic_write_checks(). Re-assign pos to get the correct position to write from iocb->ki_pos. Fixes: edf064e7c6fe ("btrfs: nowait aio support") Signed-off-by: Goldwyn Rodrigues Tested

Re: [PATCH] btrfs: Correct assignment of pos

2017-07-04 Thread Marc Dionne
On Tue, Jul 4, 2017 at 9:02 PM, Goldwyn Rodrigues wrote: > From: Goldwyn Rodrigues > > Assigning pos for usage early messes up in append mode, where > the pos is re-assigned in generic_write_checks(). Re-assign > pos to get the correct position to write from iocb->ki_pos. > > Fixes: edf064e7c6fe

[PATCH v2] btrfs: Correct assignment of pos

2017-07-04 Thread Goldwyn Rodrigues
From: Goldwyn Rodrigues Assigning pos for usage early messes up in append mode, where the pos is re-assigned in generic_write_checks(). Assign pos later to get the correct position to write from iocb->ki_pos. Since check_can_nocow also uses the value of pos, we shift generic_write_checks() befor