Re: [PATCH] btrfs: Remove WARN_ON for unaligned device created before v4.13 and adds more user friendly output

2017-09-23 Thread Qu Wenruo
On 2017年09月23日 09:27, Satoru Takeuchi wrote: At Sat, 23 Sep 2017 10:19:26 +0900, Satoru Takeuchi wrote: At Wed, 20 Sep 2017 15:18:43 +0900, Qu Wenruo wrote: Commit 7dfb8be11b5d ("btrfs: Round down values which are written for total_bytes_size") is fixing the unaligned device size caused by

btrfs_extref_hash 64-bit vs. btrfs_crc32c 32-bit

2017-09-23 Thread Hans van Kranenburg
Hi, When looking around in the kernel code, I ran into this (hash.h): u32 btrfs_crc32c(u32 crc, const void *address, unsigned int length); [...] static inline u64 btrfs_extref_hash(u64 parent_objectid, const char *name, int len) { return (u64) btrfs_crc32c(parent_objectid, name, len); } [...]

Re: [PATCH 2/3] btrfs: add a flags argument to LOGICAL_INO and call it LOGICAL_INO_V2

2017-09-23 Thread Hans van Kranenburg
On 09/22/2017 07:58 PM, Zygo Blaxell wrote: > Now that check_extent_in_eb()'s extent offset filter can be turned off, > we need a way to do it from userspace. > > Add a 'flags' field to the btrfs_logical_ino_args structure to disable > extent offset filtering, taking the place of one of the existi

Re: [PATCH 3/3] btrfs: increase output size for LOGICAL_INO_V2 ioctl

2017-09-23 Thread Hans van Kranenburg
On 09/22/2017 07:58 PM, Zygo Blaxell wrote: > Build-server workloads have hundreds of references per file after dedup. > Multiply by a few snapshots and we quickly exhaust the limit of 2730 > references per extent that can fit into a 64K buffer. Simulating this scenario: /btrfs 2-# btrfs sub crea