Re: [PATCH] btrfs: Relax memory barrier in btrfs_tree_unlock

2018-02-24 Thread Nikolay Borisov
On 24.02.2018 02:14, David Sterba wrote: > On Wed, Feb 14, 2018 at 02:37:26PM +0200, Nikolay Borisov wrote: >> When performing an unlock on an extent buffer we'd like to order the >> decrement of extent_buffer::blocking_writers with waking up any >> waiters. In such situations it's sufficient to

BTRFS RESTORE issue

2018-02-24 Thread Marián Mlčoch
Hello, i requst IRC , but nobody helps. My primary question is , how mark restored files with ignored errors. btrfs restore –iv /vol /restorage this command restores files like charm but no marker for ok and bad files (bad crc , bad ...). WHY? This file system isnt newbie , i mean this is urge

[PATCH v2] btrfs: fix null pointer deref when target device is missing

2018-02-24 Thread Anand Jain
The replace target device can be missing when mounted with -o degraded, but we wont allocate a missing btrfs_device to it. So check the device before access. BUG: unable to handle kernel NULL pointer dereference at 00b0 IP: btrfs_destroy_dev_replace_tgtdev+0x43/0xf0 [btrfs] Call Trace:

Re: [PATCH 1/1] btrfs: fix NPD when target device is missing

2018-02-24 Thread Anand Jain
On 02/24/2018 06:55 AM, David Sterba wrote: On Tue, Feb 20, 2018 at 10:46:25PM +0800, Anand Jain wrote: The replace target device can be missing in which case we don't allocate a missing btrfs_device when mounted with the -o degraded. So check the device before access. BUG: unable to handle k

Re: fs was hung

2018-02-24 Thread Rich Rauenzahn
Huh. If I do an strace of a dd of the drive once, it works for a while, ^C and start again and the strace hangs on a read() syscall! So... seems like a hardware problem that coincided with the drive filling up. Or something! This will be my first btrfs raid1 replacement, so I'm hoping its strai

Re: BTRFS RESTORE issue

2018-02-24 Thread Qu Wenruo
On 2018年02月24日 19:13, Marián Mlčoch wrote: > Hello, > i requst IRC , but nobody helps. > My primary question is , how mark restored files with ignored errors. > > btrfs restore –iv /vol /restorage > > this command restores files like charm but no marker for ok and bad > files (bad crc , bad ...

Re: BTRFS RESTORE issue

2018-02-24 Thread Shehbaz Jaffer
> If you want checksum and your fs can stand normal RO mount, go RO mount, > and do normal cp, you will get csum error in kernel message if there is any. Also, try btrfsck and btrfs scrub. both help in identifying (and sometimes correcting) csum errors. They would give both logs on console and dme

csum failed error messages

2018-02-24 Thread Adam Bahe
Hello, I am getting the below errors on a brand new array with drives that are maybe 2 months old which have been absolutely fine up until now, and report no errors in smartctl. [Sat Feb 24 06:04:37 2018] BTRFS warning (device sde): csum failed root 257 ino 181466 off 20578304 csum 0xe238f260 expe

Re: csum failed error messages

2018-02-24 Thread Chris Murphy
Looks like they're already fixed: [Sat Feb 24 06:04:54 2018] BTRFS info (device sde): read error corrected: ino 181466 off 114257920 (dev /dev/sdi sector 5332484024) Question is why there's bad data. You can use 'btrfs dev stats' to show the errors on all devices. If the errors are fairly distri