Re: interest in post-mortem examination of a BTRFS system and improving the btrfs-code?

2019-04-06 Thread Nik.
2019-04-06 02:03, Qu Wenruo: On 2019/4/6 上午3:38, Nik. wrote: 2019-04-05 10:15, Qu Wenruo: On 2019/4/5 下午3:41, Nik. wrote: Below is the stderr of both commands: # btrfs inspect dump-tree -t chunk /dev/md0>DT-chunk.log # btrfs inspect dump-tree -t extent /dev/md0>DT-extent.log ERROR:

Re: interest in post-mortem examination of a BTRFS system and improving the btrfs-code?

2019-04-06 Thread Qu Wenruo
On 2019/4/6 下午3:16, Nik. wrote: > > > 2019-04-06 02:03, Qu Wenruo: >> >> >> On 2019/4/6 上午3:38, Nik. wrote: >>> >>> >>> 2019-04-05 10:15, Qu Wenruo: On 2019/4/5 下午3:41, Nik. wrote: > > Below is the stderr of both commands: > > # btrfs inspect dump-tree -t chunk /d

Re: interest in post-mortem examination of a BTRFS system and improving the btrfs-code?

2019-04-06 Thread Nik.
2019-04-06 09:45, Qu Wenruo: On 2019/4/6 下午3:16, Nik. wrote: 2019-04-06 02:03, Qu Wenruo: On 2019/4/6 上午3:38, Nik. wrote: 2019-04-05 10:15, Qu Wenruo: On 2019/4/5 下午3:41, Nik. wrote: Below is the stderr of both commands: # btrfs inspect dump-tree -t chunk /dev/md0>DT-chunk.log

Re: interest in post-mortem examination of a BTRFS system and improving the btrfs-code?

2019-04-06 Thread Qu Wenruo
>> >> Please try again, and sorry for the inconvenience. Hopes this is the >> last try. > > #sudo ./btrfs-corrupt-block -X /dev/md0 > old offset=131072 len=0 > new offset=0 len=0 My bad, the first fix is bad, leading the bad result. (And that's why we need to review patches) Fortunately we have

[PATCH] btrfs: Record error in btree_csum_one_bio()

2019-04-06 Thread Qu Wenruo
Since commit 6dc4f100c175 ("block: allow bio_for_each_segment_all() to iterate over multi-page bvec"), break will only break the inner loop of bio_for_each_segment_all(), unable to break the outer loop. This patch will break out by utilizing goto command. Signed-off-by: Qu Wenruo --- fs/btrfs/d

Re: [PATCH v3] fstests: btrfs verify hardening agaist duplicate fsid

2019-04-06 Thread Eryu Guan
On Tue, Apr 02, 2019 at 01:58:23PM +0800, Anand Jain wrote: > > Eryu, > > This patch isn't integrated yet. Sorry for missing that, and thanks for reminding! I've applied the patch. Thanks! Eryu

Re: [PATCH v2] fstests: btrfs/048: amend property validation cases

2019-04-06 Thread Eryu Guan
On Fri, Apr 05, 2019 at 04:21:10PM +0300, Nikolay Borisov wrote: > > > On 3.04.19 г. 20:04 ч., Anand Jain wrote: > > Add more property validation cases which are fixed by the patches [1] > > [1] > > btrfs: fix vanished compression property after failed set > > btrfs: fix zstd compression par

Re: [PATCH] fstests: log-writes: Add new option to replay/find next write to sector

2019-04-06 Thread Eryu Guan
On Thu, Mar 28, 2019 at 01:35:07PM +0800, Qu Wenruo wrote: > For kernel operation we have METADATA/FUA/FLUSH flags as a beacon, but > for user space write we don't have any useful flag unless the user space > tool call fsync() to generate a FLUSH bio. > > This means for user space write, we don't

Re: interest in post-mortem examination of a BTRFS system and improving the btrfs-code?

2019-04-06 Thread Nik.
2019-04-06 11:06, Qu Wenruo: Please try again, and sorry for the inconvenience. Hopes this is the last try. #sudo ./btrfs-corrupt-block -X /dev/md0 old offset=131072 len=0 new offset=0 len=0 My bad, the first fix is bad, leading the bad result. (And that's why we need to review patches)

Re: interest in post-mortem examination of a BTRFS system and improving the btrfs-code?

2019-04-06 Thread Qu Wenruo
On 2019/4/6 下午9:20, Nik. wrote: > > > 2019-04-06 11:06, Qu Wenruo: Please try again, and sorry for the inconvenience. Hopes this is the last try. >>> >>> #sudo ./btrfs-corrupt-block -X /dev/md0 >>> old offset=131072 len=0 >>> new offset=0 len=0 >> >> My bad, the first fix is bad,

Re: interest in post-mortem examination of a BTRFS system and improving the btrfs-code?

2019-04-06 Thread Qu Wenruo
On 2019/4/6 下午9:22, Qu Wenruo wrote: > > > On 2019/4/6 下午9:20, Nik. wrote: >> >> >> 2019-04-06 11:06, Qu Wenruo: > > Please try again, and sorry for the inconvenience. Hopes this is the > last try. #sudo ./btrfs-corrupt-block -X /dev/md0 old offset=131072 len=0 n

Re: interest in post-mortem examination of a BTRFS system and improving the btrfs-code?

2019-04-06 Thread Nik.
2019-04-06 15:22, Qu Wenruo: On 2019/4/6 下午9:20, Nik. wrote: 2019-04-06 11:06, Qu Wenruo: Please try again, and sorry for the inconvenience. Hopes this is the last try. #sudo ./btrfs-corrupt-block -X /dev/md0 old offset=131072 len=0 new offset=0 len=0 My bad, the first fix is bad, l

Re: [PATCH] fstests: log-writes: Add new option to replay/find next write to sector

2019-04-06 Thread Amir Goldstein
On Thu, Mar 28, 2019 at 7:36 AM Qu Wenruo wrote: > > For kernel operation we have METADATA/FUA/FLUSH flags as a beacon, but > for user space write we don't have any useful flag unless the user space > tool call fsync() to generate a FLUSH bio. > > This means for user space write, we don't really h

Re: interest in post-mortem examination of a BTRFS system and improving the btrfs-code?

2019-04-06 Thread Qu Wenruo
On 2019/4/6 下午10:19, Nik. wrote: > > > 2019-04-06 15:22, Qu Wenruo: >> >> >> On 2019/4/6 下午9:20, Nik. wrote: >>> >>> >>> 2019-04-06 11:06, Qu Wenruo: >> >> Please try again, and sorry for the inconvenience. Hopes this is the >> last try. > > #sudo ./btrfs-corrupt-block -X /de