Re: [PATCH 06/12] btrfs: add simple test of reflink of encrypted data

2023-10-31 Thread Anand Jain
On 11/10/2023 04:25, Josef Bacik wrote: From: Sweet Tea Dorminy Make sure that we succeed at reflinking encrypted data. Test deliberately numbered with a high number so it won't conflict with tests between now and merge. --- Looks good. However, SOB is missing. Thanks, Anand

Re: [PATCH 01/12] common/encrypt: separate data and inode nonces

2023-10-31 Thread Anand Jain
On 11/10/2023 04:25, Josef Bacik wrote: From: Sweet Tea Dorminy btrfs will have different inode and data nonces, so we need to be specific about which nonce each use needs. For now, there is no difference in the two functions. Signed-off-by: Sweet Tea Dorminy --- Looks good. Reviewed-by: An

Re: [PATCH 02/12] common/encrypt: add btrfs to get_encryption_*nonce

2023-10-31 Thread Anand Jain
On 11/10/2023 04:25, Josef Bacik wrote: From: Sweet Tea Dorminy Add the modes of getting the encryption nonces, either inode or extent, to the various get_encryption_nonce functions. For now, no encrypt test makes a file with more than one extent, so we can just grab the first extent's nonce fo

Re: [PATCH 03/12] common/encrypt: add btrfs to get_ciphertext_filename

2023-10-31 Thread Anand Jain
On 11/10/2023 04:25, Josef Bacik wrote: From: Sweet Tea Dorminy Add the relevant call to get an encrypted filename from btrfs. Signed-off-by: Sweet Tea Dorminy Looks good. Reviewed-by: Anand Jain Thanks, Anand

Re: [PATCH 04/12] common/encrypt: enable making a encrypted btrfs filesystem

2023-10-31 Thread Anand Jain
On 11/10/2023 04:25, Josef Bacik wrote: From: Sweet Tea Dorminy Signed-off-by: Sweet Tea Dorminy --- Looks good. Reviewed-by: Anand Jain Thanks, Anand

Re: [PATCH 05/12] common/verity: explicitly don't allow btrfs encryption

2023-10-31 Thread Anand Jain
On 11/10/2023 04:25, Josef Bacik wrote: From: Sweet Tea Dorminy Currently btrfs encryption doesn't support verity, but it is planned to one day. To be explicit about the lack of support, add a custom error message to the combination. Signed-off-by: Sweet Tea Dorminy Looks Good. Reviewed-b

Re: [PATCH 07/12] btrfs: test snapshotting encrypted subvol

2023-10-31 Thread Anand Jain
On 11/10/2023 04:26, Josef Bacik wrote: From: Sweet Tea Dorminy Make sure that snapshots of encrypted data are readable and writeable. Test deliberately high-numbered to not conflict. Signed-off-by: Sweet Tea Dorminy Looks good to me. Reviewed-by: Anand Jain Thanks, Anand

Re: [PATCH 07/12] btrfs: test snapshotting encrypted subvol

2023-10-31 Thread Filipe Manana
On Tue, Oct 10, 2023 at 9:26 PM Josef Bacik wrote: > > From: Sweet Tea Dorminy > > Make sure that snapshots of encrypted data are readable and writeable. > > Test deliberately high-numbered to not conflict. > > Signed-off-by: Sweet Tea Dorminy > --- > tests/btrfs/614 | 76 +