Re: [RFC] mm: alloc_pages_bulk: remove assumption of populating only NULL elements

2025-02-18 Thread Dave Chinner
On Tue, Feb 18, 2025 at 05:21:27PM +0800, Yunsheng Lin wrote: > On 2025/2/18 5:31, Dave Chinner wrote: > > ... > > > . > > > >> diff --git a/fs/xfs/xfs_buf.c b/fs/xfs/xfs_buf.c > >> index 15bb790359f8..9e1ce0ab9c35 100644 > >> --- a/fs/xfs/xfs_buf.c > >> +++ b/fs/xfs/xfs_buf.c > >> @@ -377,1

Re: [RFC] mm: alloc_pages_bulk: remove assumption of populating only NULL elements

2025-02-18 Thread Chuck Lever
On 2/18/25 4:16 AM, Yunsheng Lin wrote: > On 2025/2/17 22:20, Chuck Lever wrote: >> On 2/17/25 7:31 AM, Yunsheng Lin wrote: >>> As mentioned in [1], it seems odd to check NULL elements in >>> the middle of page bulk allocating, >> >> I think I requested that check to be added to the bulk page alloc

Re: [RFC] mm: alloc_pages_bulk: remove assumption of populating only NULL elements

2025-02-18 Thread Yunsheng Lin
On 2025/2/18 5:31, Dave Chinner wrote: ... > . > >> diff --git a/fs/xfs/xfs_buf.c b/fs/xfs/xfs_buf.c >> index 15bb790359f8..9e1ce0ab9c35 100644 >> --- a/fs/xfs/xfs_buf.c >> +++ b/fs/xfs/xfs_buf.c >> @@ -377,16 +377,17 @@ xfs_buf_alloc_pages( >> * least one extra page. >> */ >>

Re: [RFC] mm: alloc_pages_bulk: remove assumption of populating only NULL elements

2025-02-18 Thread Yunsheng Lin
On 2025/2/17 22:20, Chuck Lever wrote: > On 2/17/25 7:31 AM, Yunsheng Lin wrote: >> As mentioned in [1], it seems odd to check NULL elements in >> the middle of page bulk allocating, > > I think I requested that check to be added to the bulk page allocator. > > When sending an RPC reply, NFSD mig