btrfs_scan_kernel() is only used in 'btrfs fi show' but returns wrong
return value.
When search parameter is passed, it will never return 0 even the search
can be matched.
This patch will change the whatever strange logic to a more easy to
understand one using 'found' var.
Reported-by: Tsutomu
On Sat, 5 Apr 2014, Dave Chinner wrote:
Date: Sat, 5 Apr 2014 08:12:25 +1100
From: Dave Chinner da...@fromorbit.com
To: Filipe David Manana fdman...@gmail.com
Cc: x...@oss.sgi.com x...@oss.sgi.com,
linux-btrfs@vger.kernel.org linux-btrfs@vger.kernel.org,
linux-e...@vger.kernel.org,
Steps to reproduce:
# mkfs.btrfs -f /dev/sda[8-11] -m raid5 -d raid5
# mount /dev/sda8 /mnt
# btrfs scrub start -BR /mnt
# echo $? --unverified errors make return value be 3
This is because we don't setup right mapping between physical
and logical address for raid56, which makes checksum
posix_acl_xattr_set() already does the check, and it's the only
way to feed in an ACL from userspace.
So the check here is useless, remove it.
Signed-off-by: zhang zhen zhenzhang.zh...@huawei.com
---
fs/btrfs/acl.c |7 ---
1 files changed, 0 insertions(+), 7 deletions(-)
diff --git
Hi,
I've been running btrfs on my SSD powered laptop for about a year and
a half (with force-compress=lzo and autodefrag) and it seems the
volume has degraded quite a lot although I am not using snapshot
functionality.
No matter what I do (scrub, defrag ob the whole volume), files seem to
stay
Hi,
This is because every other filesystem (except ZFS) doesn't use COW
semantics.
Nilfs2 also is COW based.
Regards, Clemens
--
To unsubscribe from this list: send the line unsubscribe linux-btrfs in
the body of a message to majord...@vger.kernel.org
More majordomo info at
On 2014-04-08 07:56, Clemens Eisserer wrote:
Hi,
This is because every other filesystem (except ZFS) doesn't use COW
semantics.
Nilfs2 also is COW based.
Regards, Clemens
--
To unsubscribe from this list: send the line unsubscribe linux-btrfs in
the body of a message to
Arun Persaud posted on Mon, 07 Apr 2014 16:14:56 -0700 as excerpted:
my HD recently started crashing, so I rescued all files to a new one and
thought that this might be a good time to convert from ext4 to btrfs.
Welcome. =:^) If you haven't already done so, please spend some time
reviewing
btrfs-progs v3.14 from git.
Apparently btrfs property was added with command-line help only. The
btrfs manpage doesn't have the word property at all.
Additionally, could we get a btrfs-mountopts manpage, until the normal
mount manpage covers it anyway? Yes, the information is in $KERNDIR/
Clemens Eisserer posted on Tue, 08 Apr 2014 13:46:37 +0200 as excerpted:
I've been running btrfs on my SSD powered laptop for about a year and a
half (with force-compress=lzo and autodefrag) and it seems the volume
has degraded quite a lot although I am not using snapshot functionality.
No
Signed-off-by: Kusanagi Kouichi sl...@ac.auone-net.jp
---
ctree.h | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/ctree.h b/ctree.h
index 9b461af..45f2faf 100644
--- a/ctree.h
+++ b/ctree.h
@@ -1184,9 +1184,9 @@ struct btrfs_root {
# btrfs prop list -t f .
btrfs property list: too many arguments
...
# btrfs prop get -t f . label
btrfs property get: too many arguments
...
# btrfs prop set -t f . label abc
btrfs property set: too many arguments
...
Signed-off-by: Kusanagi Kouichi sl...@ac.auone-net.jp
---
cmds-property.c | 6
On Tue, Apr 8, 2014 at 1:14 AM, Dave Chinner da...@fromorbit.com wrote:
On Fri, Apr 04, 2014 at 02:07:16PM +0100, Filipe David Manana wrote:
On Fri, Apr 4, 2014 at 10:03 AM, Dave Chinner da...@fromorbit.com wrote:
Hi folks,
The xfstests repository at git://oss.sgi.com/xfs/cmds/xfstests has
Soon after upgrading my server from 3.14rc5 to 3.14.0, my server went
into a crash loop.
Unfortunately because I used btrfs on my root filesystem, the problem
didn't get logged because btrfs failing on a separate array prevented
another thread to use btrfs to write on a healthy /var filesystem.
We need to read a number of bytes corresponding to the disk size of the file
extent
item, and not to the number of bytes in the num_bytes field. Normally disk_size
is
smaller than num_bytes (when using compression), except for files created with
lzo
compression in a kernel older then the one
With changes introduced in 667308dd97bf41382d4ab299fa5b56c235cfeb27
it is no longer possible to use SCRATCH_DEV_POOL variable because of
error:
common/config: Error: $SCRATCH_DEV should be unset when
$SCRATCH_DEV_POOL is set
This was because get_next_config() would get called twice and hence
In the case that we already have sections in the config file we
have to make sure that we unset SCRATCH_DEV if it has been deduced from
the SCRATCH_DEV_POOL so that it does not complain about SCRATCH_DEV in
this case.
Signed-off-by: Lukas Czerner lczer...@redhat.com
---
common/config | 8
Currently if the FSTYP is not set, the code to get FSTYP using blikd
would not work. This is because we're using HOSTOS environment variable
which might not be set (at least not on my system) and because it's
already late in the code path.
Fix this by using OSTYP environment variable as a
Hello,
I have a bunch of files that can't be cloned with `cp --reflink=always`
for no apparent reason. However, if I copy the file before doign the
clone it works.
Staces of a --reflink copy of the original file[1] and of the copied
file[2]:
[1]: http://sprunge.us/UXOO
[2]:
The following kernel commit changed the definition of the inline function
btrfs_file_extent_inline_len():
commit 514ac8ad8793a097c0c9d89202c642479d6dfa34
Author: Chris Mason c...@fb.com
Date: Fri Jan 3 21:07:00 2014 -0800
Btrfs: don't use ram_bytes for uncompressed inline items
On Tue, Apr 8, 2014 at 4:42 PM, Lukas Czerner lczer...@redhat.com wrote:
In the case that we already have sections in the config file we
have to make sure that we unset SCRATCH_DEV if it has been deduced from
the SCRATCH_DEV_POOL so that it does not complain about SCRATCH_DEV in
this case.
On Tue, Apr 8, 2014 at 4:42 PM, Lukas Czerner lczer...@redhat.com wrote:
With changes introduced in 667308dd97bf41382d4ab299fa5b56c235cfeb27
it is no longer possible to use SCRATCH_DEV_POOL variable because of
error:
common/config: Error: $SCRATCH_DEV should be unset when
$SCRATCH_DEV_POOL
On Tue, Apr 8, 2014 at 4:42 PM, Lukas Czerner lczer...@redhat.com wrote:
Currently if the FSTYP is not set, the code to get FSTYP using blikd
would not work. This is because we're using HOSTOS environment variable
which might not be set (at least not on my system) and because it's
already late
Hello
On 04/08/2014 05:10 AM, Duncan wrote:
[...]
I
copied all the files from my old HD using dd, converted and then resized
the file system. However, my old drive already had some errors.
There's a page on the wiki specifically covering conversion. Please read
it carefully and follow
Hi Ducan,
You mention trying scrub and defragging the entire volume, but you don't
mention balance. Balance by default rewrites all chunks (tho you can add
filters to rewrite only say data chunks, not metadata, if you like), so
that's what I'd say to try, as it should defrag in the process.
I forgot to add that while I'm not sure if anyone ended up looking at the
last image I made regarding
https://bugzilla.kernel.org/show_bug.cgi?id=72801
I can generate a an image of that filesystem if that helps, or try other
commands which hopefully won't crash my running server :)
(filesystem is
On 04/08/2014 06:09 PM, Marc MERLIN wrote:
I forgot to add that while I'm not sure if anyone ended up looking at the
last image I made regarding
https://bugzilla.kernel.org/show_bug.cgi?id=72801
I can generate a an image of that filesystem if that helps, or try other
commands which hopefully
Hi folks,
The xfstests repository at git://oss.sgi.com/xfs/cmds/xfstests has
just been updated. Patches often get missed, so please check if your
outstanding patches were in this update. If they have not been in
this update, please resubmit them to x...@oss.sgi.com so they can be
picked up in the
In btrfs_create_tree(), if btrfs_insert_root() fails, we should
free root-commit_root.
Reported-by: Alex Lyakas a...@zadarastorage.com
Signed-off-by: Tsutomu Itoh t-i...@jp.fujitsu.com
---
fs/btrfs/disk-io.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/btrfs/disk-io.c
I expect btrfs_scan_kernel() would go away in the long run,
however below fix has a problem - when there is no search item
you would return fail (1) always. Since btrfs_scan_kernel() has
limited usage as you mention as well. So I will leave it to David
to decide.
Thanks, Anand
On
Nope, the fix can also deal with no search parameter.
If any btrfs filesystem can be found and printed, found will be set to 1
which considered as found,
then 0 will be returned.
Thanks,
Qu
于 2014年04月09日 10:09, Anand Jain 写道:
I expect btrfs_scan_kernel() would go away in the long run,
Below shows the bug cascading to this patch.
And now to fix this I think we shouldn't fix/workaround in the
btrfs-progs again!, fix it in the btrfs-kernel (or leave it open
until suitable fix is found, I tried and failed. but don't fix it
in a wrong way). If you want to help to fix this
On 09/04/2014 10:18, Qu Wenruo wrote:
Nope, the fix can also deal with no search parameter.
If any btrfs filesystem can be found and printed, found will be set to 1
which considered as found,
then 0 will be returned.
Oh yes. You are right. Thanks, Anand
Thanks,
Qu
于 2014年04月09日 10:09,
On Tue, Apr 08, 2014 at 07:49:14PM -0400, Chris Mason wrote:
On 04/08/2014 06:09 PM, Marc MERLIN wrote:
I forgot to add that while I'm not sure if anyone ended up looking at the
last image I made regarding
https://bugzilla.kernel.org/show_bug.cgi?id=72801
I can generate a an image of
A bit of background of btrfs fi show.
As such original btrfs fi show had too many problems since btrfs-progs
wasn't much consulting btrfs-kernel to determine various
mounted device status. This was a serious problem sometime back.
Various patches brings btrfs-progs to communicate with kernel
On Tue, Apr 08, 2014 at 09:31:25PM -0700, Marc MERLIN wrote:
On Tue, Apr 08, 2014 at 07:49:14PM -0400, Chris Mason wrote:
On 04/08/2014 06:09 PM, Marc MERLIN wrote:
I forgot to add that while I'm not sure if anyone ended up looking at the
last image I made regarding
36 matches
Mail list logo
