Re: [PATCH v2] common: get fs type again using device canonical name in _fs_type

2014-08-01 Thread Dave Chinner
On Fri, Aug 01, 2014 at 01:02:58PM +0800, Eryu Guan wrote: On Fri, Aug 01, 2014 at 02:49:10PM +1000, Dave Chinner wrote: On Fri, Aug 01, 2014 at 12:02:41PM +0800, Eryu Guan wrote: On Fri, Aug 01, 2014 at 10:21:59AM +1000, Dave Chinner wrote: On Thu, Jul 31, 2014 at 06:52:37PM +0800, Eryu

Re: integration tree updated

2014-08-01 Thread Anand Jain
Hi Chris, Looks like you missed Miao update (on 17 Jul) to back out the bad patch (below), and your integration branch (published on 25 Jul) still contains the same. [PATCH 2/2] Btrfs: fix wrong total device counter after removing a seed device You should remove it. Simple test cases

Re: [PATCH] Add support to check for FALLOC_FL_COLLAPSE_RANGE and FALLOC_FL_ZERO_RANGE crap modes

2014-08-01 Thread Hugo Mills
On Thu, Jul 31, 2014 at 09:53:15PM -0400, Nick Krause wrote: On Thu, Jul 31, 2014 at 3:09 PM, Hugo Mills h...@carfax.org.uk wrote: On Thu, Jul 31, 2014 at 01:53:33PM -0400, Nicholas Krause wrote: This adds checks for the stated modes as if they are crap we will return error not

[PATCH v2] xfstests: add regression test for btrfs send with orphans

2014-08-01 Thread Filipe Manana
Regression test for a btrfs issue where we create a RO snapshot to use for a send operation, which fails with a -ESTALE error, due to the presence of orphan inodes accessible through the snapshot's commit root but no longer present through the main root. This issue is fixed by the following linux

open_ctree failed on 3.16.0

2014-08-01 Thread Frankie Fisher
Hello. A circuit breaker failed a few times and now I can't mount my btrfs volume - it fails with open_ctree failed: [ 337.004372] [817865a5] dump_stack+0x46/0x58 [ 337.004375] [810720ac] warn_slowpath_common+0x8c/0xc0 [ 337.004378] [810720fa]

Re: Btrfs offline deduplication

2014-08-01 Thread Austin S Hemmelgarn
On 07/31/2014 07:54 PM, Timofey Titovets wrote: Good time of day. I have several questions about data deduplication on btrfs. Sorry if i ask stupid questions or waste you time %) What about implementation of offline data deduplication? I don't see any activity on this place, may be i need

Re: open_ctree failed on 3.16.0

2014-08-01 Thread Duncan
Frankie Fisher posted on Fri, 01 Aug 2014 10:58:39 +0100 as excerpted: A circuit breaker failed a few times and now I can't mount my btrfs volume - it fails with open_ctree failed: [snip stacktrace, which as a btrfs user not dev doesn't give me much anyway] mount -o recovery doesn't

Re: Machine lockup due to btrfs-transaction on AWS EC2 Ubuntu 14.04

2014-08-01 Thread Peter Waller
I've reproduced these issues on a single-core machine which doesn't appear to become completely unresponsive after 12 hours of copying (as the other machines are deadlocking after 5-10 minutes, perhaps?), but it does use 100% SYS CPU with no IO traffic for the vast majority of the time. (In fact,

Re: [PATCH] Add support to check for FALLOC_FL_COLLAPSE_RANGE and FALLOC_FL_ZERO_RANGE crap modes

2014-08-01 Thread Theodore Ts'o
On Thu, Jul 31, 2014 at 08:09:10PM +0100, Hugo Mills wrote: On Thu, Jul 31, 2014 at 01:53:33PM -0400, Nicholas Krause wrote: This adds checks for the stated modes as if they are crap we will return error not supported. You've just enabled two options, but you haven't actually

Re: open_ctree failed on 3.16.0

2014-08-01 Thread Frankie Fisher
On 01/08/14 12:29, Duncan wrote: Frankie Fisher posted on Fri, 01 Aug 2014 10:58:39 +0100 as excerpted: A circuit breaker failed a few times and now I can't mount my btrfs volume - it fails with open_ctree failed: What are the next steps I should try? Should I try btrfs-zero-log? Or should

Re: Btrfs offline deduplication

2014-08-01 Thread David Sterba
On Fri, Aug 01, 2014 at 06:17:44AM -0400, Austin S Hemmelgarn wrote: I do think however that having the option of a background thread doing deduplication asynchronously is a good idea, but then you would have to have some way to trigger it on individual files/trees, and triggering on writes

Re: [PATCH] Add support to check for FALLOC_FL_COLLAPSE_RANGE and FALLOC_FL_ZERO_RANGE crap modes

2014-08-01 Thread Nick Krause
On Fri, Aug 1, 2014 at 8:21 AM, Theodore Ts'o ty...@mit.edu wrote: On Thu, Jul 31, 2014 at 08:09:10PM +0100, Hugo Mills wrote: On Thu, Jul 31, 2014 at 01:53:33PM -0400, Nicholas Krause wrote: This adds checks for the stated modes as if they are crap we will return error not supported.

RE: [PATCH] btrfs-progs: mkfs: remove experimental tag

2014-08-01 Thread Kyle Gates
From: dste...@suse.cz To: linux-btrfs@vger.kernel.org CC: dste...@suse.cz Subject: [PATCH] btrfs-progs: mkfs: remove experimental tag Date: Thu, 31 Jul 2014 14:21:34 +0200 Make it consistent with kernel status and documentation. Signed-off-by:

Re: [PATCH] btrfs-progs: mkfs: remove experimental tag

2014-08-01 Thread David Sterba
On Fri, Aug 01, 2014 at 11:38:09AM -0500, Kyle Gates wrote: The sentence/thought isn't complete. I was left thinking more what? perhaps add: information, documentation Changed to 'more information'. -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message

Re: Help with btrfs_zero_range function

2014-08-01 Thread Nick Krause
Please forget my other questions , seems the only work to make punch hole work for zero range is to make a function like the one I am pasting below for zero range and change the calls to punch range to zero range as the other parts of the function can be the same from my reading. Regards Nick

Re: Help with btrfs_zero_range function

2014-08-01 Thread Nick Krause
On Fri, Aug 1, 2014 at 12:58 PM, Nick Krause xerofo...@gmail.com wrote: Please forget my other questions , seems the only work to make punch hole work for zero range is to make a function like the one I am pasting below for zero range and change the calls to punch range to zero range as the

Re: Btrfs offline deduplication

2014-08-01 Thread Mark Fasheh
On Fri, Aug 01, 2014 at 10:16:08AM -0400, Austin S Hemmelgarn wrote: On 2014-08-01 09:23, David Sterba wrote: On Fri, Aug 01, 2014 at 06:17:44AM -0400, Austin S Hemmelgarn wrote: I do think however that having the option of a background thread doing deduplication asynchronously is a good

Re: Btrfs offline deduplication

2014-08-01 Thread Austin S Hemmelgarn
On 08/01/2014 02:55 PM, Mark Fasheh wrote: On Fri, Aug 01, 2014 at 10:16:08AM -0400, Austin S Hemmelgarn wrote: On 2014-08-01 09:23, David Sterba wrote: On Fri, Aug 01, 2014 at 06:17:44AM -0400, Austin S Hemmelgarn wrote: I do think however that having the option of a background thread doing

Re: Btrfs offline deduplication

2014-08-01 Thread Mark Fasheh
On Fri, Aug 01, 2014 at 03:18:46PM -0400, Austin S Hemmelgarn wrote: Why does this have to be kernel side? There's userspace software already to dedupe that can be run on a regular basis. Exporting checksums is a differnet story (you can do that via ioctl) but running the dedupe software

[PATCH 09/12] btrfs: factor btrfs_setup_super() out of open_ctree()

2014-08-01 Thread Eric Sandeen
Move all the superblock flag geometry testing fiddling into its own function. This does coalesce some far-flung tests, but it ... looks ok to me. Signed-off-by: Eric Sandeen sand...@redhat.com --- fs/btrfs/disk-io.c | 207 1 files changed,

[PATCH 10/12] btrfs: factor btrfs_alloc_workqueues() out of open_ctree()

2014-08-01 Thread Eric Sandeen
Signed-off-by: Eric Sandeen sand...@redhat.com --- fs/btrfs/disk-io.c | 144 1 files changed, 77 insertions(+), 67 deletions(-) diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c index 31e9791..0465d43 100644 --- a/fs/btrfs/disk-io.c +++

[PATCH 12/12] btrfs: factor btrfs_replay_log() out of open_ctree()

2014-08-01 Thread Eric Sandeen
Signed-off-by: Eric Sandeen sand...@redhat.com --- fs/btrfs/disk-io.c | 100 +--- 1 files changed, 56 insertions(+), 44 deletions(-) diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c index a50beca..ffb2f21 100644 --- a/fs/btrfs/disk-io.c +++

[PATCH 04/12] btrfs: factor btrfs_scrub_init() out of open_ctree()

2014-08-01 Thread Eric Sandeen
Signed-off-by: Eric Sandeen sand...@redhat.com --- fs/btrfs/disk-io.c | 19 --- 1 files changed, 12 insertions(+), 7 deletions(-) diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c index 28d35a8..b95635f 100644 --- a/fs/btrfs/disk-io.c +++ b/fs/btrfs/disk-io.c @@ -2134,6

[PATCH 02/12] btrfs: consistently use fs_info in close_ctree()

2014-08-01 Thread Eric Sandeen
close_ctree() has a local fs_info var for convienience; use it consistently. Signed-off-by: Eric Sandeen sand...@redhat.com --- fs/btrfs/disk-io.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c index f6d7afd..e6746be 100644

[PATCH 03/12] btrfs: handle errors from reading the quota tree root

2014-08-01 Thread Eric Sandeen
Reading the quota tree root may fail with ENOENT if there is no quota, which is fine, but the code was ignoring every other error as well, which is not fine. Signed-off-by: Eric Sandeen sand...@redhat.com --- fs/btrfs/disk-io.c |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-)

[PATCH 01/12] btrfs: remove unused fs_info arg from btrfs_close_extra_devices()

2014-08-01 Thread Eric Sandeen
The commit: 8dabb74 Btrfs: change core code of btrfs to support the device replace operations added the fs_info argument, but never used it - just remove it again. Signed-off-by: Eric Sandeen sand...@redhat.com --- fs/btrfs/disk-io.c |4 ++-- fs/btrfs/volumes.c |3 +--

[PATCH 05/12] btrfs: factor btrfs_balance_init() out of open_ctree()

2014-08-01 Thread Eric Sandeen
Signed-off-by: Eric Sandeen sand...@redhat.com --- fs/btrfs/disk-io.c | 20 1 files changed, 12 insertions(+), 8 deletions(-) diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c index b95635f..8c7113b 100644 --- a/fs/btrfs/disk-io.c +++ b/fs/btrfs/disk-io.c @@ -2145,6

[PATCH 08/12] btrfs: factor btrfs_qgroup_init() out of open_ctree()

2014-08-01 Thread Eric Sandeen
Signed-off-by: Eric Sandeen sand...@redhat.com --- fs/btrfs/disk-io.c | 26 +++--- 1 files changed, 15 insertions(+), 11 deletions(-) diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c index a5fa84f..47fcacf 100644 --- a/fs/btrfs/disk-io.c +++ b/fs/btrfs/disk-io.c @@

[PATCH 07/12] btrfs: factor btrfs_dev_replace_locks_init() out of open_ctree()

2014-08-01 Thread Eric Sandeen
Signed-off-by: Eric Sandeen sand...@redhat.com --- fs/btrfs/disk-io.c | 16 +++- 1 files changed, 11 insertions(+), 5 deletions(-) diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c index 6636386..a5fa84f 100644 --- a/fs/btrfs/disk-io.c +++ b/fs/btrfs/disk-io.c @@ -2186,6

[PATCH 00/12] disk-io.c / open_ctree cleanup refactoring

2014-08-01 Thread Eric Sandeen
This is mostly to refactor open_ctree(); at the end of the series it's only around 600 lines instead of 900. The first 2 patches are just little cleanups I saw while doing this; the 3rd actually is something of a bugfix. The rest are refactoring - this is a bit of an RFC still; some seem like

[PATCH 06/12] btrfs: factor btrfs_btree_inode_init() out of open_ctree()

2014-08-01 Thread Eric Sandeen
Signed-off-by: Eric Sandeen sand...@redhat.com --- fs/btrfs/disk-io.c | 56 --- 1 files changed, 31 insertions(+), 25 deletions(-) diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c index 8c7113b..6636386 100644 --- a/fs/btrfs/disk-io.c +++

[PATCH 11/12] btrfs: factor btrfs_read_roots() out of open_ctree()

2014-08-01 Thread Eric Sandeen
Also, remove the two local variables create_uuid_tree and check_uuid_tree; we can use the existence of the uuid root and/or the RESCAN_UUID_TREE flag to determine what action to take. Signed-off-by: Eric Sandeen sand...@redhat.com --- fs/btrfs/disk-io.c | 141