Re: 3.2-rc4: scrubbing locks up the kernel, then hung tasks on boot

2012-03-17 Thread Greg Kroah-Hartman
On Sat, Mar 17, 2012 at 10:43:25AM +0100, Martin Steigerwald wrote: > Hi Greg, Chris, Arne, hi everyone, > > Am Freitag, 16. März 2012 schrieb Martin Steigerwald: > > Am Donnerstag, 15. März 2012 schrieb Chris Mason: > > > On Thu, Mar 15, 2012 at 06:32:19PM +0100, Martin Steigerwald wrote: > > > >

Re: 3.2-rc4: scrubbing locks up the kernel, then hung tasks on boot

2012-03-19 Thread Greg Kroah-Hartman
On Mon, Mar 19, 2012 at 09:31:24AM +0100, Martin Steigerwald wrote: > > > > > > This is not the correct way to submit patches for inclusion in the > > stable kernel tree. Please read Documentation/stable_kernel_rules.txt > > for how to do this properly. > > > > > > What point of the rules do

[PATCH] btrfs: no need to check return value of debugfs_create functions

2019-01-04 Thread Greg Kroah-Hartman
When calling debugfs functions, there is no need to ever check the return value. The function can work or not, but the code logic should never do something different based on this. Cc: Chris Mason Cc: Josef Bacik Cc: David Sterba Cc: linux-btrfs@vger.kernel.org Signed-off-by: Greg Kroah

Re: [PATCH] btrfs: no need to check return value of debugfs_create functions

2019-01-04 Thread Greg Kroah-Hartman
On Fri, Jan 04, 2019 at 03:36:59PM +0200, Nikolay Borisov wrote: > > > On 4.01.19 г. 15:25 ч., Greg Kroah-Hartman wrote: > > When calling debugfs functions, there is no need to ever check the > > return value. The function can work or not, but the code logic should &

Re: Security fixes for 4.4 - btrfs

2019-01-14 Thread Greg Kroah-Hartman
On Fri, Jan 11, 2019 at 02:49:11PM +, Ben Hutchings wrote: > I've backported fixes for several security issues involving filesystem > validation in btrfs. All of these are already fixed in the later > stable branches. > > I tested with the reproducers where available. I also checked for > re

Re: [PATCH] btrfs: no need to check return value of debugfs_create functions

2019-01-14 Thread Greg Kroah-Hartman
On Fri, Jan 04, 2019 at 02:44:49PM +0100, David Sterba wrote: > On Fri, Jan 04, 2019 at 02:25:20PM +0100, Greg Kroah-Hartman wrote: > > When calling debugfs functions, there is no need to ever check the > > return value. The function can work or not, but the code logic shou

Re: [PATCH] btrfs: no need to check return value of debugfs_create functions

2019-02-01 Thread Greg Kroah-Hartman
On Thu, Jan 24, 2019 at 05:36:01PM +0100, David Sterba wrote: > On Mon, Jan 14, 2019 at 03:21:04PM +0100, Greg Kroah-Hartman wrote: > > On Fri, Jan 04, 2019 at 02:44:49PM +0100, David Sterba wrote: > > > On Fri, Jan 04, 2019 at 02:25:20PM +0100, Greg Kroah-Hartman wrote: &g

[PATCH 4.14 56/56] stable/btrfs: fix backport bug in d819d97ea025 ("btrfs: honor path->skip_locking in backref code")

2019-07-08 Thread Greg Kroah-Hartman
3 Reported-by: Olivier Mazouffre Fixes: d819d97ea025 ("btrfs: honor path->skip_locking in backref code") Signed-off-by: Stanislaw Gruszka Reviewed-by: Nikolay Borisov Signed-off-by: Greg Kroah-Hartman --- fs/btrfs/backref.c |2 -- 1 file changed, 2 deletions(-) --- a/fs/btrf

[PATCH 4.4 12/36] btrfs: Dont clear SGID when inheriting ACLs

2018-03-09 Thread Greg Kroah-Hartman
05b43a7e34598caef CC: sta...@vger.kernel.org CC: linux-btrfs@vger.kernel.org CC: David Sterba Signed-off-by: Jan Kara Signed-off-by: David Sterba Signed-off-by: Nikolay Borisov Signed-off-by: Greg Kroah-Hartman --- fs/btrfs/acl.c | 13 +++-- 1 file changed, 7 insertions(+), 6 delet

Re: [PATCH 4.14 024/110] btrfs: use proper endianness accessors for super_copy

2018-03-16 Thread Greg Kroah-Hartman
On Thu, Mar 15, 2018 at 07:55:42PM +0100, Christoph Biedl wrote: > Greg Kroah-Hartman wrote... > > > 4.14-stable review patch. If anyone has any objections, please let me know. > > > commit 3c181c12c431fe33b669410d663beb9cceefcd1b upstream. > (...) > > > If t

Re: [PATCH 4.14 024/110] btrfs: use proper endianness accessors for super_copy

2018-03-16 Thread Greg Kroah-Hartman
On Fri, Mar 16, 2018 at 02:22:02PM +0100, David Sterba wrote: > On Fri, Mar 16, 2018 at 01:30:49PM +0100, Greg Kroah-Hartman wrote: > > On Thu, Mar 15, 2018 at 07:55:42PM +0100, Christoph Biedl wrote: > > > Greg Kroah-Hartman wrote... > > > > > > > 4.14-

[PATCH 5.10 28/29] btrfs: fix crash after non-aligned direct IO write with O_DSYNC

2021-02-22 Thread Greg Kroah-Hartman
trfs: dio iomap DSYNC workaround") CC: sta...@vger.kernel.org # 5.10 (and only 5.10) Acked-by: David Sterba Bugzilla: https://bugzilla.suse.com/show_bug.cgi?id=1181605 Signed-off-by: Filipe Manana Signed-off-by: Greg Kroah-Hartman --- fs/btrfs/inode.c |6 +- 1 file changed, 5 i

Re: [PATCH 1/2] fs: btrfs: Fix error path kobject memory leak

2019-05-13 Thread Greg Kroah-Hartman
roy is needed to dispose of the > percpu state which might have been allocated in percpu_counter_init > based on whether CONFIG_SMP is enabled or not? Also, the call to kfree > is required. Both of those will happen in space_info_release() when the kobject is properly disposed of with this last put to the kobject reference. Reviewed-by: Greg Kroah-Hartman

Re: [PATCH 2/2] fs: btrfs: Don't leak memory when failing add fsid

2019-05-13 Thread Greg Kroah-Hartman
t;fsid_kobj); > + return error; > + } > + > + return 0; > } > > int btrfs_sysfs_add_mounted(struct btrfs_fs_info *fs_info) Reviewed-by: Greg Kroah-Hartman

Re: [PATCH 01/14] VFS: Don't use save/replace_mount_options if not using generic_show_options

2017-07-05 Thread Greg Kroah-Hartman
; Signed-off-by: David Howells > cc: Chris Mason > cc: Greg Kroah-Hartman > cc: Steven Rostedt > cc: linux-btrfs@vger.kernel.org > cc: reiserfs-de...@vger.kernel.org For debugfs: Acked-by: Greg Kroah-Hartman -- To unsubscribe from this list: send the line "unsubscribe linux-bt

[PATCH 4.12 031/196] btrfs: Dont clear SGID when inheriting ACLs

2017-07-25 Thread Greg Kroah-Hartman
605b43a7e34598caef CC: linux-btrfs@vger.kernel.org CC: David Sterba Signed-off-by: Jan Kara Signed-off-by: David Sterba Signed-off-by: Greg Kroah-Hartman --- fs/btrfs/acl.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) --- a/fs/btrfs/acl.c +++ b/fs/btrfs/acl.c

[PATCH 4.9 028/125] btrfs: Dont clear SGID when inheriting ACLs

2017-07-25 Thread Greg Kroah-Hartman
605b43a7e34598caef CC: linux-btrfs@vger.kernel.org CC: David Sterba Signed-off-by: Jan Kara Signed-off-by: David Sterba Signed-off-by: Greg Kroah-Hartman --- fs/btrfs/acl.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) --- a/fs/btrfs/acl.c +++ b/fs/btrfs/acl.c