Re: [PATCH v2] btrfs: explicitly set control file's private_data

Am 31.03.2015 14:31 schrieb Tom Van Braeckel: Err, upon further inspection, I think that this was a false positive. Btrfs relies on the initial value of the private_data member of a file being NULL in the regular ioctl operation handler for BTRFS_IOC_TRANS_START but it does not use the miscdevic

[PATCH] btrfs: Don't check for file->private_data on open(). It is set by the core.

The miscdevice core now sets file->private_data to the struct miscdevice so don't fail when this is not NULL. Signed-off-by: Martin Kepplinger --- This is a question: what does this check provide and does overwriting file->private_data make any difference? Is miscdevice's open()

Re: [PATCH] btrfs: Don't check for file->private_data on open(). It is set by the core.

Am 2014-11-12 um 18:59 schrieb Chris Mason: > On Wed, Nov 12, 2014 at 11:38 AM, Martin Kepplinger > wrote: >> The miscdevice core now sets file->private_data to the struct miscdevice >> so don't fail when this is not NULL. >> >> Signed-off-by: Martin Keppling