Re: [PATCH 1/3] BTRFS: support NFSv2 export

2015-09-23 Thread Neil Brown
David Sterba writes: > On Fri, May 08, 2015 at 10:16:23AM +1000, NeilBrown wrote: >> The "fh_len" passed to ->fh_to_* is not guaranteed to be that same as >> that returned by encode_fh - it may be larger. >> >> With NFSv2, the filehandle is fixed length, so it may appear longer >> than expected

Re: [PATCH v5 8/9] vfs: Add vfs_copy_file_range() support for pagecache copies

2015-10-07 Thread Neil Brown
Anna Schumaker writes: > @@ -1338,34 +1362,26 @@ ssize_t vfs_copy_file_range(struct file *file_in, > loff_t pos_in, > struct file *file_out, loff_t pos_out, > size_t len, unsigned int flags) > { > - struct inode *inode_in; > - struct i

[PATCH/RFC] make btrfs subvol mounts appear in /proc/mounts

2015-10-27 Thread Neil Brown
If you create a subvolume in btrfs and access it (by name) without mounting it, then the subvolume looks like a separate mount to some extent, returning a different st_dev to stat(), but it doesn't look like a separate mount in that it isn't listed in /proc/mounts. This inconsistency can confuse t

Re: [PATCH/RFC] make btrfs subvol mounts appear in /proc/mounts

2015-11-02 Thread Neil Brown
On Tue, Nov 03 2015, Chris Mason wrote: > On Mon, Nov 02, 2015 at 03:50:12PM -0500, J. Bruce Fields wrote: >> On Wed, Oct 28, 2015 at 07:25:10AM +0900, Neil Brown wrote: >> > >> > If you create a subvolume in btrfs and access it (by name) without >> > mounting

Re: [dm-devel] [PATCH] block: add a bi_error field to struct bio

2015-06-09 Thread Neil Brown
On Wed, 3 Jun 2015 15:42:39 +0200 Christoph Hellwig wrote: > Currently we have two different ways to signal an I/O error on a BIO: > > (1) by clearing the BIO_UPTODATE flag > (2) by returning a Linux errno value to the bi_end_io callback > > The first one has the drawback of only communicati

Re: What to do about subvolumes?

2010-12-08 Thread Neil Brown
On Mon, 6 Dec 2010 11:48:45 -0500 "J. Bruce Fields" wrote: > On Fri, Dec 03, 2010 at 04:01:44PM -0700, Andreas Dilger wrote: > > On 2010-12-03, at 15:45, J. Bruce Fields wrote: > > > We're using statfs64.fs_fsid for this; I believe that's both stable > > > across reboots and distinguishes between

NFS exporting btrfs subvolumes.

2010-06-01 Thread Neil Brown
NFS needs a unique identifier for a filesystem to be able to export it. This can be set by the admin (fsid= in /etc/exports) but that is a hassle and it is best to set it automatically. nfs-utils currently uses the UUID returned by libblkid if that works, or the fsid returned by statfs64 if libb

Re: NFS exporting btrfs subvolumes.

2010-06-01 Thread Neil Brown
On Tue, 01 Jun 2010 23:56:20 -0400 Trond Myklebust wrote: > On Wed, 2010-06-02 at 13:41 +1000, Neil Brown wrote: > > NFS needs a unique identifier for a filesystem to be able to export it. > > > Can anyone suggest a better way to get a good uuid for a btrfs filesystem? &

[PATCH] Improve support for exporting btrfs subvolumes.

2010-06-16 Thread Neil Brown
If you export two subvolumes of a btrfs filesystem, they will both be given the same uuid so lookups will be confused. blkid cannot differentiate the two, so we must use the fsid from statfs64 to identify the filesystem. We cannot tell if blkid or statfs is best without knowing internal details o

Re: [PATCH] Improve support for exporting btrfs subvolumes.

2010-06-23 Thread Neil Brown
On Wed, 23 Jun 2010 14:28:38 -0400 "J. Bruce Fields" wrote: > On Thu, Jun 17, 2010 at 02:54:01PM +1000, Neil Brown wrote: > > > > If you export two subvolumes of a btrfs filesystem, they will both be > > given the same uuid so lookups will be confused. > > b

Re: [patch v2 1/5] mm: add nofail variants of kmalloc kcalloc and kzalloc

2010-09-02 Thread Neil Brown
On Thu, 2 Sep 2010 16:51:41 +0200 Jan Kara wrote: > On Thu 02-09-10 09:59:13, Jiri Slaby wrote: > > On 09/02/2010 03:02 AM, David Rientjes wrote: > > > --- a/include/linux/slab.h +++ b/include/linux/slab.h @@ -334,6 +334,57 > > > @@ static inline void *kzalloc_node(size_t size, gfp_t flags, int n