Re: [PATCH 1/2] btrfs-progs: Add device management related paragraph.

2014-04-13 Thread Qu Wenruo
Original Message Subject: Re: [PATCH 1/2] btrfs-progs: Add device management related paragraph. From: Marc MERLIN m...@merlins.org To: dste...@suse.cz, Qu Wenruo quwen...@cn.fujitsu.com, linux-btrfs@vger.kernel.org Date: 2014年04月12日 01:52 On Fri, Apr 11, 2014 at 07:36:28PM

Re: wiki vs man pages

2014-04-13 Thread Qu Wenruo
Original Message Subject: Re: wiki vs man pages From: Marc MERLIN m...@merlins.org To: Qu Wenruo quwen...@cn.fujitsu.com Date: 2014年04月14日 09:45 On Mon, Apr 14, 2014 at 09:16:44AM +0800, Qu Wenruo wrote: Generally, would you agree to putting more links to the wiki in man

Re: [RFC] odd thing in btrfs_file_aio_write()

2014-04-13 Thread Qu Wenruo
08:26 end_pos = round_up(pos + iov-iov_len, root-sectorsize); added in commit 3ac0d7b96a268a98bd474cab8bce3a9f125aaccf Author: Qu Wenruo quwen...@cn.fujitsu.com Date: Thu Mar 27 02:51:58 2014 + btrfs: Change the expanding write sequence to fix snapshot related bug

[PATCH v2] btrfs: Change the expanding write sequence to fix snapshot related bug.

2014-04-13 Thread Qu Wenruo
which will first punch a hole covering the write end if a hole is needed. Reported-by: Gui Hecheng guihc.f...@cn.fujitsu.com Signed-off-by: Qu Wenruo quwen...@cn.fujitsu.com Cc: Al Viro v...@zeniv.linux.org.uk Signed-off-by: Chris Mason c...@fb.com --- changelog: v2: Use 'pos + count' instead of 'pos

Re: [RFC] odd thing in btrfs_file_aio_write()

2014-04-13 Thread Qu Wenruo
Original Message Subject: Re: [RFC] odd thing in btrfs_file_aio_write() From: Al Viro v...@zeniv.linux.org.uk To: Qu Wenruo quwen...@cn.fujitsu.com Date: 2014年04月14日 10:48 On Mon, Apr 14, 2014 at 10:35:08AM +0800, Qu Wenruo wrote: Oh, that's my fault, I forgot that iov can

Re: [RFC] odd thing in btrfs_file_aio_write()

2014-04-14 Thread Qu Wenruo
Original Message Subject: Re: [RFC] odd thing in btrfs_file_aio_write() From: Al Viro v...@zeniv.linux.org.uk To: Qu Wenruo quwen...@cn.fujitsu.com Date: 2014年04月14日 13:08 On Mon, Apr 14, 2014 at 11:36:53AM +0800, Qu Wenruo wrote: IOW, is that if (start_pos i_size_read(inode

Re: [PATCH] btrfs-progs: Force 'btrfs dev scan' not using old libblkid cache

2014-04-14 Thread Qu Wenruo
Original Message Subject: Re: [PATCH] btrfs-progs: Force 'btrfs dev scan' not using old libblkid cache From: David Sterba dste...@suse.cz To: Qu Wenruo quwen...@cn.fujitsu.com Date: 2014年04月15日 00:29 On Thu, Apr 10, 2014 at 03:30:21PM +0800, Qu Wenruo wrote: 'btrfs scan

[PATCH] btrfs: Change the hole range to a more accurate value.

2014-04-14 Thread Qu Wenruo
. Reported-by: Al Viro v...@zeniv.linux.org.uk Signed-off-by: Qu Wenruo quwen...@cn.fujitsu.com --- fs/btrfs/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/btrfs/file.c b/fs/btrfs/file.c index eb742c0..a4ce634 100644 --- a/fs/btrfs/file.c +++ b/fs/btrfs/file.c @@ -1777,7

[PATCH 1/4] btrfs-progs: Convert man page for btrfs-restore.

2014-04-15 Thread Qu Wenruo
Convert man page for btrfs-restore, which I forgot to convert in the previous patchset. :P Signed-off-by: Qu Wenruo quwen...@cn.fujitsu.com --- Documentation/Makefile | 1 + Documentation/btrfs-restore.txt | 72 + 2 files changed, 73 insertions

[PATCH 3/4] btrfs-progs: Add btrfs wiki reference to man pages.

2014-04-15 Thread Qu Wenruo
Add btrfs wiki page reference to btrfs-check/btrfsck, btrfs-restore and btrfs-device as supplement. Signed-off-by: Qu Wenruo quwen...@cn.fujitsu.com --- Documentation/btrfs-check.txt | 5 + Documentation/btrfs-device.txt | 10 -- Documentation/btrfs-restore.txt | 4

[PATCH 4/4] btrfs-progs: Fix the return value when executing 'btrfs pro get' on a uncompress file.

2014-04-15 Thread Qu Wenruo
When executing 'btrfs pro get' on a file which is not compressed, return value will always be 50 since prop_compress() return -ENOATTR. But this should be ignored and other prop_XXX() returns 0, so when prop_compress() is executed on uncompress file, it should return 0. Signed-off-by: Qu Wenruo

[PATCH 2/4] btrfs-progs: Convert man page for btrfs-property.

2014-04-15 Thread Qu Wenruo
Convert the man page for the newly added btrfs-property subcommand. Signed-off-by: Qu Wenruo quwen...@cn.fujitsu.com --- Documentation/Makefile | 1 + Documentation/btrfs-property.txt | 69 2 files changed, 70 insertions(+) create mode 100644

Re: [PATCH 4/4] btrfs-progs: Fix the return value when executing 'btrfs pro get' on a uncompress file.

2014-04-15 Thread Qu Wenruo
Original Message Subject: Re: [PATCH 4/4] btrfs-progs: Fix the return value when executing 'btrfs pro get' on a uncompress file. From: Filipe David Manana fdman...@gmail.com To: Qu Wenruo quwen...@cn.fujitsu.com Date: 2014年04月15日 17:09 On Tue, Apr 15, 2014 at 8:04 AM, Qu

[PATCH v2 4/4] btrfs-progs: Fix the return value when executing 'btrfs pro get' on a uncompress file.

2014-04-15 Thread Qu Wenruo
When executing 'btrfs pro get' on a file which is not compressed, return value will always be 50 since prop_compress() return -ENOATTR. But the codes have already check the errno to avoid unnecessary error message, so the return value should also set to 0. Signed-off-by: Qu Wenruo quwe

Re: [PATCH] btrfs-progs: Force 'btrfs dev scan' not using old libblkid cache

2014-04-15 Thread Qu Wenruo
Original Message Subject: Re: [PATCH] btrfs-progs: Force 'btrfs dev scan' not using old libblkid cache From: David Sterba dste...@suse.cz To: Qu Wenruo quwen...@cn.fujitsu.com Date: 2014年04月15日 00:29 On Thu, Apr 10, 2014 at 03:30:21PM +0800, Qu Wenruo wrote: 'btrfs scan

Re: [PATCH] btrfs-progs: Force 'btrfs dev scan' not using old libblkid cache

2014-04-15 Thread Qu Wenruo
Original Message Subject: Re: [PATCH] btrfs-progs: Force 'btrfs dev scan' not using old libblkid cache From: Qu Wenruo quwen...@cn.fujitsu.com To: dste...@suse.cz, linux-btrfs@vger.kernel.org Date: 2014年04月16日 09:24 Original Message Subject: Re: [PATCH

[PATCH RFC] btrfs: Add ctime/mtime update for btrfs device add/remove.

2014-04-16 Thread Qu Wenruo
-by: Tsutomu Itoh t-i...@jp.fujitsu.com Cc: Karel Zak k...@redhat.com Signed-off-by: Qu Wenruo quwen...@cn.fujitsu.com --- fs/btrfs/volumes.c | 26 -- 1 file changed, 24 insertions(+), 2 deletions(-) diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c index 49d7fab..ce232d7

Re: [PATCH] btrfs-progs: doc: link btrfsck to btrfs-check

2014-04-16 Thread Qu Wenruo
to the btrfs-check.8 manpage. CC: Qu Wenruo quwen...@cn.fujitsu.com Signed-off-by: David Sterba dste...@suse.cz --- Documentation/Makefile| 2 ++ Documentation/btrfs-check.txt | 3 ++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/Documentation/Makefile b/Documentation

[PATCH] btrfs: Add check to avoid cleanup roots already in fs_info-dead_roots.

2014-04-22 Thread Qu Wenruo
Current btrfs_orphan_cleanup will also cleanup roots which is already in fs_info-dead_roots without protection. This will have conditional race with fs_info-cleaner_kthread. This patch will use refs in root-root_item to detect roots in dead_roots and avoid conflicts. Signed-off-by: Qu Wenruo

Re: [PATCH v2 4/4] btrfs-progs: Fix the return value when executing 'btrfs pro get' on a uncompress file.

2014-04-22 Thread Qu Wenruo
Original Message Subject: Re: [PATCH v2 4/4] btrfs-progs: Fix the return value when executing 'btrfs pro get' on a uncompress file. From: David Sterba dste...@suse.cz To: Qu Wenruo quwen...@cn.fujitsu.com Date: 2014年04月22日 20:37 On Tue, Apr 15, 2014 at 05:22:24PM +0800, Qu

[PATCH 2/2] btrfs-progs: Replace the overkill assert with normal error message.

2014-04-28 Thread Qu Wenruo
When 'btrfs replace status' encounters an unknown dev replace status, it will cause an assert, which is somewhat overkilled and can be replaced with a normal error message. Signed-off-by: Qu Wenruo quwen...@cn.fujitsu.com --- cmds-replace.c | 9 ++--- 1 file changed, 6 insertions(+), 3

[PATCH 1/2] btrfs-progs: Improve the errno string about open_path_or_dev_mnt()

2014-04-28 Thread Qu Wenruo
for open_path_or_dev_mnt() caller and print more meaningful error message when a unmounted btrfs device path is given. Signed-off-by: Qu Wenruo quwen...@cn.fujitsu.com --- cmds-device.c | 8 +++- cmds-replace.c | 9 +++-- cmds-scrub.c | 25 + 3 files changed, 35 insertions(+), 7

[RFC PATCH 0/2] Kernel space btrfs missing device detection.

2014-05-06 Thread Qu Wenruo
caring about missing device. This patchset will do ioctl time missing dev detection and return device missing status in dev_info ioctl using a new member in btrfs_ioctl_dev_info_args with a backward compatible method. Cc: Anand Jain anand.j...@oracle.com Qu Wenruo (2): btrfs: Add missing device

[RFC PATCH 2/2] btrfs-progs: Add userspace support for kernel missing dev detection.

2014-05-06 Thread Qu Wenruo
will be printed showing 'btrfs dev del missing' will not work. Signed-off-by: Qu Wenruo quwen...@cn.fujitsu.com --- cmds-filesystem.c | 29 ++--- utils.c | 2 ++ 2 files changed, 24 insertions(+), 7 deletions(-) diff --git a/cmds-filesystem.c b/cmds-filesystem.c

[RFC PATCH 2/2] btrfs: Add new member of btrfs_ioctl_dev_info_args.

2014-05-06 Thread Qu Wenruo
Add flags member for btrfs_ioctl_dev_info_args to preset missing btrfs devices. The new member is added in the original padding area so the ioctl API is not affected but user headers needs to be updated. Cc: Anand Jain anand.j...@oracle.com Signed-off-by: Qu Wenruo quwen...@cn.fujitsu.com

[RFC PATCH 1/2] btrfs: Add missing device check in dev_info/rm_dev ioctl

2014-05-06 Thread Qu Wenruo
not really cares about missing device. Cc: Anand Jain anand.j...@oracle.com Signed-off-by: Qu Wenruo quwen...@cn.fujitsu.com --- fs/btrfs/ioctl.c | 1 + fs/btrfs/volumes.c | 25 - fs/btrfs/volumes.h | 2 ++ 3 files changed, 27 insertions(+), 1 deletion(-) diff --git a/fs

[RFC PATCH 1/2] btrfs-progs: Follow kernel changes to add new member of btrfs_ioctl_dev_info_args.

2014-05-06 Thread Qu Wenruo
Follow the kernel header changes to add new member of btrfs_ioctl_dev_info_args. This change will use special bit to keep backward compatibility, so even on old kernels this will not screw anything up. Signed-off-by: Qu Wenruo quwen...@cn.fujitsu.com --- ioctl.h | 5 - 1 file changed, 4

Re: [RFC PATCH 0/2] Kernel space btrfs missing device detection.

2014-05-06 Thread Qu Wenruo
Original Message Subject: Re: [RFC PATCH 0/2] Kernel space btrfs missing device detection. From: Goffredo Baroncelli kreij...@libero.it To: Qu Wenruo quwen...@cn.fujitsu.com, linux-btrfs@vger.kernel.org Date: 2014年05月07日 02:10 Hi, instead of extending the BTRFS_IOCTL_DEV_INFO

Re: [RFC PATCH 1/2] btrfs: Add missing device check in dev_info/rm_dev ioctl

2014-05-07 Thread Qu Wenruo
Original Message Subject: Re: [RFC PATCH 1/2] btrfs: Add missing device check in dev_info/rm_dev ioctl From: Anand Jain anand.j...@oracle.com To: Qu Wenruo quwen...@cn.fujitsu.com Date: 2014年05月07日 16:00 Thanks for working on this. I am running some tests will let you know

Re: [PATCH] btrfs-progs: doc: link btrfsck to btrfs-check

2014-05-07 Thread Qu Wenruo
Original Message Subject: Re: [PATCH] btrfs-progs: doc: link btrfsck to btrfs-check From: David Sterba dste...@suse.cz To: Qu Wenruo quwen...@cn.fujitsu.com Date: 2014年04月18日 22:48 On Thu, Apr 17, 2014 at 08:47:28AM +0800, Qu Wenruo wrote: @@ -73,6 +74,7 @@ install: install

[PATCH] btrfs-progs: Remove unneeded assert in find_good_parent().

2014-05-11 Thread Qu Wenruo
the assert can be removed without any problem. Signed-off-by: Qu Wenruo quwen...@cn.fujitsu.com --- cmds-send.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/cmds-send.c b/cmds-send.c index ff17092..9a73b32 100644 --- a/cmds-send.c +++ b/cmds-send.c @@ -132,7 +132,10 @@ static

[PATCH 2/2] Btrfs: fix NULL pointer crash when running balance and scrub concurrently

2014-05-14 Thread Qu Wenruo
count. Reported-by: Qu Wenruo quwen...@cn.fujitsu.com Signed-off-by: Wang Shilong wangsl.f...@cn.fujitsu.com --- fs/btrfs/extent_map.c | 2 ++ fs/btrfs/extent_map.h | 1 + fs/btrfs/volumes.c| 10 +++--- 3 files changed, 6 insertions(+), 7 deletions(-) diff --git a/fs/btrfs/extent_map.c b

Re: [PATCH 00/27] Replace the old man page with asciidoc and man page for each btrfs subcommand.

2014-05-18 Thread Qu Wenruo
Original Message Subject: Re: [PATCH 00/27] Replace the old man page with asciidoc and man page for each btrfs subcommand. From: Hugo Mills h...@carfax.org.uk To: dste...@suse.cz, Qu Wenruo quwen...@cn.fujitsu.com, linux-btrfs@vger.kernel.org, c...@fb.com Date: 2014年05月18日

Re: [PATCH 00/27] Replace the old man page with asciidoc and man page for each btrfs subcommand.

2014-05-18 Thread Qu Wenruo
Original Message Subject: Re: [PATCH 00/27] Replace the old man page with asciidoc and man page for each btrfs subcommand. From: Hugo Mills h...@carfax.org.uk To: dste...@suse.cz, Qu Wenruo quwen...@cn.fujitsu.com, linux-btrfs@vger.kernel.org, c...@fb.com Date: 2014年05月18日

Re: [PATCH 00/27] Replace the old man page with asciidoc and man page for each btrfs subcommand.

2014-05-18 Thread Qu Wenruo
Original Message Subject: Re: [PATCH 00/27] Replace the old man page with asciidoc and man page for each btrfs subcommand. From: Hugo Mills h...@carfax.org.uk To: Qu Wenruo quwen...@cn.fujitsu.com Date: 2014年05月18日 20:05 On Sun, May 18, 2014 at 03:04:33PM +0800, Qu Wenruo

Re: [PATCH 00/27] Replace the old man page with asciidoc and man page for each btrfs subcommand.

2014-05-19 Thread Qu Wenruo
Original Message Subject: Re: [PATCH 00/27] Replace the old man page with asciidoc and man page for each btrfs subcommand. From: David Sterba dste...@suse.cz To: Hugo Mills h...@carfax.org.uk, Qu Wenruo quwen...@cn.fujitsu.com, linux-btrfs@vger.kernel.org, c...@fb.com Date

[PATCH] btrfs-progs: Improve the parse_size() error message.

2014-05-20 Thread Qu Wenruo
size value (like -1K) Also this patch will take full use of endptr returned by strtoll() to reduce unneeded loop. Reported-by: Hidetoshi Seto seto.hideto...@jp.fujitsu.com Signed-off-by: Qu Wenruo quwen...@cn.fujitsu.com --- utils.c | 53 + 1

Re: [RFC PATCH 1/2] btrfs: Add missing device check in dev_info/rm_dev ioctl

2014-05-20 Thread Qu Wenruo
I'm sorry to bother your but it has been about 2 weeks after your last reply. Is there any problem? Thanks, Qu Original Message Subject: Re: [RFC PATCH 1/2] btrfs: Add missing device check in dev_info/rm_dev ioctl From: Anand Jain anand.j...@oracle.com To: Qu Wenruo quwen

Re: [RFC PATCH 1/2] btrfs: Add missing device check in dev_info/rm_dev ioctl

2014-05-20 Thread Qu Wenruo
Original Message Subject: Re: [RFC PATCH 1/2] btrfs: Add missing device check in dev_info/rm_dev ioctl From: Anand Jain anand.j...@oracle.com To: Qu Wenruo quwen...@cn.fujitsu.com Date: 2014年05月21日 11:54 Hi Qu, Thanks for checking with me. sorry for the delay

Should btrfs reuse the src_dev's dev UUID when doing dev replacing?

2014-05-21 Thread Qu Wenruo
Hi, [Current dev replace] As kernel codes show, 'btrfs dev replace' will swap tgt_dev's uuid with src_dev's uuid. This method works fine most of the time, since it doesn't need to change the chunk tree. [Problem with re-appear missing device] (Anand Jain reported the problem in Jan 2014)

Re: [PATCH] btrfs-progs: Improve the parse_size() error message.

2014-05-28 Thread Qu Wenruo
Thanks for the commenting. Original Message Subject: Re: [PATCH] btrfs-progs: Improve the parse_size() error message. From: David Sterba dste...@suse.cz To: Qu Wenruo quwen...@cn.fujitsu.com Date: 2014年05月29日 01:20 On Tue, May 20, 2014 at 03:51:45PM +0800, Qu Wenruo wrote

Re: [PATCH] btrfs-progs: Improve the parse_size() error message.

2014-05-28 Thread Qu Wenruo
Original Message Subject: Re: [PATCH] btrfs-progs: Improve the parse_size() error message. From: Mike Fleetwood mike.fleetw...@googlemail.com To: Qu Wenruo quwen...@cn.fujitsu.com Date: 2014年05月29日 05:07 On 20 May 2014 08:51, Qu Wenruo quwen...@cn.fujitsu.com wrote: When

[PATCH] btrfs-progs: Add dev uuid output for print_dev_item().

2014-05-28 Thread Qu Wenruo
The original print_dev_item() only prints device id,total bytes and bytes used. When it comes to debug things related to duplicated device id, dev uuid is needed to distinguish different device since device is is no reliable. This patch added dev uuid output. Signed-off-by: Qu Wenruo quwen

[PATCH v2] btrfs-progs: Improve the parse_size() error message.

2014-05-28 Thread Qu Wenruo
size value (like -1K) Also this patch will take full use of endptr returned by strtoll() to reduce unneeded loop. Signed-off-by: Qu Wenruo quwen...@cn.fujitsu.com --- utils.c | 56 +++- 1 file changed, 39 insertions(+), 17 deletions(-) diff

Re: [PATCH RFC] btrfs: Add ctime/mtime update for btrfs device add/remove.

2014-05-29 Thread Qu Wenruo
Original Message Subject: Re: [PATCH RFC] btrfs: Add ctime/mtime update for btrfs device add/remove. From: David Sterba dste...@suse.cz To: Qu Wenruo quwen...@cn.fujitsu.com Date: 2014年05月29日 20:43 On Wed, Apr 16, 2014 at 05:02:32PM +0800, Qu Wenruo wrote: @@ -1704,10

[PATCH v2] btrfs-progs: Add dev uuid output for print_dev_item().

2014-05-29 Thread Qu Wenruo
helpful) This patch adds dev uuid output for print_dev_item(). Signed-off-by: Qu Wenruo quwen...@cn.fujitsu.com --- changelog: v2: Remove typos from comment message. --- print-tree.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/print-tree.c b/print-tree.c

[PATCH] btrfs: Avoid trucating page or punching hole in a already existed hole.

2014-05-30 Thread Qu Wenruo
btrfs_punch_hole() will truncate unaligned pages or punch hole on a already existed hole. This will cause unneeded zero page or holes splitting the original huge hole. This patch will skip already existed holes before any page truncating or hole punching. Signed-off-by: Qu Wenruo quwen

Re: [PATCH RFC] btrfs: Add ctime/mtime update for btrfs device add/remove.

2014-05-30 Thread Qu Wenruo
Original Message Subject: Re: [PATCH RFC] btrfs: Add ctime/mtime update for btrfs device add/remove. From: Anand Jain anand.j...@oracle.com To: Qu Wenruo quwen...@cn.fujitsu.com, linux-btrfs@vger.kernel.org Date: 2014年05月30日 15:51 Hi Qu, In line below... On 16/04/14

[PATCH] btrfs-progs: Documentation: Add filter section for btrfs-balance.

2014-06-03 Thread Qu Wenruo
Man page for 'btrfs-balance' mentioned filters but does not explain them, which make end users hard to use '-d', '-m' or '-s options. This patch will use the explanations from https://btrfs.wiki.kernel.org/index.php/Balance_Filters to enrich the man page. Signed-off-by: Qu Wenruo quwen

Re: Should btrfs reuse the src_dev's dev UUID when doing dev replacing?

2014-06-03 Thread Qu Wenruo
Original Message Subject: Re: Should btrfs reuse the src_dev's dev UUID when doing dev replacing? From: Anand Jain anand.j...@oracle.com To: Qu Wenruo quwen...@cn.fujitsu.com, linux-btrfs linux-btrfs@vger.kernel.org Date: 2014年05月22日 11:09 Thanks Qu for bringing up

Re: [PATCH RFC] btrfs: Add ctime/mtime update for btrfs device add/remove.

2014-06-03 Thread Qu Wenruo
Original Message Subject: Re: [PATCH RFC] btrfs: Add ctime/mtime update for btrfs device add/remove. From: David Sterba dste...@suse.cz To: Qu Wenruo quwen...@cn.fujitsu.com Date: 2014年05月29日 20:43 On Wed, Apr 16, 2014 at 05:02:32PM +0800, Qu Wenruo wrote: @@ -1704,10

Re: [PATCH 1/1] btrfs-progs: fix compiler warning

2014-06-04 Thread Qu Wenruo
Original Message Subject: [PATCH 1/1] btrfs-progs: fix compiler warning From: Christian Hesse m...@eworm.de To: linux-btrfs@vger.kernel.org Date: 2014年06月03日 19:29 gcc 4.9.0 gives a warning: array subscript is above array bounds Checking for greater or equal instead of just

Re: latest btrfs-progs and asciidoc dependency

2014-06-05 Thread Qu Wenruo
Original Message Subject: Re: latest btrfs-progs and asciidoc dependency From: Fajar A. Nugraha l...@fajar.net To: Tomasz Chmielewski t...@virtall.com Date: 2014年06月05日 22:51 On Thu, Jun 5, 2014 at 9:41 PM, Marc MERLIN m...@merlins.org wrote: On Thu, Jun 05, 2014 at

Re: [PATCH V3] Btrfs: device_list_add() should not update list when mounted

2014-06-08 Thread Qu Wenruo
Original Message Subject: [PATCH V3] Btrfs: device_list_add() should not update list when mounted From: Anand Jain anand.j...@oracle.com To: linux-btrfs@vger.kernel.org Date: 2014年06月06日 11:26 (looks like there was some sendmail problem I don't see this in the btrfs list,

Re: [PATCH V3] Btrfs: device_list_add() should not update list when mounted

2014-06-08 Thread Qu Wenruo
Original Message Subject: Re: [PATCH V3] Btrfs: device_list_add() should not update list when mounted From: Anand Jain anand.j...@oracle.com To: Qu Wenruo quwen...@cn.fujitsu.com, linux-btrfs@vger.kernel.org Date: 2014年06月09日 10:19 Hi Qu, Thanks for your patch. The patch

Re: [PATCH V3] Btrfs: device_list_add() should not update list when mounted

2014-06-09 Thread Qu Wenruo
Original Message Subject: [PATCH V3] Btrfs: device_list_add() should not update list when mounted From: Anand Jain anand.j...@oracle.com To: linux-btrfs@vger.kernel.org Date: 2014年06月06日 11:26 (looks like there was some sendmail problem I don't see this in the btrfs list,

[PATCH] btrfs: When devices with same dev uuid occurs, only add the one with largest generation.

2014-06-10 Thread Qu Wenruo
device A even device B has a larger generation. The patch will judge generation when difference device with same dev uuid. And the patch should be applied after Anand's patch: https://patchwork.kernel.org/patch/4309651/ Cc: Anand Jain anand.j...@oracle.com Signed-off-by: Qu Wenruo quwen

[PATCH v2 2/2] btrfs-progs: Add human readable flags output for chunk/block group type.

2014-06-12 Thread Qu Wenruo
Current btrfs-debug-tree output chunk/block group type as numbers, which makes it hard to understand and need to check the source to understand the meaning. This patch will convert numberic type output to human readable strings. Signed-off-by: Qu Wenruo quwen...@cn.fujitsu.com --- changlog: v2

[PATCH v2 1/2] btrfs-progs: Add human readable flags output string for extent flags.

2014-06-12 Thread Qu Wenruo
Current btrfs-debug-tree outputs extent flags as numbers, which makes it hard to understand and need to check the source to understand the meaning. This patch will convert numberic flags output to human readable strings. Signed-off-by: Qu Wenruo quwen...@cn.fujitsu.com --- changlog: v2: none

Re: [PATCH v2] btrfs-progs: Improve the parse_size() error message.

2014-06-12 Thread Qu Wenruo
Original Message Subject: Re: [PATCH v2] btrfs-progs: Improve the parse_size() error message. From: David Sterba dste...@suse.cz To: Qu Wenruo quwen...@cn.fujitsu.com Date: 2014年06月12日 18:15 On Thu, May 29, 2014 at 09:42:11AM +0800, Qu Wenruo wrote: When using parse_size

[PATCH v3] btrfs-progs: Improve the parse_size() error message.

2014-06-12 Thread Qu Wenruo
size value (like -1K) Also this patch will take full use of endptr returned by strtoll() to reduce unneeded loop. Signed-off-by: Qu Wenruo quwen...@cn.fujitsu.com --- changlog: v2: Remove uneeded return value Avoid abuse of goto v3: Don't reparse size twice Better u64 overflow check

[PATCH v3] btrfs-progs: Add human readable flags output for chunk/block group type.

2014-06-17 Thread Qu Wenruo
Current btrfs-debug-tree output chunk/block group type as numbers, which makes it hard to understand and need to check the source to understand the meaning. This patch will convert numeric type output to human readable strings. Signed-off-by: Qu Wenruo quwen...@cn.fujitsu.com --- changelog: v2

[PATCH] btrfs-progs: Add minimum device size check.

2014-06-18 Thread Qu Wenruo
* (system block group + global block rsv) Signed-off-by: Qu Wenruo quwen...@cn.fujitsu.com --- mkfs.c | 24 utils.c | 30 ++ utils.h | 13 + 3 files changed, 67 insertions(+) diff --git a/mkfs.c b/mkfs.c index 16e9222..58c751c 100644

[PATCH] btrfs-progs: Add minimum device size check.

2014-06-18 Thread Qu Wenruo
* (system block group + global block rsv) Signed-off-by: Qu Wenruo quwen...@cn.fujitsu.com --- mkfs.c | 24 utils.c | 30 ++ utils.h | 13 + 3 files changed, 67 insertions(+) diff --git a/mkfs.c b/mkfs.c index 16e9222..58c751c 100644

[PATCH v2] btrfs-progs: Add minimum device size check.

2014-06-19 Thread Qu Wenruo
* (system block group + global block rsv) and global block rsv = leafsize 10 Signed-off-by: Qu Wenruo quwen...@cn.fujitsu.com --- changelog: v2: Use leafsize to get consistent with kernel global_block_rsv calculation. --- mkfs.c | 28 utils.c | 20

Re: [PATCH] btrfs-progs: Add minimum device size check.

2014-06-23 Thread Qu Wenruo
Original Message Subject: Re: [PATCH] btrfs-progs: Add minimum device size check. From: David Sterba dste...@suse.cz To: Qu Wenruo quwen...@cn.fujitsu.com Date: 2014年06月23日 22:36 On Thu, Jun 19, 2014 at 11:25:38AM +0800, Qu Wenruo wrote: Btrfs has global block reservation, so

[PATCH v3] btrfs-progs: Add minimum device size check.

2014-06-23 Thread Qu Wenruo
* (system block group + global block rsv) and global block rsv = leafsize 10 Signed-off-by: Qu Wenruo quwen...@cn.fujitsu.com --- changelog: v2: Use leafsize to get consistent with kernel global_block_rsv calculation. v3: Change words in error string. Use separate inline function to calculate

[PATCH] btrfs: Don't continue mounting when superblock csum mismatches even generation is less than 10.

2014-06-24 Thread Qu Wenruo
to the change of super offset. So backward compatibility is not a problem. Signed-off-by: Qu Wenruo quwen...@cn.fujitsu.com --- fs/btrfs/disk-io.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c index 8bb4aa1..dbfb2a3 100644 --- a/fs/btrfs/disk-io.c +++ b

Re: [PATCH, RFC] btrfs: refactor open_ctree()

2014-06-25 Thread Qu Wenruo
Original Message Subject: [PATCH, RFC] btrfs: refactor open_ctree() From: Eric Sandeen sand...@redhat.com To: linux-btrfs linux-btrfs@vger.kernel.org Date: 2014年06月26日 07:55 First off: total RFC, don't merge this; it builds, but is totally untested. open_ctree() is almost

[PATCH] btrfs-progs: Check superblock's checksum in btrfs-progs.

2014-06-26 Thread Qu Wenruo
Btrfs-progs will read the superblock without checking the checksum. When all superblocks are corrupted, continuing will cause disaster. So this patch will add checksum check for btrfs-progs when reading superblocks. Signed-off-by: Qu Wenruo quwen...@cn.fujitsu.com --- disk-io.c | 15

[PATCH RFC] btrfs: Use backup superblocks if and only if the first superblock is valid but corrupted.

2014-06-26 Thread Qu Wenruo
rescue super' method is still available. 2) If the magic number in the first superblock matches but checksum does not match: This filesystem is btrfs but first superblock is corrupted, use backup roots. Just continue searching remaining superblocks. Signed-off-by: Qu Wenruo quwen

Re: [PATCH] btrfs: fix nossd and ssd_spread mount option regression

2014-06-29 Thread Qu Wenruo
Oh, my bad, sorry for the SSD related mount options mess. Thanks for the patch fixing the bug, comments inlined below. Original Message Subject: [PATCH] btrfs: fix nossd and ssd_spread mount option regression From: Eric Sandeen sand...@redhat.com To: linux-btrfs

Re: Can't mount subvolume with ro option

2014-06-29 Thread Qu Wenruo
Original Message Subject: Re: Can't mount subvolume with ro option From: Sébastien ROHAUT sebastien.roh...@free.fr To: Chris Murphy li...@colorremedies.com Date: 2014年06月28日 19:02 Le 28/06/2014 00:12, Chris Murphy a écrit : On Jun 27, 2014, at 4:08 PM, Chris Murphy

Re: Can't mount subvolume with ro option

2014-06-29 Thread Qu Wenruo
Original Message Subject: Re: Can't mount subvolume with ro option From: Qu Wenruo quwen...@cn.fujitsu.com To: Sébastien ROHAUT sebastien.roh...@free.fr, Chris Murphy li...@colorremedies.com Date: 2014年06月30日 10:19 Original Message Subject: Re: Can't mount

[RFC PATCH] Revert btrfs: allow mounting btrfs subvolumes with different ro/rw options

2014-07-01 Thread Qu Wenruo
ro/rw option in subvolume) Signed-off-by: Qu Wenruo quwen...@cn.fujitsu.com Conflicts: fs/btrfs/super.c --- fs/btrfs/super.c | 26 -- 1 file changed, 26 deletions(-) diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c index 4662d92..4a088f8 100644 --- a/fs/btrfs

[PATCH v2] btrfs: fix nossd and ssd_spread mount option regression

2014-07-01 Thread Qu Wenruo
handling is still pretty odd: Reported-by: Roman Mamedov r...@romanrm.net Signed-off-by: Eric Sandeen sand...@redhat.com Signed-off-by: Qu Wenruo quwen...@cn.fujitsu.com --- v2(By Qu): Make nossd disable ssd and ssd_spread. Add notes in Documentation/btrfs.txt --- Documentation/filesystems/btrfs.txt

Re: btrfs fi df mount point outputs info instead of error even when mount-point is just a directory

2014-07-02 Thread Qu Wenruo
Original Message Subject: btrfs fi df mount point outputs info instead of error even when mount-point is just a directory From: Vikram Goyal vikigo...@gmail.com To: linux-btrfs@vger.kernel.org Date: 2014年07月02日 13:14 Hi, As the subject specifies there is some confusion (at

Re: [RFC PATCH] Revert btrfs: allow mounting btrfs subvolumes with different ro/rw options

2014-07-02 Thread Qu Wenruo
Original Message Subject: Re: [RFC PATCH] Revert btrfs: allow mounting btrfs subvolumes with different ro/rw options From: Harald Hoyer har...@redhat.com To: Chris Mason c...@fb.com, dste...@suse.cz, Qu Wenruo quwen...@cn.fujitsu.com, linux-btrfs@vger.kernel.org Date: 2014年

Re: [PATCH] btrfs-progs: Check superblock's checksum in btrfs-progs.

2014-07-02 Thread Qu Wenruo
Message Subject: [PATCH] btrfs-progs: Check superblock's checksum in btrfs-progs. From: Qu Wenruo quwen...@cn.fujitsu.com To: linux-btrfs@vger.kernel.org Date: 2014年06月27日 10:34 Btrfs-progs will read the superblock without checking the checksum. When all superblocks are corrupted, continuing

Re: [PATCH v2] btrfs: fix nossd and ssd_spread mount option regression

2014-07-02 Thread Qu Wenruo
Original Message Subject: Re: [PATCH v2] btrfs: fix nossd and ssd_spread mount option regression From: Eric Sandeen sand...@redhat.com To: Qu Wenruo quwen...@cn.fujitsu.com, linux-btrfs@vger.kernel.org Date: 2014年07月03日 00:12 On 7/1/14, 11:19 PM, Qu Wenruo wrote: From: Eric

Re: [RFC PATCH] Revert btrfs: allow mounting btrfs subvolumes with different ro/rw options

2014-07-02 Thread Qu Wenruo
Original Message Subject: Re: [RFC PATCH] Revert btrfs: allow mounting btrfs subvolumes with different ro/rw options From: Goffredo Baroncelli kreij...@libero.it To: Qu Wenruo quwen...@cn.fujitsu.com, linux-btrfs@vger.kernel.org Date: 2014年07月03日 01:48 On 07/01/2014 11:30 AM

Re: [RFC PATCH] Revert btrfs: allow mounting btrfs subvolumes with different ro/rw options

2014-07-03 Thread Qu Wenruo
Original Message Subject: Re: [RFC PATCH] Revert btrfs: allow mounting btrfs subvolumes with different ro/rw options From: Tobias Geerinckx-Rice tobias.geerinckx.r...@gmail.com To: Qu Wenruo quwen...@cn.fujitsu.com Date: 2014年07月03日 16:06 [List CCd. I hate Gmail.] Noob

[PATCH 0/4] Add superblock checksum check for btrfs-progs

2014-07-03 Thread Qu Wenruo
(), making btrfs-progs much more restricted and robust. To allow super-recover to open devices, add options to scan all 3 superblocks when using super-recover. Also updated the related error string and fix a bug in chunk-recover that will not be triggered until superblock csum is calculated. Qu

[PATCH 2/4] btrfs-progs: Allow btrfs_read_dev_super() to read all 3 super for super_recover.

2014-07-03 Thread Qu Wenruo
() and callers to allow scan backup superblocks if needed. Signed-off-by: Qu Wenruo quwen...@cn.fujitsu.com --- btrfs-find-root.c | 4 ++-- chunk-recover.c | 6 +++--- cmds-filesystem.c | 2 +- disk-io.c | 17 ++--- disk-io.h | 5 +++-- super-recover.c | 2

[PATCH 3/4] btrfs-progs: Add more meaningful return value for btrfs_read_dev_super() and corresponding error string.

2014-07-03 Thread Qu Wenruo
Since btrfs_read_dev_super() now can distinguish non-btrfs fs and corrupted superblock thanks for the newly introduced super csum check, the return value and corresponding error string should also be updated to print more meaningful errors for end users. Signed-off-by: Qu Wenruo quwen

[PATCH 0/4] Add superblock checksum check for btrfs-progs

2014-07-03 Thread Qu Wenruo
(), making btrfs-progs much more restricted and robust. To allow super-recover to open devices, add options to scan all 3 superblocks when using super-recover. Also updated the related error string and fix a bug in chunk-recover that will not be triggered until superblock csum is calculated. Qu

[PATCH 4/4] btrfs-progs: Fix malloc size for superblock.

2014-07-03 Thread Qu Wenruo
recover_prepare() in chunk-recover.c alloc memory which only contains sizeof(struct btrfs_super_block). This will cause glibc malloc error after superblock csum is calculated. Use BTRFS_SUPER_INFO_SIZE to fix the bug. Signed-off-by: Qu Wenruo quwen...@cn.fujitsu.com --- chunk-recover.c | 2

[PATCH v2 1/4] btrfs-progs: Check superblock's checsum when read dev super

2014-07-03 Thread Qu Wenruo
btrfs_super_block), corrent size should be BTRFS_SUPER_INFO_SIZE. Signed-off-by: Qu Wenruo quwen...@cn.fujitsu.com --- v2: Use corrent memcmp src. Read the whole supblock size(sectorsize) other than sizeof(btrfs_super_block). --- disk-io.c | 46 +- 1 file

[PATCH 2/4] btrfs-progs: Allow btrfs_read_dev_super() to read all 3 super for super_recover.

2014-07-03 Thread Qu Wenruo
() and callers to allow scan backup superblocks if needed. Signed-off-by: Qu Wenruo quwen...@cn.fujitsu.com --- btrfs-find-root.c | 4 ++-- chunk-recover.c | 6 +++--- cmds-filesystem.c | 2 +- disk-io.c | 17 ++--- disk-io.h | 5 +++-- super-recover.c | 2

[PATCH v2 1/4] btrfs-progs: Check superblock's checsum when read dev super

2014-07-03 Thread Qu Wenruo
btrfs_super_block), corrent size should be BTRFS_SUPER_INFO_SIZE. Signed-off-by: Qu Wenruo quwen...@cn.fujitsu.com --- v2: Use corrent memcmp src. Read the whole supblock size(sectorsize) other than sizeof(btrfs_super_block). --- disk-io.c | 46 +- 1 file

Re: [PATCH 0/4] Add superblock checksum check for btrfs-progs

2014-07-03 Thread Qu Wenruo
Original Message Subject: Re: [PATCH 0/4] Add superblock checksum check for btrfs-progs From: David Sterba dste...@suse.cz To: Qu Wenruo quwen...@cn.fujitsu.com Date: 2014年07月04日 01:57 On Thu, Jul 03, 2014 at 05:36:34PM +0800, Qu Wenruo wrote: Before this patchset, btrfs

Re: [RFC PATCH] Revert btrfs: allow mounting btrfs subvolumes with different ro/rw options

2014-07-03 Thread Qu Wenruo
Original Message Subject: Re: [RFC PATCH] Revert btrfs: allow mounting btrfs subvolumes with different ro/rw options From: Goffredo Baroncelli kreij...@inwind.it To: Qu Wenruo quwen...@cn.fujitsu.com, linux-btrfs@vger.kernel.org Date: 2014年07月04日 01:37 On 07/03/2014 02:28 AM

[PATCH v2 3/4] btrfs-progs: Add more meaningful return value for btrfs_read_dev_super() and corresponding error string.

2014-07-03 Thread Qu Wenruo
Since btrfs_read_dev_super() now can distinguish non-btrfs fs and corrupted superblock thanks for the newly introduced super csum check, the return value and corresponding error string should also be updated to print more meaningful errors for end users. Signed-off-by: Qu Wenruo quwen

Re: [PATCH] Btrfs: fix wrong uevent target

2014-07-03 Thread Qu Wenruo
Original Message Subject: Re: [PATCH] Btrfs: fix wrong uevent target From: Anand Jain anand.j...@oracle.com To: Chris Mason c...@fb.com Date: 2014年07月04日 01:32 Chris, This fix is theoretically correct but my guess that this would solve problem as reported by Qu Wenruo

Re: [PATCH v3] btrfs-progs: Add minimum device size check.

2014-07-04 Thread Qu Wenruo
] btrfs-progs: Add minimum device size check. From: Qu Wenruo quwen...@cn.fujitsu.com To: linux-btrfs@vger.kernel.org Date: 2014年06月24日 09:13 Btrfs has global block reservation, so even mkfs.btrfs can execute without problem, there is still a possibility that the filesystem can't be mounted

[PATCH v4] btrfs-progs: Add minimum device size check

2014-07-04 Thread Qu Wenruo
* (system block group + global block rsv) and global block rsv = leafsize 10 Signed-off-by: Qu Wenruo quwen...@cn.fujitsu.com [minor wording tweaks in messages] Signed-off-by: David Sterba dste...@suse.cz --- changelog: v2: Use leafsize to get consistent with kernel global_block_rsv calculation. v3

[PATCH 2/2] btrfs-progs: Add mount point check for 'btrfs fi df' command

2014-07-04 Thread Qu Wenruo
in 'btrfs fi df' and if a file/dir inside a btrfs is given, a warning message will be printed and still output the disk usage info to keep the old behavior. Reported-by: Vikram Goyal vikigo...@gmail.com Signed-off-by: Qu Wenruo quwen...@cn.fujitsu.com --- cmds-filesystem.c | 24

[PATCH 1/2] btrfs-progs: Check fstype in find_mount_root()

2014-07-04 Thread Qu Wenruo
When calling find_mount_root(), caller in fact wants to find the mount point of *BTRFS*. So also check ent-fstype in find_mount_root() and output proper error messages if needed. This will suppress a lot of Inapproiate ioctl for device error message. Signed-off-by: Qu Wenruo quwen

Re: [PATCH v4] btrfs-progs: Add minimum device size check

2014-07-06 Thread Qu Wenruo
Original Message Subject: Re: [PATCH v4] btrfs-progs: Add minimum device size check From: David Sterba dste...@suse.cz To: dste...@suse.cz, Qu Wenruo quwen...@cn.fujitsu.com, linux-btrfs@vger.kernel.org Date: 2014年07月04日 23:21 On Fri, Jul 04, 2014 at 04:17:46PM +0200, David

Re: [PATCH 2/2] btrfs-progs: Add mount point check for 'btrfs fi df' command

2014-07-06 Thread Qu Wenruo
Original Message Subject: Re: [PATCH 2/2] btrfs-progs: Add mount point check for 'btrfs fi df' command From: David Sterba dste...@suse.cz To: Qu Wenruo quwen...@cn.fujitsu.com Date: 2014年07月04日 21:52 On Fri, Jul 04, 2014 at 04:38:49PM +0800, Qu Wenruo wrote: 'btrfs fi df

<    1   2   3   4   5   6   7   8   9   10   >