enr = cpu_to_le64(start);
^
btrfs-image.c:927:6: note: 'start' was declared here
u64 start;
^
Signed-off-by: Tsutomu Itoh
---
btrfs-image.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/btrfs-image.c b/btrfs-image.c
index 0d410f8..47f36b9 100644
--- a/btrfs-imag
On 2016/10/07 1:00, David Sterba wrote:
> On Wed, Oct 05, 2016 at 05:07:48PM +0900, Tsutomu Itoh wrote:
>> In v4.8-rc1, gcc 5.3.1 gives following warning. Fixed it.
>>
>> [CC] btrfs-image.o
>> btrfs-image.c: In function 'flush_pending':
>> btrfs-i
Some unnecessary codes is deleted.
Signed-off-by: Tsutomu Itoh
---
cmds-send.c | 11 ---
1 file changed, 11 deletions(-)
diff --git a/cmds-send.c b/cmds-send.c
index 74d0128..dfdfe01 100644
--- a/cmds-send.c
+++ b/cmds-send.c
@@ -564,8 +564,6 @@ int cmd_send(int argc, char **argv
19 10:37 /tmp/data1
#
[after]
# btrfs send -f /tmp/data1 -c Snap0 -c ../SnapX Snap[12] ../SnapY
At subvol Snap1
At subvol Snap2
At subvol ../SnapY
# ls -l /tmp/data1
-rw--- 1 root root 1492 Oct 19 10:39 /tmp/data1
#
Signed-off-by: Tsutomu Itoh
---
cmds-send.c | 12
1 file
: Tsutomu Itoh
---
cmds-send.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/cmds-send.c b/cmds-send.c
index dfdfe01..2a8a697 100644
--- a/cmds-send.c
+++ b/cmds-send.c
@@ -650,7 +650,7 @@ int cmd_send(int argc, char **argv)
goto out
Some unnecessary codes are deleted.
- the setting of subvol is double.
- read only check was already done by previous loop.
Signed-off-by: Tsutomu Itoh
---
v2: description was changed
---
cmds-send.c | 11 ---
1 file changed, 11 deletions(-)
diff --git a/cmds-send.c b/cmds-send.c
(2011/10/27 3:26), Hugo Mills wrote:
> On Wed, Oct 26, 2011 at 01:51:31PM -0400, Phillip Susi wrote:
>> It still doesn't appear to have returned to kernel.org. Should that
>> happen sometime soon, or is it available somewhere else now?
>
>If the wiki was up (which should be coming back to ker
x27;%u' expects type 'unsigned int', but
argument 3 has type 'long unsigned int'
Signed-off-by: Tsutomu Itoh
---
extent-tree.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/extent-tree.c b/extent-tree.c
index 5bed3c2..5144d57 100644
--- a/exte
In integration-scrub branch, following warning messages were displayed by
running xfstests.
# btrfs fi sh /dev/sdd4
Label: none uuid: 8f28d85c-e37c-4c1b-adef-2627ca59be78
Total devices 2 FS bytes used 31.49MB
devid1 size 9.31GB used 9.31GB path /dev/sdd4
devid2 siz
(2011/11/03 20:19), Chris Mason wrote:
> On Thu, Nov 03, 2011 at 10:25:23AM +0900, Tsutomu Itoh wrote:
>> In integration-scrub branch, following warning messages were displayed by
>> running xfstests.
>>
>> # btrfs fi sh /dev/sdd4
>> Label: none uuid: 8f2
In for-linus branch, when xfstests was executed, the following warning
messages were output.
Thanks,
Tsutomu
===
Nov 7 13:51:00 luna kernel: [ 824.063444] device fsid
2f0ad8a9-93d5-4c99-837f-9db99543133b devid 1 transid 1
Hi, Chris,
(2011/11/04 8:43), Tsutomu Itoh wrote:
> (2011/11/03 20:19), Chris Mason wrote:
>> On Thu, Nov 03, 2011 at 10:25:23AM +0900, Tsutomu Itoh wrote:
>>> In integration-scrub branch, following warning messages were displayed by
>>> running xfstests.
>>>
&
(2011/11/08 1:12), Chris Mason wrote:
> On Mon, Nov 07, 2011 at 02:10:29PM +0900, Tsutomu Itoh wrote:
>> In for-linus branch, when xfstests was executed, the following warning
>> messages were output.
>
> Dave Sterba and I were consistently getting these last week, but aft
(2011/11/07 21:50), David Sterba wrote:
> Hi,
>
> I saw this BUG in current linus' (with last pull included) to quickly
> trigger in xfstests/013, with freshly created fs and default raid flags.
I encountered the same panic this morning, too.
My mount option is,
mount option: compress=lzo
[50
Because cur_trans is set after it has the branch, it is not
necessary to set it here.
Signed-off-by: Tsutomu Itoh
---
fs/btrfs/transaction.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/fs/btrfs/transaction.c b/fs/btrfs/transaction.c
index 960835e..0d28c8f 100644
Hi, Josef,
(2011/11/10 0:17), Josef Bacik wrote:
> On Thu, Nov 03, 2011 at 10:25:23AM +0900, Tsutomu Itoh wrote:
>> In integration-scrub branch, following warning messages were displayed by
>> running xfstests.
>>
>> # btrfs fi sh /dev/sdd4
>> Label: no
(2011/11/10 0:17), Josef Bacik wrote:
> On Thu, Nov 03, 2011 at 10:25:23AM +0900, Tsutomu Itoh wrote:
>> In integration-scrub branch, following warning messages were displayed by
>> running xfstests.
>>
>> # btrfs fi sh /dev/sdd4
>> Label: none uuid: 8f2
(2011/11/09 2:13), David Sterba wrote:
> Hi,
>
> a new BUG_ON on for-linus branch with
In current for-linus branch (8965593e41dd2d0e2a2f1e6f245336005ea94a2c),
I encountered following warning message and same BUG_ON() by running
xfstests/269.
FSTYP -- btrfs
PLATFORM -- Linux/x86_64 l
The filesystem turns to readonly instead of BUG_ON() when
free_log_tree fails.
Signed-off-by: Tsutomu Itoh
---
fs/btrfs/tree-log.c |5 -
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/fs/btrfs/tree-log.c b/fs/btrfs/tree-log.c
index f4d81c0..44bcfba 100644
--- a/fs/btrfs
In the case where the orphan_del fails, and cannot return
error to the caller, the filesystem turns to readonly instead
of BUG_ON().
Signed-off-by: Tsutomu Itoh
---
fs/btrfs/inode.c |8 ++--
1 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/fs/btrfs/inode.c b/fs/btrfs
I encountered following kernel bug when running xfstests/083.
FSTYP -- btrfs
PLATFORM -- Linux/x86_64 luna 3.2.0-rc4
MKFS_OPTIONS -- /dev/sdc2
MOUNT_OPTIONS -- /dev/sdc2 /test9
[ 8208.990166] btrfs: fail to dirty inode 1195 error -28
[ 8208.990578] btrfs: fail to dirty inode
When kmalloc fails, it returns directly by ENOMEM instead
of 'goto out'.
Signed-off-by: Tsutomu Itoh
---
fs/btrfs/acl.c |6 ++
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/fs/btrfs/acl.c b/fs/btrfs/acl.c
index 89b156d..3757995 100644
--- a/fs/btrfs/acl.c
+++
This patch removes the redundant code of error handling for the
cleanup of btree_get_extent().
Signed-off-by: Tsutomu Itoh
---
fs/btrfs/disk-io.c | 14 +-
1 files changed, 5 insertions(+), 9 deletions(-)
diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
index 4c86711..ee07847
load_free_space_cache() has forgotten to free path.
Signed-off-by: Tsutomu Itoh
---
fs/btrfs/free-space-cache.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/fs/btrfs/free-space-cache.c b/fs/btrfs/free-space-cache.c
index 5802b147..b30242f 100644
--- a/fs/btrfs/free
This patch adds the check on the return value of extent_io_ops.
Signed-off-by: Tsutomu Itoh
---
fs/btrfs/extent_io.c | 16 ++--
1 files changed, 10 insertions(+), 6 deletions(-)
diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c
index fcf77e1..a84621f 100644
--- a/fs/btrfs
This patch corrects error checking of lookup_extent_mapping().
Signed-off-by: Tsutomu Itoh
---
fs/btrfs/compression.c |2 ++
fs/btrfs/extent_io.c |2 +-
fs/btrfs/volumes.c |2 +-
3 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/fs/btrfs/compression.c b/fs/btrfs
btrfs_iget() never return NULL. So, NULL check is unnecessary.
Signed-off-by: Tsutomu Itoh
---
fs/btrfs/relocation.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/btrfs/relocation.c b/fs/btrfs/relocation.c
index 8c1aae2..be1caf4 100644
--- a/fs/btrfs
read_tree_block() has the possibility of returning NULL.
So, the code in which it is checked whether the return value is
NULL is added.
Signed-off-by: Tsutomu Itoh
---
fs/btrfs/print-tree.c |1 +
fs/btrfs/relocation.c |2 +-
2 files changed, 2 insertions(+), 1 deletions(-)
diff --git a
bio_alloc() has the possibility of returning NULL.
So, it is necessary to check the return value.
Signed-off-by: Tsutomu Itoh
---
fs/btrfs/compression.c |2 ++
fs/btrfs/extent_io.c |4
fs/btrfs/scrub.c |4
3 files changed, 10 insertions(+), 0 deletions(-)
diff
ree in __btrfs_end_transaction
>
> Liu Bo (1) commits (+18/-2):
> Btrfs: fix eof while discarding extents
>
> Ilya Dryomov (1) commits (+2/-3):
> Btrfs: remove lock assert from get_restripe_target()
>
> Josef Bacik (1) commits (+3/-10):
> Btrfs: use commi
On 2018/07/12 10:25, Lu Fengqi wrote:
> From: Wang Xiaoguang
>
> Add ioctl interface for inband deduplication, which includes:
> 1) enable
> 2) disable
> 3) status
>
> And a pseudo RO compat flag, to imply that btrfs now supports inband
> dedup.
> However we don't add any ondisk format change, i
Sorry for the late reply.
On 2016/10/29 0:10, David Sterba wrote:
> On Wed, Oct 19, 2016 at 11:35:03AM +0900, Tsutomu Itoh wrote:
>> We cannot send multiple snapshots at once by -p option.
>
> We cannot like that it's broken, or we cannot because it's not supposed
&g
On 2016/11/02 21:22, David Sterba wrote:
> On Wed, Oct 19, 2016 at 11:35:40AM +0900, Tsutomu Itoh wrote:
>> When two or more -c options are specified, cannot find a suitable
>> parent. So, output stream is bigger than correct one.
>>
>> [before]
>> # btrfs send -
19 10:37 /tmp/data1
#
[after]
# btrfs send -f /tmp/data1 -c Snap0 -c ../SnapX Snap[12] ../SnapY
At subvol Snap1
At subvol Snap2
At subvol ../SnapY
# ls -l /tmp/data1
-rw--- 1 root root 1492 Oct 19 10:39 /tmp/data1
#
Signed-off-by: Tsutomu Itoh
---
v2: make helper functions
---
cmds-send.c
Sending stream size of clone-src(-c) option is checked.
Signed-off-by: Tsutomu Itoh
---
tests/misc-tests/016-send-clone-src/test.sh | 54 +
1 file changed, 54 insertions(+)
create mode 100755 tests/misc-tests/016-send-clone-src/test.sh
diff --git a/tests/misc-tests
On 2016/11/08 0:16, David Sterba wrote:
> On Fri, Nov 04, 2016 at 05:35:18PM +0900, Tsutomu Itoh wrote:
>> +before_size=`ls -l "$here"/send.stream.before | awk '{print $5}'`
>> +after_size=`ls -l "$here"/send.stream.after | awk '{print $5}'`
&
On 2016/11/08 21:47, David Sterba wrote:
> On Tue, Nov 08, 2016 at 08:53:04AM +0900, Tsutomu Itoh wrote:
>> On 2016/11/08 0:16, David Sterba wrote:
>>> On Fri, Nov 04, 2016 at 05:35:18PM +0900, Tsutomu Itoh wrote:
>>>> +before_size=`ls -l "$here&q
Sending stream size of clone-src(-c) option is checked.
Fixed by "btrfs-progs: send: fix handling of -c option".
Signed-off-by: Tsutomu Itoh
---
V2: old sending stream image is used
---
.../016-send-clone-src/send-stream-v4.8.2.img | Bin 0 -> 6299778 bytes
tests/misc-tests/0
On 2016/11/09 10:39, Qu Wenruo wrote:
>
>
> At 11/09/2016 09:25 AM, Tsutomu Itoh wrote:
>> Sending stream size of clone-src(-c) option is checked.
>> Fixed by "btrfs-progs: send: fix handling of -c option".
>>
>> Signed-off-by: Tsutomu Itoh
>
Sending stream size of clone-src(-c) option is checked.
Fixed by "btrfs-progs: send: fix handling of -c option".
Signed-off-by: Tsutomu Itoh
---
V2: old sending stream image is used
V3: image file has been compressed by gzip
---
.../016-send-clone-src/send-stream-v4.8.2.img.gz
ck btrfs/038
| FSTYP -- btrfs
| PLATFORM -- Linux/x86_64 luna 4.9.0-rc5
| MKFS_OPTIONS -- /dev/sdb3
| MOUNT_OPTIONS -- /dev/sdb3 /test6
|
| btrfs/038 1s ... 1s
| Ran: btrfs/038
| Passed all 1 tests
Signed-off-by: Tsutomu Itoh
---
cmds-send.c | 4 ++--
1 file changed, 2 insertions(+),
xfstests btrfs/038 fails when this patch is applied. Sorry for my fault.
I posted the patch that corrected this problem.
[PATCH] btrfs-progs: send: fix failure of xfstests btrfs/038
Thanks,
Tsutomu
On 2016/10/19 11:35, Tsutomu Itoh wrote:
> We cannot send multiple snapshots at once by
Option -f, -F and --sort don't work because a conditional expression
of ASSERT is wrong.
Signed-off-by: Tsutomu Itoh
---
qgroup.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/qgroup.c b/qgroup.c
index 9d10cb8..071d15e 100644
--- a/qgroup.c
+++ b/qgroup.c
@@ -
Add test-cli to test target of Makefile.
Signed-off-by: Tsutomu Itoh
---
Makefile.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Makefile.in b/Makefile.in
index 4bd3e63..6c78841 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -298,7 +298,7 @@ test-inst: all
/btrfs-progs/tests/mnt
test failed for case 013-extent-tree-rebuild
Makefile:272: recipe for target 'test-fsck' failed
make: *** [test-fsck] Error 1
#
Signed-off-by: Tsutomu Itoh
---
tests/fsck-tests/013-extent-tree-rebuild/test.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
di
convert-tests 004 failed because the argument to check_all_images
is not specified.
# make test-convert
[TEST] convert-tests.sh
[TEST/conv] 004-ext2-backup-superblock-ranges
find: '': No such file or directory
#
Signed-off-by: Tsutomu Itoh
---
tests/convert-tests/004-e
Hi, Qu and David,
On 2016/11/19 3:28, David Sterba wrote:
> On Fri, Nov 18, 2016 at 02:36:28PM +0800, Qu Wenruo wrote:
>>
>>
>> On 11/18/2016 01:47 PM, Tsutomu Itoh wrote:
>>> In my test environment, size of /lib/modules/`uname -r`/* is
>>> larger than 1G
;generate_dataset()' from 'common.convert' to 'common'.
Signed-off-by: Tsutomu Itoh
---
v2: change how to make test files
---
tests/common | 89
tests/common.convert | 89 ---
Hi, David,
Many test of xfstests such as btrfs/007, btrfs/008 and btrfs/016 failed
with the following patch.
fefbab75 btrfs-progs: send-stream: check number of read bytes from stream
This is because cmds-receive.c:do_receive() make a judgement of the end
of stream by returning 1 from send-str
Hi David,
On 2016/11/30 0:34, David Sterba wrote:
> On Mon, Nov 28, 2016 at 04:27:06PM +0900, Tsutomu Itoh wrote:
>> Many test of xfstests such as btrfs/007, btrfs/008 and btrfs/016 failed
>> with the following patch.
>>
>> fefbab75 btrfs-progs: send-stream: chec
r or not to synchronize when executing the command.
Signed-off-by: Tsutomu Itoh
---
Documentation/btrfs-qgroup.asciidoc | 5 +
cmds-qgroup.c | 24 ++--
2 files changed, 27 insertions(+), 2 deletions(-)
diff --git a/Documentation/btrfs-qgroup.asc
Hi Qu,
Thanks for the review.
On 2016/12/07 12:24, Qu Wenruo wrote:
>
>
> At 12/07/2016 11:07 AM, Tsutomu Itoh wrote:
>> The 'qgroup show' command does not synchronize filesystem.
>> Therefore, 'qgroup show' may not display the correct value unl
On 2016/12/07 13:59, Qu Wenruo wrote:
>
>
> At 12/07/2016 12:31 PM, Tsutomu Itoh wrote:
>> Hi Qu,
>>
>> Thanks for the review.
>>
>> On 2016/12/07 12:24, Qu Wenruo wrote:
>>>
>>>
>>> At 12/07/2016 11:07 AM, Tsutomu Itoh wro
r or not to synchronize when executing the command.
Signed-off-by: Tsutomu Itoh
---
v2: use getopt_long with enum instead of single letter (suggested by Qu)
---
Documentation/btrfs-qgroup.asciidoc | 6 ++
cmds-qgroup.c | 33 +
2 files cha
Simple test script for the following patch.
btrfs-progs: qgroup: add sync option to 'qgroup show'
Signed-off-by: Tsutomu Itoh
---
tests/cli-tests/005-qgroup-show-sync/test.sh | 30
1 file changed, 30 insertions(+)
create mode 100755 tests/cli-tests/
On 2016/12/13 18:44, Qu Wenruo wrote:
> Populate fs after convert so we can trigger data chunk allocation.
> This can expose too restrict old rollback condition
>
> Reported-by: Chandan Rajendra
> Signed-off-by: Qu Wenruo
> ---
> tests/common | 4
> tests/common.convert | 3 +++
>
Hi David,
Thanks for the review.
On 2016/12/14 19:54, David Sterba wrote:
> On Wed, Dec 07, 2016 at 04:55:15PM +0900, Tsutomu Itoh wrote:
>> The 'qgroup show' command does not synchronize filesystem.
>> Therefore, 'qgroup show' may not display the correc
en executing the command.
Signed-off-by: Tsutomu Itoh
---
v2: use getopt_long with enum instead of single letter (suggested by Qu)
v3: dropped the --no-sync option and separated the patch of sort
option (suggested by David)
---
Documentation/btrfs-qgroup.asciidoc | 4
The value of sort option ('S') is not used for option letter.
Therefore, I'll change the single letter to non-character.
Signed-off-by: Tsutomu Itoh
---
This patch is separated from patch of --sync option.
---
cmds-qgroup.c | 7 ---
1 file changed, 4 insertions(+), 3 del
Simple test script for the following patch.
btrfs-progs: qgroup: add sync option to 'qgroup show'
Signed-off-by: Tsutomu Itoh
---
v2: dropped the test of --no-sync
---
tests/cli-tests/005-qgroup-show-sync/test.sh | 30
1 file changed, 30 insertions(
On 2016/12/14 23:42, David Sterba wrote:
> Hi,
>
> a pre-release has been tagged. Contains almost the entire devel branch from
> today. There are small fixes, the lowmem mode of check gets more updates but
> still does not work in the --repair mode and is considered experimental.
>
> ETA for 4.9
On 2016/12/15 16:28, Qu Wenruo wrote:
> The subvol_info returned from subvol_uuid_search() can be NULL.
> So the branch checking IS_ERR(si) should also check if it's NULL.
>
> Reported-by: Tsutomu Itoh
> Signed-off-by: Qu Wenruo
> ---
> cmds-receive.c | 2 +-
>
On 2016/12/15 15:45, Tsutomu Itoh wrote:
> On 2016/12/14 23:42, David Sterba wrote:
>> Hi,
>>
>> a pre-release has been tagged. Contains almost the entire devel branch from
>> today. There are small fixes, the lowmem mode of check gets more updates but
>> still d
convert NULL pointer to -ENOENT.
This patch also passed xfstests btrfs/{108,109,117}. Thanks for your work.
Thanks,
Tsutomu
>
> Reported-by: Tsutomu Itoh
> Signed-off-by: Qu Wenruo
> ---
> cmds-receive.c | 16 +++-
> cmds-send.c| 26 ++-
We cannot send multiple snapshots at once.
[before fix]
# btrfs send ./snap[12] > snap12.data
At subvol ./snap1
At subvol ./snap2
ERROR: parent determination failed for 0
#
[after fix]
# btrfs send ./snap[12] > snap12.data
At subvol ./snap1
At subvol ./snap2
#
Signed-off-by: Tsutom
e sdc3): disk deleted /dev/sdc4
[ 84.401951] BTRFS info (device sdc3): disk added /dev/sdb6
Signed-off-by: Tsutomu Itoh
---
fs/btrfs/dev-replace.c | 5 -
fs/btrfs/volumes.c | 11 +--
2 files changed, 13 insertions(+), 3 deletions(-)
diff --git a/fs/btrfs/dev-replace.c b/fs
On 2016/04/05 16:56, Anand Jain wrote:
On 04/05/2016 08:08 AM, Tsutomu Itoh wrote:
When fs_devices->latest_bdev is deleted or is replaced, sb->s_id has
not been updated.
As a result, the deleted device name is displayed by btrfs_printk.
[before fix]
# btrfs dev del /dev/sdc4 /mnt2
#
On 2016/04/05 17:52, Tsutomu Itoh wrote:
On 2016/04/05 16:56, Anand Jain wrote:
On 04/05/2016 08:08 AM, Tsutomu Itoh wrote:
When fs_devices->latest_bdev is deleted or is replaced, sb->s_id has
not been updated.
As a result, the deleted device name is displayed by btrfs_printk.
[befo
On 2016/04/12 3:04, David Sterba wrote:
> The size of root item is more than 400 bytes, which is quite a lot of
> stack space. As we do IO from inside the subvolume ioctls, we should
> keep the stack usage low in case the filesystem is on top of other
> layers (NFS, device mapper, iscsi, etc).
>
>
, iscsi, etc).
>
> Signed-off-by: David Sterba
Looks good to me.
Reviewed-by: Tsutomu Itoh
> ---
> fs/btrfs/ioctl.c | 65
>
> 1 file changed, 37 insertions(+), 28 deletions(-)
>
> diff --git a/fs/btrfs/ioctl.c b/f
gt; btrfs-progs: check: Output verbose error when fsck found a bug in any
> tree
> btrfs-progs: check: lowmem: Fix false alert in checking data extent
> csums
> btrfs-progs: check: lowmem: Fix extent item size false alert
> btrfs-progs: check: lowmem: Fix false
On 2017/03/07 20:54, David Sterba wrote:
> On Tue, Mar 07, 2017 at 11:03:33AM +0900, Tsutomu Itoh wrote:
>> Hi David,
>>
>> On 2017/03/02 23:59, David Sterba wrote:
>>> Hi,
>>>
>>> a pre-release has been tagged. There are patches that have qu
kefile:271: recipe for target 'test-convert' failed
make: *** [test-convert] Error 1
So, remove quotes from $default_mke2fs.
Signed-off-by: Tsutomu Itoh
---
tests/convert-tests/008-readonly-image/test.sh | 2 +-
tests/convert-tests/009-common-inode-flags/test.sh | 2 +-
2 files c
Hi David,
Could you please apply the following patch?
[PATCH] btrfs-progs: tests: remove variable quotation from convert-tests
http://marc.info/?l=linux-btrfs&m=149490441323349&w=2
Thanks,
Tsutomu
On 2017/05/18 23:35, David Sterba wrote:
> Hi,
>
> btrfs-progs version 4.11 have been released.
We should free leaf and root before returning from the error
handling code.
Signed-off-by: Tsutomu Itoh
---
fs/btrfs/disk-io.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
index 7d84651..b1b5baa 100644
--- a/fs/btrfs
Hi,
When inode_cache was specified for the mount option, I encountered the
following messages at umount.
Step to reproduce:
mkfs.btrfs -f /dev/sdc4
mount -o compress=lzo,autodefrag,inode_cache /dev/sdc4 /test1
dd if=/dev/zero of=/test1/file1 bs=1M count=8192
dd if=/test1/file1 of=/dev/null b
On 2013/04/03 10:19, Tsutomu Itoh wrote:
> Hi,
>
> When inode_cache was specified for the mount option, I encountered the
> following messages at umount.
>
> Step to reproduce:
>
> mkfs.btrfs -f /dev/sdc4
> mount -o compress=lzo,autodefrag,inode_cache /dev/sdc4 /t
On 2013/04/03 22:05, Chris Mason wrote:
Quoting Tsutomu Itoh (2013-04-02 21:19:06)
Hi,
When inode_cache was specified for the mount option, I encountered the
following messages at umount.
Step to reproduce:
mkfs.btrfs -f /dev/sdc4
mount -o compress=lzo,autodefrag,inode_cache /dev/sdc4
Argument 'trans' is not used in fixup_low_keys(). So, remove it.
Signed-off-by: Tsutomu Itoh
---
fs/btrfs/ctree.c | 18 --
1 file changed, 8 insertions(+), 10 deletions(-)
diff --git a/fs/btrfs/ctree.c b/fs/btrfs/ctree.c
index ca9d8f1..b5eec7c 100644
--- a/fs/btr
If argument 'trans' is unnecessary in the function where
fixup_low_keys() is called, 'trans' is deleted.
Signed-off-by: Tsutomu Itoh
---
fs/btrfs/ctree.c | 28
fs/btrfs/ctree.h | 10 +++---
fs/btrfs/delayed-inode.c | 11 +
Argument 'trans' is not used in btrfs_extend_item().
Signed-off-by: Tsutomu Itoh
---
fs/btrfs/ctree.c | 3 +--
fs/btrfs/ctree.h | 3 +--
fs/btrfs/dir-item.c| 2 +-
fs/btrfs/extent-tree.c | 4 ++--
fs/btrfs/file-item.c | 2 +-
fs/btrfs/inode-item.c | 4 ++--
fs/
Argument 'trans' became unnecessary from setup_inline_extent_backref()
that called btrfs_extend_item().
Signed-off-by: Tsutomu Itoh
---
fs/btrfs/extent-tree.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/fs/btrfs/extent-tree.c b/fs/btrfs/extent-tree.c
ind
Variable 'p' is not used any more. So, remove it.
Signed-off-by: Tsutomu Itoh
---
fs/btrfs/send.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/fs/btrfs/send.c b/fs/btrfs/send.c
index ed897dc..96a826a 100644
--- a/fs/btrfs/send.c
+++ b/fs/btrfs/send.c
@@ -3479,7 +3479,6 @@
fget() returns NULL if error. So, we should check NULL or not.
Signed-off-by: Tsutomu Itoh
---
fs/btrfs/send.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/btrfs/send.c b/fs/btrfs/send.c
index 96a826a..f892e0e 100644
--- a/fs/btrfs/send.c
+++ b/fs/btrfs/send.c
sctx is removed from the argument of the function that
doesn't use sctx.
Signed-off-by: Tsutomu Itoh
---
fs/btrfs/send.c | 189 +++-
1 file changed, 90 insertions(+), 99 deletions(-)
diff --git a/fs/btrfs/send.c b/fs/btrfs/send.c
problem has not occurred in my testset after applying your patchset.
Your patchset looks good to me. Thanks.
Tested-by: Tsutomu Itoh
>
> But no space error is not a serious problem when we write out the inode cache,
> and it is safe that we just skip this step if we meet this p
Hi,
I encountered following BUG_ON. (I think that -28(ENOSPC) returned from
btrfs_orphan_reserve_metadata maybe.)
When this happened, I was running my stress test. But, I cannot reproduce
this problem yet though the test was executed again several times.
- Tsutomu
[ 4823.473913] btrfs: found 4
,relatime,compress=zlib,space_cache,subvolid=5,subvol=/)
Signed-off-by: Tsutomu Itoh
---
fs/btrfs/disk-io.c | 2 +-
fs/btrfs/super.c | 21 ++---
2 files changed, 15 insertions(+), 8 deletions(-)
diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
index 974be09..dcc1f15 100644
--- a
Hi, David,
On 2016/01/05 23:12, David Sterba wrote:
On Wed, Dec 16, 2015 at 11:57:38AM +0900, Tsutomu Itoh wrote:
diff --git a/fs/btrfs/disk-io.c b/fs/btrfs/disk-io.c
index 974be09..dcc1f15 100644
--- a/fs/btrfs/disk-io.c
+++ b/fs/btrfs/disk-io.c
@@ -2709,7 +2709,7 @@ int open_ctree(struct
,space_cache,subvolid=5,subvol=/)
Signed-off-by: Tsutomu Itoh
---
V1->V2: It is corrected that API doesn't change.
fs/btrfs/super.c | 29 ++---
1 file changed, 22 insertions(+), 7 deletions(-)
diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c
index 24154e4..12d04c9 100644
We need not check path before btrfs_free_path() is called because
path is checked in btrfs_free_path().
Signed-off-by: Tsutomu Itoh
---
fs/btrfs/dev-replace.c | 3 +--
fs/btrfs/inode.c | 3 +--
fs/btrfs/tree-defrag.c | 3 +--
3 files changed, 3 insertions(+), 6 deletions(-)
diff --git a
On 2015/08/19 16:34, Qu Wenruo wrote:
Tsutomu Itoh wrote on 2015/08/19 14:55 +0900:
We need not check path before btrfs_free_path() is called because
path is checked in btrfs_free_path().
Signed-off-by: Tsutomu Itoh
Reviewed-by: Qu Wenruo
Thanks for the review.
BTW, did you check
We need not check path before btrfs_free_path() is called because
path is checked in btrfs_free_path().
Signed-off-by: Tsutomu Itoh
---
cmds-check.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/cmds-check.c b/cmds-check.c
index 4fa8709..8019fb0 100644
--- a/cmds-check.c
Hi, Qu,
On 2015/09/08 17:56, Qu Wenruo wrote:
> Add new structures and functions for new qgroup reserve implement dirty
> phase.
> Which will focus on avoiding over-reserve as in that case, which means
> for already reserved dirty space range, we won't reserve space again.
>
> This patch adds the
Hi, Qu,
On 2015/09/08 18:01, Qu Wenruo wrote:
> New function insert_data_ranges() will insert non-overlap reserve ranges
> into reserve map.
>
> It provides the basis for later qgroup reserve map implement.
>
> Signed-off-by: Qu Wenruo
> ---
> fs/btrfs/qgroup.c | 124
> ++
Hi, Qu,
On 2015/09/08 18:08, Qu Wenruo wrote:
> Introduce functions btrfs_qgroup_release/free_data() to release/free
> reserved data range.
>
> Release means, just remove the data range from data rsv map, but doesn't
> free the reserved space.
> This is for normal buffered write case, when data i
Hi, Qu,
On 2015/09/08 18:08, Qu Wenruo wrote:
> Qgroup reserved space needs to be released from inode dirty map and get
> freed at different timing:
>
> 1) Release when the metadata is written into tree
> After corresponding metadata is written into tree, any newer write will
> be COWed(don't inc
Hi, Qu,
On 2015/09/08 18:22, Qu Wenruo wrote:
> Add new function __btrfs_check_data_free_space() to do precious space
> reservation.
>
> The new function will replace old btrfs_check_data_free_space(), but
> until all the change is done, let's just use the new name.
>
> Also, export internal use
Hi, Qu,
On 2015/09/08 18:22, Qu Wenruo wrote:
> Now fallocate will do accurate qgroup reserve space check, unlike old
> method, which will always reserve the whole length of the range.
>
> With this patch, fallocate will:
> 1) Iterate the desired range and mark in data rsv map
> Only range wh
Hi, Qu,
On 2015/09/08 18:25, Qu Wenruo wrote:
> Cleanup the old facilities which use old btrfs_qgroup_reserve() function
> call, replace them with the newer version, and remove the "__" prefix in
> them.
>
> Also, make btrfs_qgroup_reserve/free() functions private, as they are
> now only used ins
1 - 100 of 297 matches
Mail list logo