[PATCH] Btrfs: make sure there is always room for generation number

io_ctl_set_generation() assumes that the generation number shares the same page with inline CRCs. Let's make sure this is always true. Signed-off-by: Zhihui Zhang --- fs/btrfs/free-space-cache.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/btrfs/free-space-ca

Re: [PATCH] Btrfs: make sure there is always room for generation number

code inspection. If I understand it correctly, we are off by 4 bytes because CRC is 32 bits and generation is 64 bits. But this bug might never hit in practice. thanks, -Zhihui On Wed, Jul 4, 2018 at 11:21 AM, David Sterba wrote: > On Mon, Jul 02, 2018 at 08:00:54PM -0400, Zhihui Zhang wr

Re: idea about internal fragmentation in Btrfs

Makes perfect sense. No wonder some btrfs folks used to work on reiserfs/4. I hope a solution can be or has been found. On Sat, Jun 19, 2010 at 4:51 PM, Andi Kleen wrote: > Zhihui Zhang writes: > >> I wish Btrfs well, so I would venture an idea for this specific case >> m