> hi,
>
> > Add address output in dax_iomap_pfn() in order to perform a memcpy() in
> > CoW case. Since this function both output address and pfn, rename it to
> > dax_iomap_direct_access().
> >
> > Signed-off-by: Shiyang Ruan
> > ---
> > fs/dax.c | 20 +++-
> > 1 file changed
> On Fri, Feb 26, 2021 at 08:20:27AM +0800, Shiyang Ruan wrote:
> > Some operations, such as comparing a range of data in two files under
> > fsdax mode, requires nested iomap_open()/iomap_end() on two file. Thus,
> > we introduce iomap_apply2() to accept arguments from two files and
> > iomap_act
Hi, guys
Beside this patchset, I'd like to confirm something about the "EXPERIMENTAL"
tag for dax in XFS.
In XFS, the "EXPERIMENTAL" tag, which is reported in waring message when we
mount a pmem device with dax option, has been existed for a while. It's a bit
annoying when using fsdax feature
>
> On Fri, Feb 26, 2021 at 08:20:29AM +0800, Shiyang Ruan wrote:
> > error = iomap_zero_range(VFS_I(ip), offset, len, NULL,
> > - &xfs_buffered_write_iomap_ops);
> > + IS_DAX(VFS_I(ip)) ?
> > + &xfs_dax_write_iomap_ops : &xfs_buffered_write_io
>
> On Wed, Mar 03, 2021 at 08:45:14AM +, ruansy.f...@fujitsu.com wrote:
> > Sorry for making you confused. This is because I misunderstood how I should
> > use iomap_apply2(). I have re-sent two new patches to fix this(PATCH 08/10)
> > and the previous(PATCH 07/1
>
> This code looks needlessly complex.
>
> len is never decremented inside the while loop so the while loop
> itself looks unnecessary. Is there some missing decrement of len
> or some other reason to use a while loop?
>
> Is dax_iomap_direct_access some ugly macro that modifies a hidden len?
> >
> > if (dirty)
> > __mark_inode_dirty(mapping->host, I_DIRTY_PAGES);
>
> I still think the __mark_inode_dirty should just be moved into the one
> caller that needs it.
I found that the dirty flag will be used in the next few lines, so I keep
this function inside. If I mov
> On Wed, Mar 03, 2021 at 09:57:48AM +0000, ruansy.f...@fujitsu.com wrote:
> > > What is the advantage of the ioemap_end handler here? It adds another
> > > indirect funtion call to the fast path, so if we can avoid it, I'd
> > > rather do that.
> >
> &
>
> Hi Shiang,
>
> Thanks for picking up this work.
>
> On 8:20 26/02, Shiyang Ruan wrote:
> > This patchset is attempt to add CoW support for fsdax, and take XFS,
> > which has both reflink and fsdax feature, as an example.
>
> How does this work for read sequence for two different files
> map
> hi,
>
> First thanks for your patchset.
> I'd like to know whether your patchset pass fstests? Thanks.
It has been tested by xfstests with quick and clone groups. I did not test it
with other groups yet.
--
Thanks,
Ruan Shiyang.
>
> Regards,
> Xiaoguang Wang
>
> > This patchset is attemp
> > + /* if we are reading UNWRITTEN and HOLE, return a hole. */
> > + if (!write &&
> > + (iomap->type == IOMAP_UNWRITTEN || iomap->type ==
> IOMAP_HOLE)) {
> > + if (!pmd)
> > + return dax_load_hole(xas, mapping, &entry, vmf);
> > + else
> > +
> -Original Message-
> From: Ritesh Harjani
> Sent: Tuesday, March 23, 2021 11:48 PM
> Subject: Re: [PATCH v3 02/10] fsdax: Factor helper: dax_fault_actor()
>
>
>
> On 3/19/21 7:22 AM, Shiyang Ruan wrote:
> > The core logic in the two dax page fault functions is similar. So,
> > move
> -Original Message-
> From: Ritesh Harjani
> Sent: Thursday, April 1, 2021 2:45 PM
> Subject: Re: [PATCH v3 06/10] fsdax: Add dax_iomap_cow_copy() for
> dax_iomap_zero
>
> On 21/03/19 09:52AM, Shiyang Ruan wrote:
> > Punch hole on a reflinked file needs dax_copy_edge() too. Otherwise,
> -Original Message-
> From: Ritesh Harjani
> Sent: Thursday, April 1, 2021 2:40 PM
> Subject: Re: [PATCH v3 05/10] fsdax: Replace mmap entry in case of CoW
>
> On 21/03/19 09:52AM, Shiyang Ruan wrote:
> > We replace the existing entry to the newly allocated one in case of CoW.
> > Also
> -Original Message-
> From: Christoph Hellwig
> Sent: Friday, April 2, 2021 3:50 PM
> Subject: Re: [PATCH v3 00/10] fsdax,xfs: Add reflink&dedupe support for fsdax
>
> Shiyang, Dan:
>
> given that the whole reflink+dax thing is going to take a while and thus not
> going
> to happen f
> -Original Message-
> From: Matthew Wilcox
> Sent: Wednesday, April 7, 2021 7:14 PM
> To: Ruan, Shiyang/阮 世阳
> Cc: linux-ker...@vger.kernel.org; linux-...@vger.kernel.org;
> linux-nvd...@lists.01.org; linux-fsde...@vger.kernel.org;
> darrick.w...@oracle.com; dan.j.willi...@intel.com; j
> -Original Message-
> From: Ritesh Harjani
> Subject: Re: [PATCH v3 08/10] fsdax: Dedup file range to use a compare
> function
>
> On 21/03/19 09:52AM, Shiyang Ruan wrote:
> > With dax we cannot deal with readpage() etc. So, we create a dax
> > comparison funciton which is similar with
> -Original Message-
> From: Su Yue
> Subject: Re: [PATCH v4 7/7] fs/xfs: Add dedupe support for fsdax
>
>
> On Thu 08 Apr 2021 at 20:04, Shiyang Ruan wrote:
>
> > Add xfs_break_two_dax_layouts() to break layout for tow dax files.
> > Then call compare range function only when files
> -Original Message-
> From: Darrick J. Wong
> Sent: Friday, April 9, 2021 5:11 AM
> Subject: Re: [PATCH v2 2/3] fsdax: Factor helper: dax_fault_actor()
>
> On Wed, Apr 07, 2021 at 09:38:22PM +0800, Shiyang Ruan wrote:
> > The core logic in the two dax page fault functions is similar. S
> -Original Message-
> From: Darrick J. Wong
> Sent: Friday, April 9, 2021 5:53 AM
> Subject: Re: [PATCH v4 1/7] fsdax: Introduce dax_iomap_cow_copy()
>
> On Thu, Apr 08, 2021 at 08:04:26PM +0800, Shiyang Ruan wrote:
> > In the case where the iomap is a write operation and iomap is not
>
20 matches
Mail list logo
