Re: [PATCH 0/2] More nritems range checking

2017-08-02 Thread Philipp Hahn
Hello, Am 02.06.2017 um 12:08 schrieb Philipp Hahn: > thank you for applying my last patch, but regarding my corrputed file system I > found two other cases were btrfs crashes: > - btrfs_del_items() was overlooked by me > - deleting from an empty node > > Find attached two

Re: segfault on btrfs --repair

2017-07-17 Thread Philipp Hahn
Hello, Am 16.07.2017 um 13:19 schrieb Tassos Mavroudeas: > let me share with you a segfault on btrfs --repair > > I have backups etc. latest kernel and progs. > > [root@node ~]# uname -a > Linux node 4.12.2 #1 SMP Sun Jul 16 08:15:48 EEST 2017 x86_64 x86_64 > x86_64 GNU/Linux > [root@node ~]#

[PATCH 1/2] btrfs-progs: Check slot + nr >= nritems overflow

2017-06-02 Thread Philipp Hahn
btrfsck to finish without crashing. Signed-off-by: Philipp Hahn <h...@univention.de> --- ctree.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ctree.c b/ctree.c index 798bde9..201f671 100644 --- a/ctree.c +++ b/ctree.c @@ -2656,7 +2656,7 @@ static noinline int btrfs_de

[PATCH 2/2] btrfs-progs: Check nritems under-/overflow

2017-06-02 Thread Philipp Hahn
8229979136, type = 168 '\250', offset = 16384} > ret = > trans = 0x8f0ac0 > path = {nodes = {0xd8ac7d0, 0xd8ccc50, 0x6bf010, 0x0, 0x0, 0x0, 0x0, 0x0}, > slots = {0, 417, 232, 0, 0, 0, 0, 0}, reada = 0 '\000', lowest_level = 0 > '\000', search_for_split = 0 '\000', skip_check_blo

[PATCH 0/2] More nritems range checking

2017-06-02 Thread Philipp Hahn
if "mid == nritems" is valid. (If someone can give me a hand on how to get my FS fixed again, I would appreciate that.) Philipp Hahn (2): btrfs-progs: Check slot + nr >= nritems overflow btrfs-progs: Check nritems under-/overflow ctree.c | 13 +++-- 1 file changed, 7 ins

[PATCHv2] btrfs-progs: Fix slot >= nritems

2017-05-15 Thread Philipp Hahn
en casted to (unsigned long len), which leads to the observed crash. Change the tests before the move to handle only the non-corrupted case, were slow < nritems. This does not fix the corruption, but allows btrfsck to finish without crashing. Signed-off-by: Philipp Hahn <h...@univention.

[PATCH] btrfs-progs: Fix slot >= nritems

2017-05-15 Thread Philipp Hahn
-check.c:11521 > root_cache = {root = {rb_node = 0x98c2940}} > info = 0x6927b0 > bytenr = 6891440 > tree_root_bytenr = 0 > uuidbuf = "f65ff1a1-76ef-456e-beb5-c6c3841e7534" > num = 215575372 > readonly = 218080104

Re: bio linked list corruption.

2016-10-19 Thread Philipp Hahn
t. Nearly a month ago I reported also a "list_add corruption", but with 4.1.6: <http://marc.info/?l=linux-kernel=147508265316854=2> That server rungs Samba4, which also is a heavy user of xattr. Might be that it is related. Philipp Hahn -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html