On Tue, Oct 10, 2017 at 02:08:11PM +0300, Nikolay Borisov wrote:
>
>
> On 10.10.2017 13:48, Rakesh Pandit wrote:
> > Commit a53f4f8e9c8eb ("btrfs: Don't call btrfs_start_transaction() on
> > frozen fs to avoid deadlock.") started using internal calls and we
>
On Tue, Oct 10, 2017 at 02:00:20PM +0300, Nikolay Borisov wrote:
>
>
> On 10.10.2017 13:48, Rakesh Pandit wrote:
> > Commit a53f4f8e9c8eb ("btrfs: Don't call btrfs_start_transaction() on
> > frozen fs to avoid deadlock.") started using internal calls and we
>
Commit a53f4f8e9c8eb ("btrfs: Don't call btrfs_start_transaction() on
frozen fs to avoid deadlock.") started using internal calls and we
replace them with more suitable ones.
Signed-off-by: Rakesh Pandit <rak...@tuxera.com>
---
fs/btrfs/super.c | 4 ++--
1 file changed, 2
Remove ununsed parameters since 71d6bd3c in create_raid_groups.
Signed-off-by: Rakesh Pandit rak...@tuxera.com
---
mkfs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/mkfs.c b/mkfs.c
index dbd83f5..35917f1 100644
--- a/mkfs.c
+++ b/mkfs.c
@@ -210,7 +210,7 @@ static int
It was added in 25d82d22 but broke recently in 4724d7b0 while making
discard interruptible.
Signed-off-by: Rakesh Pandit rak...@tuxera.com
---
utils.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/utils.c b/utils.c
index 0bfb9d9..068b4f3 100644
--- a/utils.c
+++ b/utils.c
btrfs_close_again it again.
Signed-off-by: Rakesh Pandit rak...@tuxera.com
---
disk-io.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/disk-io.c b/disk-io.c
index 19b95a7..8db0335 100644
--- a/disk-io.c
+++ b/disk-io.c
@@ -1091,8 +1091,7 @@ static struct btrfs_fs_info
Lets not assign *info_ptr to 0 before calling free on it and lose
track of already allocated memory if realloc fails in
add_info_to_list. Lets call free first.
Signed-off-by: Rakesh Pandit rak...@tuxera.com
---
cmds-fi-disk_usage.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
It complains errno never gets assigned to zero in find-root and since
errno anyway is zero at program started up, lets remove it.
Check copy is less then zero isn't possible because strtoull used by
arg_strtou64 wouldn't return -ve number.
Trivial space fixes.
Signed-off-by: Rakesh Pandit rak
Lets use errors instead of error because more then one ref errors
are possible. Also print error messages for unresolved refs in
check_root_refs.
Signed-off-by: Rakesh Pandit rak...@tuxera.com
---
cmds-check.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/cmds-check.c
close_inode_for_write always returns 0, so just remove its return
value and remove dead checking in caller.
Signed-off-by: Rakesh Pandit rak...@tuxera.com
---
cmds-receive.c | 13 +++--
1 file changed, 3 insertions(+), 10 deletions(-)
diff --git a/cmds-receive.c b/cmds-receive.c
index
Fix unused parameter str (commit e8cfa3c8): get_subvolid was called
with optarg passed as str, but get_subvolid kept using optarg.
Signed-off-by: Rakesh Pandit rak...@tuxera.com
---
cmds-subvolume.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/cmds-subvolume.c b/cmds
-NULL second argument to
pthread_setcanceltype.
Signed-off-by: Rakesh Pandit rak...@tuxera.com
---
chunk-recover.c | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/chunk-recover.c b/chunk-recover.c
index a05e644..613d715 100644
--- a/chunk-recover.c
+++ b/chunk
in
asynchronous thread but cancelability is disabled after mutex is
locked. This patch moves the call to set cancelability type before
mutex lock and makes corresponding changes to labels for error
handling.
Signed-off-by: Rakesh Pandit rak...@tuxera.com
---
cmds-scrub.c | 31
Threads always use default attributes in all tools, so pthread
attribute objects and their initializations are of no use. Just pass
NULL as attr attribute to pthread_create for default attributes.
Signed-off-by: Rakesh Pandit rak...@tuxera.com
---
cmds-scrub.c | 13 ++---
cmds-send.c
Just cleanup: remove useless return type, while loop and dead code.
Signed-off-by: Rakesh Pandit rak...@tuxera.com
---
btrfs.c | 33 +++--
1 file changed, 11 insertions(+), 22 deletions(-)
diff --git a/btrfs.c b/btrfs.c
index 16458ef..25257b6 100644
--- a/btrfs.c
this fixed, but repeats code from
metadump_destroy. Reuse metadump_destroy by passing number of threads
created (successful pthread_create calls) and save repeated cleaup
code. Had to move metadump_destroy before metadump_init for obvious
reasons.
Signed-off-by: Rakesh Pandit rak...@tuxera.com
to *_destroy from *_init
Signed-off-by: Rakesh Pandit rak...@tuxera.com
---
btrfs-image.c | 84 +--
1 file changed, 36 insertions(+), 48 deletions(-)
diff --git a/btrfs-image.c b/btrfs-image.c
index 7bcfc06..c0195f1 100644
--- a/btrfs-image.c
+++ b
Prevent segfault if memory allocation fails for sargs in get_df
(cmds-filesystem.c).
Signed-off-by: Rakesh Pandit rak...@tuxera.com
---
cmds-filesystem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/cmds-filesystem.c b/cmds-filesystem.c
index c9e27fc..7eb6e9d 100644
Free already allocated memory to item1_data if malloc fails for
item2_data in swap_values. Seems to be a typo from commit 70749a77.
Signed-off-by: Rakesh Pandit rak...@tuxera.com
---
cmds-check.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/cmds-check.c b/cmds-check.c
Hi,
Forgot to mention the reason for change. If accepted this can be
included in commit message:
On Sat, Mar 15, 2014 at 01:49:45AM +0200, Rakesh Pandit wrote:
If pthread_mutex_lock fails (rare but fix it anyway), don't call
pthread_mutex_unlock on mutex.
Rationale being
While formatting multiple devics (and user doesn't specify -M) if one
of them has block count or size less then 1 GiB, mkfs doesn't tell
user, on which one mixed metadata/data was forced. This patch updates
message to print device name.
Signed-off-by: Rakesh Pandit rak...@tuxera.com
---
mkfs.c
On Wed, Mar 12, 2014 at 05:36:14PM +0100, David Sterba wrote:
On Wed, Mar 12, 2014 at 03:43:24PM +0200, Rakesh Pandit wrote:
While formatting multiple devics (and user doesn't specify -M) if one
of them has block count or size less then 1 GiB, mkfs doesn't tell
user, on which one mixed
] didn't find the relative chunk.
Ideally btfsck should be updated to reflect this default behavior and
not through these messages, but it isn't harmful and can be done
later.
Signed-off-by: Rakesh Pandit rak...@tuxera.com
---
btrfs-image.c| 3 ---
man/btrfs-image.8.in | 5 -
2 files
In btrfs_find_last_root before returning with -ENOENT (if root item is
not found) free path and also remove btrfs_release_path before
btrfs_free_path because btrfs_free_path anyway calls it.
Signed-off-by: Rakesh Pandit rak...@tuxera.com
---
root-tree.c | 6 +++---
1 file changed, 3 insertions
Since commit c652e4ef changes default metadata blocksize, update
corresponding options in man page.
Signed-off-by: Rakesh Pandit rak...@tuxera.com
---
man/mkfs.btrfs.8.in | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/man/mkfs.btrfs.8.in b/man/mkfs.btrfs.8.in
index
, 1073741824] (flags = 36) didn't find the relative chunk.
Even though ./btrfsck on /dev/sdb2 seemed fine. This is due to type
mismatch above and type mismatch occured because we zero'ed out
BTRFS_BLOCK_GROUP_DUP while handling chunk trees.
Signed-off-by: Rakesh Pandit rak...@tuxera.com
---
btrfs
26 matches
Mail list logo