Re: [PATCH] iversion: make inode_cmp_iversion{+raw} return bool instead of s64

2018-01-30 Thread Trond Myklebust
turn (s64)(inode_peek_iversion_raw(inode) & > ~I_VERSION_QUERIED) - > -(s64)(old << I_VERSION_QUERIED_SHIFT); > + return (inode_peek_iversion_raw(inode) & ~I_VERSION_QUERIED) > != > + (old << I_VERSION_QUERIED_SHIFT); > } Is there any reason why this couldn't just use inode_peek_iversion() instead of having to both mask the output from inode_peek_iversion_raw() and shift 'old'? > #endif -- Trond Myklebust Linux NFS client maintainer, PrimaryData trond.mykleb...@primarydata.com

Re: [PATCH v5 8/9] vfs: Add vfs_copy_file_range() support for pagecache copies

2015-10-12 Thread Trond Myklebust
On Mon, Oct 12, 2015 at 7:17 PM, Darrick J. Wong wrote: > On Sun, Oct 11, 2015 at 07:22:03AM -0700, Christoph Hellwig wrote: >> On Wed, Sep 30, 2015 at 01:26:52PM -0400, Anna Schumaker wrote: >> > This allows us to have an in-kernel copy mechanism that avoids frequent >>

Re: [PATCH v1 0/8] VFS: In-kernel copy system call

2015-09-09 Thread Trond Myklebust
On Wed, Sep 9, 2015 at 4:09 PM, Chris Mason wrote: > On Tue, Sep 08, 2015 at 04:08:43PM -0700, Andy Lutomirski wrote: >> On Tue, Sep 8, 2015 at 3:39 PM, Darrick J. Wong >> wrote: >> > On Tue, Sep 08, 2015 at 02:45:39PM -0700, Andy Lutomirski wrote: >> >>

Re: [PATCH RFC 1/3] vfs: add copy_file_range syscall and vfs helper

2015-04-10 Thread Trond Myklebust
Hi Zach, On Fri, Apr 10, 2015 at 6:00 PM, Zach Brown z...@redhat.com wrote: Add a copy_file_range() system call for offloading copies between regular files. This gives an interface to underlying layers of the storage stack which can copy without reading and writing all the data. There are a

Re: What to do about subvolumes?

2010-12-07 Thread Trond Myklebust
the mk_fsid() helper in fs/nfsd/nfsfh.h Cheers Trond -- Trond Myklebust Linux NFS client maintainer NetApp trond.mykleb...@netapp.com www.netapp.com -- To unsubscribe from this list: send the line unsubscribe linux-btrfs in the body of a message to majord...@vger.kernel.org More majordomo info at http